| Summary: | Assert in tool invocations | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Tiar <tamtamy.tymona> |
| Component: | General | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | ||
| Priority: | NOR | ||
| Version First Reported In: | git master (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | Mint (Ubuntu based) | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/commit/ad9e3211d82204ff9461c45aec2b82f5f95bd306 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: | Crash log for all threads | ||
|
Description
Tiar
2021-03-20 01:44:18 UTC
Git commit 5c6d30a5d1de83128e73fff9f61b12d34cfacd5d by Dmitry Kazakov. Committed on 02/08/2021 at 15:17. Pushed by dkazakov into branch 'master'. Rename KisImage::lock() into KisImage::immediateLockForReadOnly() If we lock for write we must regenerate LodN planes, which is not possible right inside the stroke. Therefore, if you need to lock the image for write you need to use image->barrierLock(). It ensures that all the strokes are finished before you do any modifications to the image. M +3 -3 libs/image/kis_image.cc M +1 -1 libs/image/kis_image.h M +3 -3 libs/image/kis_update_scheduler.cpp M +1 -1 libs/image/kis_update_scheduler.h M +1 -1 libs/image/tests/kis_update_scheduler_test.cpp M +1 -1 libs/ui/canvas/kis_canvas2.cpp M +1 -1 plugins/dockers/recorder/recorder_writer.cpp M +4 -2 plugins/tools/basictools/kis_tool_colorsampler.cc https://invent.kde.org/graphics/krita/commit/5c6d30a5d1de83128e73fff9f61b12d34cfacd5d Git commit ad9e3211d82204ff9461c45aec2b82f5f95bd306 by Dmitry Kazakov. Committed on 02/08/2021 at 15:17. Pushed by dkazakov into branch 'master'. Fix an assert in KisStrokesQueue when cancelling LoDN stroke too quickly When the user cancells the stroke with Esc key and starts a new stroke with instant preview too quickly, the queue may enter a race condition, when the current lod range is not estimated correctly. To overcome this issue, we now add a fake legacy stroke into the end of the queue to make sure that the lod range is properly closed. M +22 -2 libs/image/kis_strokes_queue.cpp M +100 -0 libs/image/tests/kis_strokes_queue_test.cpp M +2 -0 libs/image/tests/kis_strokes_queue_test.h https://invent.kde.org/graphics/krita/commit/ad9e3211d82204ff9461c45aec2b82f5f95bd306 |