| Summary: | copy paste broken | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Manga Tengu <mangatengu> |
| Component: | Usability | Assignee: | vanyossi <ghevan> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | ghevan, halla |
| Priority: | NOR | ||
| Version First Reported In: | 4.4.3-beta2 | ||
| Target Milestone: | --- | ||
| Platform: | macOS (DMG) | ||
| OS: | macOS | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
|
Description
Manga Tengu
2021-03-19 11:39:55 UTC
Um... Is this supposed to work at all? Selecting copy in the file manager doesn't put the image on the clipboard, but the file name, as far as I can tell. up until now it worked well. btw if that can help, I could even copy paste between photoshop and krita. Hm, it works with older versions of macOS, but not with Big Sur. Only if I move the file into the Documents folder can I paste it -- and then I get the icon, not the file contents. Maybe we need extra permissions to read that. Drag and drop still works. yes drag & drop works but with the following issue: https://bugs.kde.org/show_bug.cgi?id=434618 This has never worked, there is no code in krita for it. (at least not as old as I could look). KisClipboardUtil.cpp manages the clipboard pasting. And the supported mimetypes does not include text/uri-list. Below are the mimetypes reported from clipboard when copying from Finder "text/uri-list" "text-plain" "application/x-qt-image" When the image is not generated from clipboard we fallback to the default "QApplication::clipboard()->image() contents which are the mimetype icons. Clipboard expects image data to return, in case of a text/uri-list mimetype the most we can do whitout refactoring is to take the first element in the list and load the image from file. ?? BTW: Copying and pasting between programs works perfectly fine. 1. From finder open document in "Preview" 2. Cmd + C 3. Paste in krita (or open from clipboard) can we change the title and move this to a wish maybe? True I have mixed memories. The thing I'm used to doing is right-click copy layer and then Cmd + shift + N to get a new perfectly sized image... I feel like this is an expected behavior. I mean I guess most people would expect it to act this way? I got confused because I was pasting into a too small file, but I don't think so -- you're copying a file, not an image. It works like that in other programs and I find it feels natural. I guess I'm the only one here. A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/766 Decided to hack a little code to see how it behaves. (MR above) Copying from dolphin or Finder works correctly, however I did not tested all paste contexts, only "create from clipboard" and "paste into canvas" as those are the ones I modified. What I've seen is that the KisClipBoardUtil is not used to parse in all clipboard contexts but only one case. I had to add it to kis_image_from_clipboard to load dimensions correctly. While not confirmed, im assigning the report to me, and changing it to a whish. Bug is fixed now, MR https://invent.kde.org/graphics/krita/-/merge_requests/766 is merged |