Bug 434559

Summary:	Toggling "Share curve across all settings" usually resets all of the brush option's curves
Product:	[Applications] krita	Reporter:	tomtomtomreportingin
Component:	Usability	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	gjditchfield, halla, tamtamy.tymona
Priority:	NOR
Version:	4.4.2
Target Milestone:	---
Platform:	Appimage
OS:	Linux
Latest Commit:	https://invent.kde.org/graphics/krita/-/commit/b89e4785abdeb9824ef5cb6c9e6431af7f8d55cb	Version Fixed In:
Sentry Crash Report:

Description tomtomtomreportingin 2021-03-17 19:37:51 UTC

SUMMARY
Toggling "Share curve across all settings" for a particular sensor usually resets all the curves within that option to the standard linear curve. This is pretty annoying when you, for example, want to add a subtle Fuzzy Dab effect to a brush that already has a finely tuned Pressure curve.

STEPS TO REPRODUCE
1. Select Basic 1 brush.
2. Open Brush Settings, select and enable Size option.
3. Create a custom curve for Pressure.
4. Select and enable Fuzzy Dab.
5. Disable "Share curve across all settings"
6. Select Pressure.

OBSERVED RESULT
All curves for Size have reset to the standard linear curve.

EXPECTED RESULT
The current curves should not be discarded.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Debian sid
KDE Plasma Version: 5.20.5
KDE Frameworks Version: 5.78.0
Qt Version: 5.12.9 (Appimage) 

ADDITIONAL INFORMATION
I've noticed that this doesn't always happen for certain brushes.

Comment 1 Bug Janitor Service 2021-03-24 15:55:40 UTC

A possibly relevant merge request was started @ https://invent.kde.org/pim/incidenceeditor/-/merge_requests/15

Comment 2 Bug Janitor Service 2021-03-24 15:57:34 UTC

A possibly relevant merge request was started @ https://invent.kde.org/pim/korganizer/-/merge_requests/20

Comment 3 tomtomtomreportingin 2021-03-24 19:39:57 UTC

I am going to guess the "Assigned" status wasn't intentional, but I can't change this back to "Reported" either.

Comment 4 Halla Rempt 2021-03-24 19:43:42 UTC

Fixed that.

Comment 5 gjditchfield 2021-03-24 22:28:47 UTC

Git commit bccc8998ce2cc867e6508bf4a6ddd8630c32e500 by Glen Ditchfield.
Committed on 24/03/2021 at 15:38.
Pushed by gditchfield into branch 'release/21.04'.

Add time and time zone to EXDATEs of DATE-TIME instances

KOrganizer creates DATE values for exceptions to recurring
instances, even if the incidence is not "all day" (i.e. DTSTART is a
DATE-TIME value).  EXDATE identifies a specific instance and arguably
should follow the same rules as RECURRENCE-ID.  RFC 5545 does not say
so, but [erratum 6316](https://www.rfc-editor.org/errata/eid6316) does.
In practice, other important systems reject EXDATEs that do not match
DTSTART.

Original patch written by Jochen.Trumpf@anu.edu.au.
Related: bug 169336
FIXED-IN: 5.17.0

M  +9    -3    src/calendarview.cpp

https://invent.kde.org/pim/korganizer/commit/bccc8998ce2cc867e6508bf4a6ddd8630c32e500

Comment 6 gjditchfield 2021-03-24 22:29:17 UTC

Git commit 261ac6e7e2b0d7cd19f0624c1555648f65db2b92 by Glen Ditchfield.
Committed on 24/03/2021 at 14:58.
Pushed by gditchfield into branch 'release/21.04'.

Add time and time zone to EXDATEs of DATE-TIME instances

The incidence editor creates DATE values for exceptions to recurring
instances, even if the incidence is not "all day" (i.e. DTSTART is a
DATE-TIME value).  EXDATE identifies a specific instance and arguably
should follow the same rules as RECURRENCE-ID.  RFC 5545 does not say
so, but [erratum 6316](https://www.rfc-editor.org/errata/eid6316) does.
In practice, other important systems reject EXDATEs that do not match
DTSTART.

Original patch written by Jochen.Trumpf@anu.edu.au.
Related: bug 169336
FIXED-IN: 5.17.0

M  +58   -9    src/incidencerecurrence.cpp
M  +1    -0    src/incidencerecurrence.h

https://invent.kde.org/pim/incidenceeditor/commit/261ac6e7e2b0d7cd19f0624c1555648f65db2b92

Comment 7 Tiar 2021-03-24 23:56:35 UTC

For all the future readers, confused about the comments with commits (comment#5 and comment#6): They were actually meant for bug 434599, not for this bug.

Comment 8 tomtomtomreportingin 2021-08-29 05:07:47 UTC

Fixed as of https://invent.kde.org/graphics/krita/-/merge_requests/999 getting merged.