| Summary: | Mobile and Desktop playlists differ in appearance and what they're good at displaying | ||
|---|---|---|---|
| Product: | [Applications] Elisa | Reporter: | popov895 <popov895> |
| Component: | general | Assignee: | Matthieu Gallien <matthieu_gallien> |
| Status: | CONFIRMED --- | ||
| Severity: | normal | CC: | nate, popov895, postix, vikts |
| Priority: | NOR | ||
| Version: | 20.12.3 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | Desktop view vs mobile view | ||
Yeah IMO we need to unify these into a single view that displays nicely for both the "whole albums" and "all songs from different albums" use cases. *** Bug 437730 has been marked as a duplicate of this bug. *** Git commit 5d8c2630d8b113c3f3a7779e299cd43c2234614a by Nate Graham, on behalf of Tranter Madi. Committed on 21/02/2022 at 18:42. Pushed by ngraham into branch 'master'. Make more use of Kirigami stuff - Use Kirigami stuff instead of handmade ones. - `alternativeBackground` should only be used when section is not used. Related: bug 448461, bug 447984 FIXED-IN: 22.04 M +0 -1 src/CMakeLists.txt M +4 -8 src/qml/BasicPlayListAlbumHeader.qml M +0 -2 src/qml/ContentView.qml D +0 -254 src/qml/DraggableItem.qml M +0 -2 src/qml/ElisaMainWindow.qml M +1 -3 src/qml/HeaderBar.qml M +100 -161 src/qml/MediaPlayListView.qml M +209 -249 src/qml/PlayListEntry.qml M +32 -50 src/qml/SimplePlayListView.qml M +130 -168 src/qml/mobile/MobilePlayListDelegate.qml M +29 -3 src/qml/shared/BasePlayListDelegate.qml M +0 -1 src/resources.qrc https://invent.kde.org/multimedia/elisa/commit/5d8c2630d8b113c3f3a7779e299cd43c2234614a Git commit ac4e1b5497e5c1ed903478175793579bd55125f5 by Nate Graham, on behalf of Tranter Madi. Committed on 08/03/2022 at 04:00. Pushed by ngraham into branch 'master'. Improve playlist button handling - Avoid the label overlapping the hovering buttons when the width of the playlist is small enough and the user clicks the play button - Collapse button row into a menu when playlist is very narrow - Use better icon for "remove" - Remove some unneeded code FIXED-IN: 22.04 M +22 -0 src/qml/BaseTheme.qml M +4 -24 src/qml/ContentView.qml M +147 -119 src/qml/PlayListEntry.qml https://invent.kde.org/multimedia/elisa/commit/ac4e1b5497e5c1ed903478175793579bd55125f5 Git commit 76972cecb45d2cc841e8569b42826ac55e695ad5 by Nate Graham, on behalf of Tranter Madi. Committed on 04/04/2022 at 19:27. Pushed by ngraham into branch 'master'. Dynamically switch between album-style and standalone-song-style playlist items Now the style of playlist items will be dynamically changed according to whether they are part of an album with other songs from the same album, or if they are alone and their neighbors are both from different albums. M +1 -12 src/qml/BaseTheme.qml M +18 -23 src/qml/BasicPlayListAlbumHeader.qml M +90 -34 src/qml/MediaPlayListView.qml M +91 -40 src/qml/PlayListEntry.qml M +48 -30 src/qml/SimplePlayListView.qml https://invent.kde.org/multimedia/elisa/commit/76972cecb45d2cc841e8569b42826ac55e695ad5 Git commit 0d8c7b859d11f4d59882c3cf5076353d06ba28b8 by Nate Graham. Committed on 03/06/2022 at 20:03. Pushed by ngraham into branch 'master'. Play song in playlist when tapped with a touchscreen Double-click isn't a thing on touch; people expect things to react on a single tap. Let's honor that assumption by making playlist items play when tapped once with a tochscreen. To make the extra actions for unselected songs more accessible, now playlist items' overflow menu buttons are always visible. Related: bug 454343 FIXED-IN: 22.08 M +3 -3 src/qml/PlayListEntry.qml M +2 -2 src/qml/shared/BasePlayListDelegate.qml https://invent.kde.org/multimedia/elisa/commit/0d8c7b859d11f4d59882c3cf5076353d06ba28b8 A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/463 Git commit 6acac15793cf8ef2b2a1916767910e87c50b798c by Nate Graham, on behalf of Jack Hill.
Committed on 15/09/2023 at 17:32.
Pushed by ngraham into branch 'master'.
Converge {Grid,List}BrowserDelegate desktop/mobile actions, and port PlayListEntry's actions to Kirigami.Action
- Some strings were different between platforms, so I've kept desktop strings.
M +8 -27 src/qml/GridBrowserDelegate.qml
M +19 -70 src/qml/ListBrowserDelegate.qml
M +40 -89 src/qml/PlayListEntry.qml
M +3 -11 src/qml/mobile/MobilePlayListDelegate.qml
M +1 -0 src/qml/shared/BasePlayListDelegate.qml
https://invent.kde.org/multimedia/elisa/-/commit/6acac15793cf8ef2b2a1916767910e87c50b798c
Git commit ed0a78e79de1a90c694b3ca105d423d4a5f27e43 by Nate Graham. Committed on 18/10/2023 at 17:39. Pushed by ngraham into branch 'master'. Play list items with single-click, not double-click There isn't really a good reason to require a double-click to play these list items. For files and folders, this paradigm is used for items that can be selected and have actions which can be applied to them when selected, which does describe these list items. However they also have actions that appear on hover, blunting that reason. These list items already play on single-click on touch mode, mobile mode, and in party mode without any real issues, so let's just do the same thing in non-party desktop mode too. M +1 -11 src/qml/ListBrowserDelegate.qml M +0 -7 src/qml/shared/BasePlayListDelegate.qml https://invent.kde.org/multimedia/elisa/-/commit/ed0a78e79de1a90c694b3ca105d423d4a5f27e43 |
Created attachment 136691 [details] Desktop view vs mobile view SUMMARY Add the option to display the playlist as a simple list (same as for mobile). Currently on desktop the playlist looks weird when you give it a collection of songs from different albums. SOFTWARE/OS VERSIONS Linux/KDE Plasma: KDE neon 5.21 User Edition / X11 KDE Plasma Version: 5.21.2 KDE Frameworks Version: 5.79.0 Qt Version: 5.15.2