| Summary: | Size inconsistency in initials-style avatar (default vs change avatar) | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kirigami | Reporter: | Massimiliano L <m.lincetto> |
| Component: | general | Assignee: | Marco Martin <notmart> |
| Status: | REPORTED --- | ||
| Severity: | minor | CC: | nate, pandom79, plasma-bugs, uhhadd |
| Priority: | NOR | ||
| Version: | 5.80.0 | ||
| Target Milestone: | Not decided | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | Avatar after re-setting it through dialog | ||
Decreasing "font.pixelSize" property at https://invent.kde.org/plasma/plasma-desktop/-/blob/master/kcms/users/package/contents/ui/UserDetailsPage.qml#L419 from font.pixelSize: Kirigami.Units.gridUnit * 4 to font.pixelSize: Kirigami.Units.gridUnit * 2.5 it looks good for me. (In reply to Domenico Panella from comment #1) > Decreasing "font.pixelSize" property > at > https://invent.kde.org/plasma/plasma-desktop/-/blob/master/kcms/users/ > package/contents/ui/UserDetailsPage.qml#L419 > > from > font.pixelSize: Kirigami.Units.gridUnit * 4 > > to > font.pixelSize: Kirigami.Units.gridUnit * 2.5 > > it looks good for me. I understand you propose a change that makes the font smaller but do we understand why the font was changeing size compared to the default? (In reply to Massimiliano L from comment #2) > (In reply to Domenico Panella from comment #1) > > Decreasing "font.pixelSize" property > > at > > https://invent.kde.org/plasma/plasma-desktop/-/blob/master/kcms/users/ > > package/contents/ui/UserDetailsPage.qml#L419 > > > > from > > font.pixelSize: Kirigami.Units.gridUnit * 4 > > > > to > > font.pixelSize: Kirigami.Units.gridUnit * 2.5 > > > > it looks good for me. > > I understand you propose a change that makes the font smaller but do we > understand why the font was changeing size compared to the default? Yeah, the default image is an Item of the "Text" type not Image, whereas when we select a new image with initial letters from dialog window, we save it as Image (PNG). This is the code which saves the image as PNG file https://invent.kde.org/plasma/plasma-desktop/-/blob/master/kcms/users/package/contents/ui/UserDetailsPage.qml#L424-434 This is the code (kirigami side) which we decide to show Item text (default case) or image https://invent.kde.org/frameworks/kirigami/-/blob/master/src/controls/Avatar.qml#L203-249 At the moment i see two potential problems: 1) The letters font is too large when we select the image from window dialog. (fixed it simply by decreasing it) 2) If you attentively observe it, the new image is different than default how it's rendering too. This appears slightly blurry respect the default image. In my opinion, the default image and the image which we select via window dialog should be handled at the same way. I mean both handled as Image or Text otherwise we will always see the difference between them. (In reply to Domenico Panella from comment #3) > In my opinion, the default image and the image which we select via window > dialog should be handled at the same way. > I mean both handled as Image or Text otherwise we will always see the > difference between them. I agree with your view. It is otherwise a bit strange to have a default configuration that can never be reset to default. Harmonising the two would be a good idea. |
Created attachment 136674 [details] Avatar after re-setting it through dialog SUMMARY The default initials-style avatar has a different size compared to the one that is obtained using the "Change Avatar" dialog. In particular, the latter is bigger and the letters overshoot the boundary of the circle (see attachment). STEPS TO REPRODUCE 1. Fresh install KDE Neon 2. Change avatar and select one colour option among the initials-style 3. Apply OBSERVED RESULT The letters in the new avatar are bigger compared to the default, and overshoot the boundary of the circle. EXPECTED RESULT It should be possible to obtain the default, properly-sized. SIDE NOTE From the Users configuration module there is no direct way to reset the avatar to the system default one, while other modules have a "Default" button to restore the system defaults. SOFTWARE/OS VERSIONS Linux/KDE Plasma: (available in About System) KDE Plasma Version: 5.21.2 KDE Frameworks Version: 5.80.0 Qt Version: 5.15.2