| Summary: | Visual bugs due to very long screen name | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | Ismael Asensio <isma.af> |
| Component: | kcm_kscreen | Assignee: | kscreen-bugs-null <kscreen-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | plasma-bugs-null |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/kscreen/commit/afb4a77b13f81f99fbe8cedbbdf5e6add20adaa7 | Version Fixed/Implemented In: | 5.22 |
| Sentry Crash Report: | |||
| Attachments: |
KScreen KCM (screen 0)
KScreen KCM (screen 1) KScreen KCM (transition) |
||
Created attachment 136656 [details]
KScreen KCM (screen 1)
Created attachment 136657 [details]
KScreen KCM (transition)
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kscreen/-/merge_requests/17 A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kirigami/-/merge_requests/260 Git commit 1bf793bf9f9c76d8694b034da1be170ca259d9d3 by Ismael Asensio. Committed on 23/03/2021 at 14:58. Pushed by iasensio into branch 'master'. [FormLayout] Use layout boundaries on twin layout hints When calculating the implicit size hint of a twin layout, we were not taking into account the Layout boundaries that those items may have (Layout.maximumWidth and Layout.minimumWidth) This could result in the layout going to narrow mode, when visually all of the twin items could fit within the wide mode. FIXED-IN: 5.81 M +8 -1 src/controls/FormLayout.qml https://invent.kde.org/frameworks/kirigami/commit/1bf793bf9f9c76d8694b034da1be170ca259d9d3 Git commit afb4a77b13f81f99fbe8cedbbdf5e6add20adaa7 by Ismael Asensio. Committed on 23/03/2021 at 15:10. Pushed by iasensio into branch 'master'. kcm: Limit the width of the scaling slider If the slider row is set to fillWidth, then the slider from the first delegate can overlap the slider of the second delegate. Limit the size to the same amount as the Device combobox. FIXED-IN: 5.22 M +2 -0 kcm/package/contents/ui/OutputPanel.qml https://invent.kde.org/plasma/kscreen/commit/afb4a77b13f81f99fbe8cedbbdf5e6add20adaa7 Git commit 18a034e54f5f7613ceb3ca9808173c30fe90dba1 by Ismael Asensio. Committed on 31/03/2021 at 01:56. Pushed by iasensio into branch 'master'. kcm: Add correct spacing to the swipeview With an spacing value = 0, the second delegate of the SwipeView will be visible in the right margin region of the first delegate. This shows up mainly when the FormLayout goes into narrow mode, since then the items are left aligned and more likely to get into the visible part. M +1 -0 kcm/package/contents/ui/Panel.qml https://invent.kde.org/plasma/kscreen/commit/18a034e54f5f7613ceb3ca9808173c30fe90dba1 |
Created attachment 136655 [details] KScreen KCM (screen 0) SUMMARY Having a very long name for a screen causes several visual bugs and inconsistencies, specially on a dual-monitor setup: 1 - The label on the screen selector overflows the screen representation 2 - Options form for the second screen show partially on the margin when the first screen is selected 3 - Scaling slider for the first screen shows and overlaps when the second screen is selected STEPS TO REPRODUCE 1. Have a screen with a very long name (probably easier if it can be mocked-up) 2. Commute between screens in the KCM ADDITIONAL INFORMATION: (3) is caused by the combobox selector becoming too wide, which makes the FormLayout (and the associated twin FormLayouts) wider than the actual available space. The slider has fillWidth:true, which makes it flood into the second column of the SwipeView. Setting the combo maximumWidth to the FormLayout width fixes this by cropping the components to the space available, but with a horrible binding loop. The combination of twin FormLayouts and a SwipeView makes it a little complicated to set it the right way in the right place. A general improvement would be to get a shorter name for the screens. Mine currently is: "Samgsung Electric Company SAMSUNG (Samsung Electric Company HDMI-A-1-SAMSUNG/16780800)" SOFTWARE/OS VERSIONS (available in About System) KDE Plasma Version: 5.22 (git master) KDE Frameworks Version: 5.81 (git master) Qt Version: 5.15.3