| Summary: | Calamares window doesn't get a separator line drawn below the titlebar | ||
|---|---|---|---|
| Product: | [Plasma] Breeze | Reporter: | Harald Sitter <sitter> |
| Component: | QStyle | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | RESOLVED DOWNSTREAM | ||
| Severity: | normal | CC: | nate, noahadvs, uhhadd |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: |
screenshot of calamares
calamares in 5.20 times |
||
|
Description
Harald Sitter
2021-03-12 15:34:33 UTC
Created attachment 136611 [details]
screenshot of calamares
Created attachment 136613 [details]
calamares in 5.20 times
I'm also adding a 5.20 screenshot to see how the visuals were before
There's supposed to be a separator line drawn below the titlebar in this circumstance, as there is in, for example, Spectacle and the open/save dialogs. What UI toolkit is Calamares written in? Qt with QWidgets or QML? Something else? qwidgets In that case there's a bug here, and we can fix it. This happens whenever an app uses 100% of the window's surface area; leaving none for the style to use. We previously used to set a contents margins on windows without tools areas, but this was buggy and broke some apps. There's no other mechanisms for us to ensure that the window will have necessary blank space for the separator, so this is sort of unfixable from the Breeze side. This is generally fine for apps that use standard layouting and controls, but highly custom apps like Calamares that do large amounts of custom drawing and layouting won't work, because their customisation is overriding what the QStyle has to work with. If a highly custom app like this wants to fit into our visual design, the highly custom app needs to either use a more standard layout that QStyles are capable of working with, or explicitly hardcode their custom styling for Breeze. Either way, this isn't something we're capable of fixing in Breeze, due to aforementioned app breakage when we tried to carve out a pixel row for us to draw a separator in the higly custom app case. Could we put the line on the bottom of the window decoration titlebar? That was a long discussion we had when implementing the feature initially. The short summary is "no." Do you remember more than that? Why can't we make the window decoration communicate with the rest of the theme? When the window under it is not being Breeze-themed, then it could draw the line. Why won't that work? IIRC Oxygen did something like that. |