Bug 434297

Summary:	The "Tab Color" dropdown in "Current Tab Settings" defaults to the wrong value
Product:	[Applications] konsole	Reporter:	St Weiss <x.kde>
Component:	tabbar	Assignee:	J <oslazu>
Status:	RESOLVED FIXED
Severity:	normal	CC:	oslazu
Priority:	NOR
Version:	20.08.2
Target Milestone:	---
Platform:	Kubuntu
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description St Weiss 2021-03-11 18:13:24 UTC

SUMMARY
When I rename a tab using the "Current Tab Settings" dialog, the tab's color also changes. This is because the same dialog is used to set the tab's title and color. If no color has been set for this tab yet, the "Tab Color" dropdown defaults to white, rather than the current color (none). I have to manually select "Color from theme" to only change the title. "Color from theme" should be the default.

STEPS TO REPRODUCE
1. Open a new tab
2. Open the "Current Tab Settings" dialog (right click on tab, or via keyboard shortcut)
3. Enter a new tab title
4. Press enter key or click "OK"

OBSERVED RESULT
The tab name is updated, and it now has a thick white border at the bottom.

EXPECTED RESULT
The tab name is updated. Color is unchanged.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: Kubuntu Linux 20.10
(available in About System)
KDE Plasma Version: 5.19.5
KDE Frameworks Version: 5.74.0
Qt Version: 5.14.2

ADDITIONAL INFORMATION
I'm using the Breeze Dark theme that came with Kubuntu. The pre-selected color might be different if a different theme is used.

Comment 1 J 2021-03-12 14:26:02 UTC

Thank you for sending a bug report. I am part of the Bugsquad and not a maintainer.

I have followed your steps provided.

Reproduced steps:

CTRL + SHIFT + T or File > New Tab

Right clicked the newly created tab and selected "Configure or Rename Tab"

Set tab title format to "Test"

Leaft the default tab colour(Mine was White too).

Pressed ok

Results:

The observed results are the same as you have explained, when editing a newly created tab the default tab colour set is white(I too am using the Breeze Theme). I have tested this with a random custom theme and the results are still the same.

To test if the profile itself can have the default tab colour changed I went to the tab settings in the current profile via Konsole > Settings > Edit Current profile > "Tabs" on the left side pane > selected "Colour From Theme". It seems the "Colour From Theme" option cannot be applied as default tab colour, my apply button was greyed out and cannot be selected. Any other colour can be selected and applied even a after restart of the Konsole the colour that was originally set in the settings is still remembered and applied.

If you then go into settings and then change the default tab colour to "Colour From Theme" you can now hit the apply button, but even after a restart of the Konsole the default tab colour still defaults to white.

I was able to reproduce the issue on my system:

SOFTWARE/OS VERSIONS:
Operating System: Fedora 33
KDE Plasma Version: 5.20.5
KDE Frameworks Version: 5.79.0
Qt Version: 5.15.2
Kernel Version: 5.10.17-200.fc33.x86_64
OS Type: 64-bit

Comment 2 Kurt Hindenburg 2021-03-25 03:15:39 UTC

This should be fixed in 20.12 and later.  please reopen if you can still reproduce.