Bug 434163

Summary:	kateindenttest_testCppstyle and kateindenttest_testCstyle fail since > 5.79.0
Product:	[Frameworks and Libraries] frameworks-ktexteditor	Reporter:	Heiko Becker <heiko.becker>
Component:	general	Assignee:	KWrite Developers <kwrite-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	christoph
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/frameworks/ktexteditor/commit/9508a46bb2281dfc037d1b0c9531e15e0db85e86	Version Fixed/Implemented In:
Sentry Crash Report:

Description Heiko Becker 2021-03-08 21:43:05 UTC

kateindenttest_testCppstyle and kateindenttest_testCstyle fail here with pre-release 5.80.0 tarballs available to packagers.
They also fail on build.kde.org (e.g. https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.15/242/). Judging from the first failing job on Jenkins it seems https://invent.kde.org/frameworks/ktexteditor/-/commit/57aa67e6f485651e7f5d50b10d2acf93811168e8 is the cause. And if I revert that commit and add it on top of 5.80.0 the tests pass again.

STEPS TO REPRODUCE
1. cmake .. && make && make test


SOFTWARE/OS VERSIONS
KDE Plasma Version: 5.21.2
KDE Frameworks Version: 5.80.0
Qt Version: 5.15.2



Output from kateindenttest "testCppstyle:

23: Test command: /var/tmp/paludis/build/kde-frameworks-ktexteditor-5.80.0/work/build/bin/kateindenttest "testCppstyle"
23: Test timeout computed to be: 10000000
23: ********* Start testing of IndentTest *********
23: Config: Using QtTest library 5.15.2, Qt 5.15.2 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 11.0.1 20210228 (experimental)), exherbo unknown
23: QWARN  : IndentTest::initTestCase() kf.sonnet.core: No language dictionaries for the language: "C" trying to load en_US as default
23: PASS   : IndentTest::initTestCase()
23: PASS   : IndentTest::testCppstyle(comment13)
23: PASS   : IndentTest::testCppstyle(normal6)
23: PASS   : IndentTest::testCppstyle(doxygen5)
23: PASS   : IndentTest::testCppstyle(shortcut9)
23: PASS   : IndentTest::testCppstyle(colon4)
23: PASS   : IndentTest::testCppstyle(preprocessor5)
23: PASS   : IndentTest::testCppstyle(semicolon5)
23: PASS   : IndentTest::testCppstyle(comment9)
23: PASS   : IndentTest::testCppstyle(semicolon1)
23: PASS   : IndentTest::testCppstyle(normal4)
23: PASS   : IndentTest::testCppstyle(normal23)
23: PASS   : IndentTest::testCppstyle(comment12)
23: PASS   : IndentTest::testCppstyle(shortcut4)
23: PASS   : IndentTest::testCppstyle(for1)
23: PASS   : IndentTest::testCppstyle(normal2)
23: --- /var/tmp/paludis/build/kde-frameworks-ktexteditor-5.80.0/work/ktexteditor-5.80.0/autotests/input/indent/cppstyle/autobrackets1/expected	2021-03-06 17:30:47.000000000 +0100
23: +++ /var/tmp/paludis/build/kde-frameworks-ktexteditor-5.80.0/work/ktexteditor-5.80.0/autotests/input/indent/cppstyle/autobrackets1/actual	2021-03-08 22:22:08.821909753 +0100
23: @@ -2,6 +2,6 @@
23:  {
23:      void foo()
23:      {
23: -        
23: +
23:      }
23:  };
23: 
23: FAIL!  : IndentTest::testCppstyle(autobrackets1) Compared values are not the same
23:    Actual   (diff.exitCode()): 1
23:    Expected (EXIT_SUCCESS)   : 0
23:    Loc: [/var/tmp/paludis/build/kde-frameworks-ktexteditor-5.80.0/work/ktexteditor-5.80.0/autotests/src/script_test_base.cpp(153)]
23: PASS   : IndentTest::testCppstyle(string1)
23: PASS   : IndentTest::testCppstyle(normal7)
23: PASS   : IndentTest::testCppstyle(equal5)
23: PASS   : IndentTest::testCppstyle(comma2)
23: PASS   : IndentTest::testCppstyle(doxygen6)
23: PASS   : IndentTest::testCppstyle(lab4)
23: PASS   : IndentTest::testCppstyle(exclamation3)
23: PASS   : IndentTest::testCppstyle(doxygen4)
23: PASS   : IndentTest::testCppstyle(colon2)
23: PASS   : IndentTest::testCppstyle(preprocessor3)
23: PASS   : IndentTest::testCppstyle(normal3)
23: PASS   : IndentTest::testCppstyle(ternary_op3)
23: PASS   : IndentTest::testCppstyle(comment20)
23: PASS   : IndentTest::testCppstyle(normal11)
23: --- /var/tmp/paludis/build/kde-frameworks-ktexteditor-5.80.0/work/ktexteditor-5.80.0/autotests/input/indent/cppstyle/parens1/expected	2021-03-06 17:30:47.000000000 +0100
23: +++ /var/tmp/paludis/build/kde-frameworks-ktexteditor-5.80.0/work/ktexteditor-5.80.0/autotests/input/indent/cppstyle/parens1/actual	2021-03-08 22:22:08.866910239 +0100
23: @@ -1,2 +1,2 @@
23:      foo(
23: -      );
23: +        );
23: 
23: XFAIL  : IndentTest::testCppstyle(parens1) dunno why it failed in test! in manual mode everything works fine...
23:    Loc: [/var/tmp/paludis/build/kde-frameworks-ktexteditor-5.80.0/work/ktexteditor-5.80.0/autotests/src/script_test_base.cpp(153)]
23: PASS   : IndentTest::testCppstyle(parens1)
23: --- /var/tmp/paludis/build/kde-frameworks-ktexteditor-5.80.0/work/ktexteditor-5.80.0/autotests/input/indent/cppstyle/comma5/expected	2021-03-06 17:30:47.000000000 +0100
23: +++ /var/tmp/paludis/build/kde-frameworks-ktexteditor-5.80.0/work/ktexteditor-5.80.0/autotests/input/indent/cppstyle/comma5/actual	2021-03-08 22:22:08.872910304 +0100
23: @@ -1,3 +1,3 @@
23:  some, ok
23: -some, ok   
23: +some, ok
23:  some, ok other
23: 
23: FAIL!  : IndentTest::testCppstyle(comma5) Compared values are not the same
23:    Actual   (diff.exitCode()): 1
23:    Expected (EXIT_SUCCESS)   : 0
23:    Loc: [/var/tmp/paludis/build/kde-frameworks-ktexteditor-5.80.0/work/ktexteditor-5.80.0/autotests/src/script_test_base.cpp(153)]
23: PASS   : IndentTest::testCppstyle(comma3)
23: PASS   : IndentTest::testCppstyle(shortcut6)
23: PASS   : IndentTest::testCppstyle(normal25)
23: PASS   : IndentTest::testCppstyle(normal1)
23: PASS   : IndentTest::testCppstyle(semicolon8)
23: QWARN  : IndentTest::testCppstyle(equal3) kf.texteditor: Text requested for invalid range [ (4, -2)  ->  (4, 1) ]
23: QWARN  : IndentTest::testCppstyle(equal3) kf.texteditor: Text requested for invalid range [ (5, -2)  ->  (5, 1) ]
23: QWARN  : IndentTest::testCppstyle(equal3) kf.texteditor: Text requested for invalid range [ (7, -2)  ->  (7, 1) ]
23: PASS   : IndentTest::testCppstyle(equal3)
23: PASS   : IndentTest::testCppstyle(dot2)
23: PASS   : IndentTest::testCppstyle(semicolon4)
23: PASS   : IndentTest::testCppstyle(plist2)
23: PASS   : IndentTest::testCppstyle(quote3)
23: PASS   : IndentTest::testCppstyle(comment16)
23: PASS   : IndentTest::testCppstyle(string6)
23: PASS   : IndentTest::testCppstyle(preprocessor1)
23: PASS   : IndentTest::testCppstyle(normal19)
23: PASS   : IndentTest::testCppstyle(doxygen8)
23: PASS   : IndentTest::testCppstyle(normal21)
23: PASS   : IndentTest::testCppstyle(colon6)
23: PASS   : IndentTest::testCppstyle(preprocessor2)
23: PASS   : IndentTest::testCppstyle(normal20)
23: PASS   : IndentTest::testCppstyle(colon7)
23: PASS   : IndentTest::testCppstyle(ternary_op1)
23: PASS   : IndentTest::testCppstyle(normal9)
23: PASS   : IndentTest::testCppstyle(comment8)
23: PASS   : IndentTest::testCppstyle(shortcut7)
23: PASS   : IndentTest::testCppstyle(shortcut1)
23: PASS   : IndentTest::testCppstyle(shortcut12)
23: PASS   : IndentTest::testCppstyle(lab1)
23: PASS   : IndentTest::testCppstyle(lab8)
23: PASS   : IndentTest::testCppstyle(normal17)
23: PASS   : IndentTest::testCppstyle(lab9)
23: PASS   : IndentTest::testCppstyle(colon9)
23: PASS   : IndentTest::testCppstyle(shortcut3)
23: PASS   : IndentTest::testCppstyle(comment4)
23: PASS   : IndentTest::testCppstyle(comma1)
23: PASS   : IndentTest::testCppstyle(comment2)
23: PASS   : IndentTest::testCppstyle(shortcut8)
23: PASS   : IndentTest::testCppstyle(shortcut2)
23: PASS   : IndentTest::testCppstyle(shortcut10)
23: PASS   : IndentTest::testCppstyle(colon1)
23: PASS   : IndentTest::testCppstyle(equal2)
23: PASS   : IndentTest::testCppstyle(pipe1)
23: PASS   : IndentTest::testCppstyle(preprocessor4)
23: PASS   : IndentTest::testCppstyle(space2)
23: PASS   : IndentTest::testCppstyle(normal12)
23: PASS   : IndentTest::testCppstyle(equal6)
23: PASS   : IndentTest::testCppstyle(colon3)
23: --- /var/tmp/paludis/build/kde-frameworks-ktexteditor-5.80.0/work/ktexteditor-5.80.0/autotests/input/indent/cppstyle/comment15/expected	2021-03-06 17:30:47.000000000 +0100
23: +++ /var/tmp/paludis/build/kde-frameworks-ktexteditor-5.80.0/work/ktexteditor-5.80.0/autotests/input/indent/cppstyle/comment15/actual	2021-03-08 22:22:08.997911655 +0100
23: @@ -1,5 +1,5 @@
23:      /*
23:       *
23:       */
23: -    
23: +
23:      // ok class some;
23: 
23: FAIL!  : IndentTest::testCppstyle(comment15) Compared values are not the same
23:    Actual   (diff.exitCode()): 1
23:    Expected (EXIT_SUCCESS)   : 0
23:    Loc: [/var/tmp/paludis/build/kde-frameworks-ktexteditor-5.80.0/work/ktexteditor-5.80.0/autotests/src/script_test_base.cpp(153)]
23: PASS   : IndentTest::testCppstyle(normal16)
23: PASS   : IndentTest::testCppstyle(exclamation2)
23: PASS   : IndentTest::testCppstyle(normal10)
23: PASS   : IndentTest::testCppstyle(semicolon3)
23: PASS   : IndentTest::testCppstyle(dot1)
23: --- /var/tmp/paludis/build/kde-frameworks-ktexteditor-5.80.0/work/ktexteditor-5.80.0/autotests/input/indent/cppstyle/semicolon7/expected	2021-03-06 17:30:47.000000000 +0100
23: +++ /var/tmp/paludis/build/kde-frameworks-ktexteditor-5.80.0/work/ktexteditor-5.80.0/autotests/input/indent/cppstyle/semicolon7/actual	2021-03-08 22:22:09.014911839 +0100
23: @@ -1 +1 @@
23: -some;ok      
23: +some;ok
23: 
23: FAIL!  : IndentTest::testCppstyle(semicolon7) Compared values are not the same
23:    Actual   (diff.exitCode()): 1
23:    Expected (EXIT_SUCCESS)   : 0
23:    Loc: [/var/tmp/paludis/build/kde-frameworks-ktexteditor-5.80.0/work/ktexteditor-5.80.0/autotests/src/script_test_base.cpp(153)]
23: --- /var/tmp/paludis/build/kde-frameworks-ktexteditor-5.80.0/work/ktexteditor-5.80.0/autotests/input/indent/cppstyle/autobrackets2/expected	2021-03-06 17:30:47.000000000 +0100
23: +++ /var/tmp/paludis/build/kde-frameworks-ktexteditor-5.80.0/work/ktexteditor-5.80.0/autotests/input/indent/cppstyle/autobrackets2/actual	2021-03-08 22:22:09.020911904 +0100
23: @@ -4,7 +4,7 @@
23:      {
23:          if (true)
23:          {
23: -            
23: +
23:          }
23:      }
23:  };
23: 
23: FAIL!  : IndentTest::testCppstyle(autobrackets2) Compared values are not the same
23:    Actual   (diff.exitCode()): 1
23:    Expected (EXIT_SUCCESS)   : 0
23:    Loc: [/var/tmp/paludis/build/kde-frameworks-ktexteditor-5.80.0/work/ktexteditor-5.80.0/autotests/src/script_test_base.cpp(153)]
23: PASS   : IndentTest::testCppstyle(string3)
23: PASS   : IndentTest::testCppstyle(exclamation1)
23: PASS   : IndentTest::testCppstyle(shortcut11)
23: PASS   : IndentTest::testCppstyle(normal5)
23: PASS   : IndentTest::testCppstyle(quote1)
23: PASS   : IndentTest::testCppstyle(quote4)
23: PASS   : IndentTest::testCppstyle(comment6)
23: PASS   : IndentTest::testCppstyle(string2)
23: PASS   : IndentTest::testCppstyle(comment19)
23: PASS   : IndentTest::testCppstyle(colon8)
23: PASS   : IndentTest::testCppstyle(space1)
23: PASS   : IndentTest::testCppstyle(comment18)
23: PASS   : IndentTest::testCppstyle(normal18)
23: PASS   : IndentTest::testCppstyle(doxygen9)
23: PASS   : IndentTest::testCppstyle(semicolon2)
23: PASS   : IndentTest::testCppstyle(lab2)
23: PASS   : IndentTest::testCppstyle(exclamation5)
23: PASS   : IndentTest::testCppstyle(comment14)
23: PASS   : IndentTest::testCppstyle(for2)
23: PASS   : IndentTest::testCppstyle(comment11)
23: PASS   : IndentTest::testCppstyle(comment17)
23: PASS   : IndentTest::testCppstyle(do1)
23: PASS   : IndentTest::testCppstyle(exclamation4)
23: PASS   : IndentTest::testCppstyle(preprocessor6)
23: PASS   : IndentTest::testCppstyle(string5)
23: PASS   : IndentTest::testCppstyle(normal15)
23: PASS   : IndentTest::testCppstyle(comment5)
23: PASS   : IndentTest::testCppstyle(doxygen1)
23: PASS   : IndentTest::testCppstyle(equal4)
23: PASS   : IndentTest::testCppstyle(autobrackets3)
23: PASS   : IndentTest::testCppstyle(comment7)
23: PASS   : IndentTest::testCppstyle(comma4)
23: PASS   : IndentTest::testCppstyle(quote2)
23: PASS   : IndentTest::testCppstyle(lab10)
23: PASS   : IndentTest::testCppstyle(doxygen2)
23: PASS   : IndentTest::testCppstyle(semicolon6)
23: PASS   : IndentTest::testCppstyle(comment1)
23: PASS   : IndentTest::testCppstyle(colon5)
23: PASS   : IndentTest::testCppstyle(normal8)
23: PASS   : IndentTest::testCppstyle(normal22)
23: PASS   : IndentTest::testCppstyle(lab6)
23: PASS   : IndentTest::testCppstyle(ternary_op2)
23: --- /var/tmp/paludis/build/kde-frameworks-ktexteditor-5.80.0/work/ktexteditor-5.80.0/autotests/input/indent/cppstyle/normal13/expected	2021-03-06 17:30:47.000000000 +0100
23: +++ /var/tmp/paludis/build/kde-frameworks-ktexteditor-5.80.0/work/ktexteditor-5.80.0/autotests/input/indent/cppstyle/normal13/actual	2021-03-08 22:22:09.112912899 +0100
23: @@ -2,5 +2,5 @@
23:      {
23:          void foo();
23:  
23: -    
23: +
23:      okpublic:
23: 
23: FAIL!  : IndentTest::testCppstyle(normal13) Compared values are not the same
23:    Actual   (diff.exitCode()): 1
23:    Expected (EXIT_SUCCESS)   : 0
23:    Loc: [/var/tmp/paludis/build/kde-frameworks-ktexteditor-5.80.0/work/ktexteditor-5.80.0/autotests/src/script_test_base.cpp(153)]
23: PASS   : IndentTest::testCppstyle(lab3)
23: --- /var/tmp/paludis/build/kde-frameworks-ktexteditor-5.80.0/work/ktexteditor-5.80.0/autotests/input/indent/cppstyle/string4/expected	2021-03-06 17:30:47.000000000 +0100
23: +++ /var/tmp/paludis/build/kde-frameworks-ktexteditor-5.80.0/work/ktexteditor-5.80.0/autotests/input/indent/cppstyle/string4/actual	2021-03-08 22:22:09.119912974 +0100
23: @@ -1,3 +1,3 @@
23: -auto some = 
23: +auto some =
23:      ok"some really long text here we wanted to split"
23:      ok;
23: 
23: FAIL!  : IndentTest::testCppstyle(string4) Compared values are not the same
23:    Actual   (diff.exitCode()): 1
23:    Expected (EXIT_SUCCESS)   : 0
23:    Loc: [/var/tmp/paludis/build/kde-frameworks-ktexteditor-5.80.0/work/ktexteditor-5.80.0/autotests/src/script_test_base.cpp(153)]
23: PASS   : IndentTest::testCppstyle(lab5)
23: PASS   : IndentTest::testCppstyle(normal24)
23: PASS   : IndentTest::testCppstyle(lab7)
23: PASS   : IndentTest::testCppstyle(comment10)
23: PASS   : IndentTest::testCppstyle(plist1)
23: PASS   : IndentTest::testCppstyle(doxygen7)
23: PASS   : IndentTest::testCppstyle(normal14)
23: PASS   : IndentTest::testCppstyle(equal1)
23: --- /var/tmp/paludis/build/kde-frameworks-ktexteditor-5.80.0/work/ktexteditor-5.80.0/autotests/input/indent/cppstyle/comment3/expected	2021-03-06 17:30:47.000000000 +0100
23: +++ /var/tmp/paludis/build/kde-frameworks-ktexteditor-5.80.0/work/ktexteditor-5.80.0/autotests/input/indent/cppstyle/comment3/actual	2021-03-08 22:22:09.139913191 +0100
23: @@ -1,2 +1,2 @@
23: -    
23: +
23:      ok// comment
23: 
23: FAIL!  : IndentTest::testCppstyle(comment3) Compared values are not the same
23:    Actual   (diff.exitCode()): 1
23:    Expected (EXIT_SUCCESS)   : 0
23:    Loc: [/var/tmp/paludis/build/kde-frameworks-ktexteditor-5.80.0/work/ktexteditor-5.80.0/autotests/src/script_test_base.cpp(153)]
23: PASS   : IndentTest::testCppstyle(dot3)
23: PASS   : IndentTest::testCppstyle(colon10)
23: PASS   : IndentTest::testCppstyle(plist3)
23: PASS   : IndentTest::testCppstyle(doxygen3)
23: PASS   : IndentTest::cleanupTestCase()
23: Totals: 138 passed, 8 failed, 0 skipped, 0 blacklisted, 509ms
23: ********* Finished testing of IndentTest *********
23/66 Test #23: kateindenttest_testCppstyle .............***Failed    0.54 sec

Comment 1 Christoph Cullmann 2021-03-08 21:55:40 UTC

Yeah, the tests fail.
But I to overwrite this now in the matching .kateconfig file, seems not to help :/

Comment 2 Christoph Cullmann 2021-03-08 21:59:04 UTC

Ok, I am just to dumb to write my own mode lines :=)

Comment 3 Christoph Cullmann 2021-03-08 22:00:09 UTC

Git commit 9508a46bb2281dfc037d1b0c9531e15e0db85e86 by Christoph Cullmann.
Committed on 08/03/2021 at 21:59.
Pushed by cullmann into branch 'master'.

fix unit tests => don't remove trailing spaces

M  +1    -1    autotests/input/indent/R/.kateconfig
M  +1    -1    autotests/input/indent/cmake/.kateconfig
M  +1    -1    autotests/input/indent/cppstyle/.kateconfig
M  +1    -1    autotests/input/indent/cstyle/.kateconfig
M  +1    -1    autotests/input/indent/haskell/.kateconfig
M  +1    -1    autotests/input/indent/python/.kateconfig
M  +1    -1    autotests/input/indent/replicode/.kateconfig

https://invent.kde.org/frameworks/ktexteditor/commit/9508a46bb2281dfc037d1b0c9531e15e0db85e86

Comment 4 Heiko Becker 2021-03-08 22:06:55 UTC

Confirmed fixed. That was quick, thanks!

Comment 5 Christoph Cullmann 2021-03-08 22:09:39 UTC

Thanks for the report.

I tend to ignore some faults, as in Qt 5.14 still often the JS engine is at fault, but yeah, the 5.15 tests should have never failed, my bad :((