| Summary: | Highlight changed Settings forgets some changed parts in plasma settings | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | medin <med.medin.2014> |
| Component: | general | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | benjamin.port, cyril.rossi, nate, plasma-bugs-null |
| Priority: | NOR | ||
| Version First Reported In: | 5.21.1 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: | Highlight changed Settings forgets some changed parts in plasma settings | ||
Please can you confirm your Plasma / KDE Frameworks version and platform. For each KCM you mention, here is what I have for Plasma 5.21.80/KF5.80 * Desktop effects is on the way, see https://invent.kde.org/plasma/kwin/-/merge_requests/737 * Touch screen shows the indicator in the sidebar, currently not in the screen and will require a lot of work to make it. * Login screen (SDDM) that one shows strange behavior with default * Keyboard does not support the feature * Multimedia does not support the feature * Energy Saving does not support the feature * Default Applications should work as expected * File Associations has no default state * Accessibility should work as expected Please can you post here your Plasma / KDE Frameworks version and platform. (In reply to Cyril Rossi from comment #2) > Please can you post here your Plasma / KDE Frameworks version and platform. Sorry for late reply, I use : Operating System: Manjaro Linux KDE Plasma Version: 5.21.2 KDE Frameworks Version: 5.79.0 Qt Version: 5.15.2 Kernel Version: 5.4.101-1-MANJARO OS Type: 64-bit Please open new bugs to individually track the remaining issues with the Touch Screen and Login Screen KCMs (if they still apply) as it seems like everything else here is either fixed now or behaves as expected, for KCMs with no logical default state. Git commit dd5db629ed99a97ed4753731d742afe752d1423b by Cyril Rossi. Committed on 01/10/2021 at 16:00. Pushed by crossi into branch 'master'. KCM Keyboard port to KConfigXT, highlight non default settings Main goal is to port the KCM to KConfigXT and properly handle default/reset state, and eventually ease the port to QtQuick. Like other KCMs dealing with shortcuts, they are now automatically applied when selected. For technical reason, highlight for layouts and tree view keyboard options won't be implemented. M +11 -3 kcms/keyboard/CMakeLists.txt M +39 -24 kcms/keyboard/kcm_keyboard.cpp M +7 -2 kcms/keyboard/kcm_keyboard.h M +3 -3 kcms/keyboard/kcm_keyboard.ui M +171 -84 kcms/keyboard/kcm_keyboard_widget.cpp M +25 -12 kcms/keyboard/kcm_keyboard_widget.h M +26 -10 kcms/keyboard/kcm_view_models.cpp M +5 -7 kcms/keyboard/kcm_view_models.h A +14 -0 kcms/keyboard/kcmmain.cpp [License: GPL(v2.0+)] M +81 -42 kcms/keyboard/kcmmisc.cpp M +20 -7 kcms/keyboard/kcmmisc.h M +4 -4 kcms/keyboard/kcmmiscwidget.ui M +65 -83 kcms/keyboard/keyboard_config.cpp M +16 -16 kcms/keyboard/keyboard_config.h M +10 -9 kcms/keyboard/keyboard_daemon.cpp M +1 -1 kcms/keyboard/keyboard_daemon.h A +29 -0 kcms/keyboard/keyboardmiscsettings.kcfg A +6 -0 kcms/keyboard/keyboardmiscsettings.kcfgc A +36 -0 kcms/keyboard/keyboardsettings.kcfg A +5 -0 kcms/keyboard/keyboardsettings.kcfgc A +28 -0 kcms/keyboard/keyboardsettingsdata.cpp [License: GPL(v2.0+)] A +32 -0 kcms/keyboard/keyboardsettingsdata.h [License: GPL(v2.0+)] M +6 -6 kcms/keyboard/layout_memory.cpp M +5 -5 kcms/keyboard/layout_memory_persister.cpp M +5 -4 kcms/keyboard/tests/CMakeLists.txt M +5 -5 kcms/keyboard/tests/flags_test.cpp M +9 -8 kcms/keyboard/xkb_helper.cpp https://invent.kde.org/plasma/plasma-desktop/commit/dd5db629ed99a97ed4753731d742afe752d1423b |
Created attachment 136442 [details] Highlight changed Settings forgets some changed parts in plasma settings The following changed parts of Plasma settings are not marked by Highlight Changed Settings : - Desktop effects - Touch Screen - Login Screen - Keyboard - Multimedia - Energy Saving - Default Applications - File Associations - Accessibility It's like the default state to which it compares the current changes is not the default one. How does Highlight Changed Settings handles new installed modules into Plasma settings like Systemd, Task Scheduler, Color Corrections... ?