Bug 433941

Summary:	Fan Corners setting stays enabled despite disabling the brush option it falls under
Product:	[Applications] krita	Reporter:	tomtomtomreportingin
Component:	Brush engines	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	griffinvalley
Priority:	NOR
Version First Reported In:	4.4.3-beta1
Target Milestone:	---
Platform:	Appimage
OS:	Linux
Latest Commit:	https://invent.kde.org/graphics/krita/commit/45e8ba4103f99d0cbfd763ae954521ab68f98393	Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Fan Corners is still functionally enabled after disabling its corresponding brush option

Description tomtomtomreportingin 2021-03-04 08:40:21 UTC

SUMMARY
This is something that was driving me crazy when the softness brush mask didn't seem to be working properly, even when replicating another softness brush as close as possible.

I looked through every brush option despite them being disabled, trying to figure out the specific difference causing this.

It appears that if the user enables the Drawing Angle sensor and then enables the Fan Corners setting, the Fan Corners settings stays functionally enabled even after disabling the brush option that the Drawing Angle sensor falls under, for example rotation.

STEPS TO REPRODUCE
1. Select Basic-3_Flow brush.
2. Set Horizontal and Vertical Fade to 0.0 for easier observance.
3. Select Rotation option, enable pen settings, select and enable Drawing Angle sensor.
4. Enable Fan Corners, set to 5 degrees for easier observance.
5. Disable Rotation option.
6. Draw curved lines.

OBSERVED RESULT
Curved lines are fanned despite Rotation option being disabled.

EXPECTED RESULT
Fan Corners should be functionally disabled.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Debian sid
(available in About System)
KDE Plasma Version: 5.20.5
KDE Frameworks Version: 5.78.0
Qt Version: 5.12.9 (Appimage)

ADDITIONAL INFORMATION
Not a regression from what I can tell.

Comment 1 tomtomtomreportingin 2021-03-04 14:56:50 UTC

It seems that some default brushes such as Basic 5 Opacity, Marker Details, Shapes Square, and Pixel Art Fill are affected by this behavior. Whether David utilized this intentionally, I'm not sure, but perhaps this behavior is preferable in certain cases...

Comment 2 wolthera 2021-09-08 09:38:32 UTC

Can you include images? I am having a hard time reproducing this :(

Comment 3 tomtomtomreportingin 2021-09-08 15:13:01 UTC

Created attachment 141396 [details]
Fan Corners is still functionally enabled after disabling its corresponding brush option

See the attachment. I've tweaked the spacing, flow, fade, and fan corners value for better demonstration of the issue. Top stroke is how it should be after disabling Rotation, while bottom stroke is what actually happens.

Comment 4 Bug Janitor Service 2021-09-09 04:36:12 UTC

Thanks for your comment!

Automatically switching the status of this bug to REPORTED so that the KDE team
knows that the bug is ready to get confirmed.

In the future you may also do this yourself when providing needed information.

Comment 5 wolthera 2021-09-19 16:20:52 UTC

Git commit 25f835b18f8ee23321cab1002c07ea24e999d9f4 by Wolthera van Hövell tot Westerflier.
Committed on 19/09/2021 at 16:19.
Pushed by woltherav into branch 'krita/5.0'.

Disable "fan corners" when the rotation option is disbaled.

Turns out fan corners was applied separately, so it needs to be double
checked whether it's active.

M  +4    -0    plugins/paintops/libpaintop/kis_pressure_rotation_option.cpp

https://invent.kde.org/graphics/krita/commit/25f835b18f8ee23321cab1002c07ea24e999d9f4

Comment 6 wolthera 2021-09-19 16:21:23 UTC

Git commit 45e8ba4103f99d0cbfd763ae954521ab68f98393 by Wolthera van Hövell, on behalf of Wolthera van Hövell tot Westerflier.
Committed on 19/09/2021 at 16:21.
Pushed by woltherav into branch 'master'.

Disable "fan corners" when the rotation option is disbaled.

Turns out fan corners was applied separately, so it needs to be double
checked whether it's active.


(cherry picked from commit 25f835b18f8ee23321cab1002c07ea24e999d9f4)

M  +4    -0    plugins/paintops/libpaintop/kis_pressure_rotation_option.cpp

https://invent.kde.org/graphics/krita/commit/45e8ba4103f99d0cbfd763ae954521ab68f98393