Bug 433863

Summary: s390x: memcheck/tests/s390x/{cds,cs,csg} failures
Product: [Developer tools] valgrind Reporter: Mark Wielaard <mark>
Component: generalAssignee: Andreas Arnez <arnez>
Status: RESOLVED FIXED    
Severity: normal CC: arnez, jseward
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Remove memcheck test cases for cs, cds, and csg

Description Mark Wielaard 2021-03-02 14:11:44 UTC
After the fix for bug #429864 - s390x: C++ atomic test_and_set yields false-positive memcheck diagnostics, the memcheck/tests/s390x/{cds,cs,csg} started failing.

After the fix some issues (in these tests) can no longer be detected. It is unclear if that can be fixed. So maybe these tests simply need to be deleted.
Comment 1 Andreas Arnez 2021-04-28 15:46:04 UTC
(In reply to Mark Wielaard from comment #0)
> After the fix some issues (in these tests) can no longer be detected. It is
> unclear if that can be fixed. So maybe these tests simply need to be deleted.
Right.  I don't see an easy way to preserve the behavior that is verified by these tests without re-introducing false positives.  So I'll go ahead and remove them.
Comment 2 Andreas Arnez 2021-04-28 17:21:26 UTC
Created attachment 137982 [details]
Remove memcheck test cases for cs, cds, and csg

This is the removal patch.  Let me know if I'm missing something.
Comment 3 Andreas Arnez 2021-04-30 15:58:08 UTC
(In reply to Andreas Arnez from comment #2)
> Created attachment 137982 [details]
> Remove memcheck test cases for cs, cds, and csg
Any objections/comments?  Otherwise I'm planning to apply the patch early next week.
Comment 4 Julian Seward 2021-05-04 08:43:39 UTC
(In reply to Andreas Arnez from comment #3)
> (In reply to Andreas Arnez from comment #2)
> > Created attachment 137982 [details]
> > Remove memcheck test cases for cs, cds, and csg
> Any objections/comments?  Otherwise I'm planning to apply the patch early
> next week.

This seems reasonable to me.
Comment 5 Andreas Arnez 2021-05-04 10:30:48 UTC
(In reply to Julian Seward from comment #4)
> This seems reasonable to me.
Thanks!  Applied as d74a637206ef5532ccd2ccb2e31ee2762f184e60.