Bug 433815

Summary:	On mobile, the drawer header is broken in multiples kirigami apps
Product:	[Frameworks and Libraries] frameworks-kirigami	Reporter:	Carl Schwan <carl>
Component:	general	Assignee:	Marco Martin <notmart>
Status:	RESOLVED FIXED
Severity:	grave	CC:	carl, nate
Priority:	NOR
Version First Reported In:	Master
Target Milestone:	Not decided
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/frameworks/kirigami/commit/d7d70795f9ca72084236282211d0a89f75426261	Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Discover

Description Carl Schwan 2021-03-01 20:19:46 UTC

SUMMARY

The drawer header contentItem is too small compared to the header. This creates an ugly white "strip" and content not aligned with the rest.

STEPS TO REPRODUCE
1. QT_QUICK_CONTROLS_MOBILE=1 plasma-discover
2. open drawer

OBSERVED RESULT

See screenshot


EXPECTED RESULT

Header item occupying all the height

ADDITIONAL INFORMATION

I tried to look into it. Porting AbstractApplicationHeader to a Control instead of an Item with control like API fix it but creates many other bugs probably because some other pieces of code expect different behavior.

Comment 1 Carl Schwan 2021-03-01 20:20:20 UTC

Created attachment 136296 [details]
Discover

Comment 2 Marco Martin 2021-03-09 15:13:12 UTC

Git commit d7d70795f9ca72084236282211d0a89f75426261 by Marco Martin.
Committed on 09/03/2021 at 15:13.
Pushed by mart into branch 'master'.

the visible part should always at least be as tall as item

the contents of the header can be bigger than the control,
but never smaller

M  +1    -1    src/controls/templates/AbstractApplicationHeader.qml

https://invent.kde.org/frameworks/kirigami/commit/d7d70795f9ca72084236282211d0a89f75426261