Bug 433804

Summary:	zfs support in ksysguard / system monitor widgets?
Product:	[Applications] ksysguard	Reporter:	Jason Ormes <skryking>
Component:	ksysguardd	Assignee:	KSysGuard Developers <ksysguard-bugs>
Status:	REPORTED ---
Severity:	normal	CC:	alex.aune, christophe.lavie, eridanired123, hueponik, plasma-bugs, rr.underwood94
Priority:	NOR
Version:	5.21.1
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed In:
Attachments:	libmount example

Description Jason Ormes 2021-03-01 18:10:41 UTC

SUMMARY
Looking in /master/ksysguardd/Linux/diskstat.c it appears that zfs pools are excluded because they don't start with a "/" in /etc/mtab and they aren't specifically included in the updateDiskStat method.

STEPS TO REPRODUCE
1. create zfs pool and mount it
2. fire up ksysguard and try to find it in widgets / sensors


OBSERVED RESULT
The zfs partition isn't available in stats

EXPECTED RESULT
The zfs pools should be available

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: KDE Neon latest version


ADDITIONAL INFORMATION
I'm not sure if there are other places other than this file that zfs would have to be added to.

Comment 1 Robert Underwood 2021-03-30 17:58:20 UTC

I would recommend pulling in a libmount (part of util-linux) dependency for doing this.  Both ksysguardd and libmount are GPL-2 licensed.  util-linux and libmount are fairly ubiquitous.  Parsing the /etc/mtab file on linux can be tricky because of some unexpected allowed file names (like those containing '\r'), and it even reports which file systems are network file systems, pseudo-filesystems, swap, or special kernel filesystems by translating the f_type field that we don't currently do.

I'm attaching a short example of how this can be done.  If the dev's are OK with adding a libmount dependency, I can write up a patch for ksysguardd.  I'm a new to KDE, so I'll need some help with the process.

Comment 2 Robert Underwood 2021-03-30 17:59:46 UTC

Created attachment 137183 [details]
libmount example

Comment 3 Arjen Hiemstra 2022-01-25 12:31:00 UTC

*** Bug 449123 has been marked as a duplicate of this bug. ***