| Summary: | Get New Pages popup is too narrow by default | ||
|---|---|---|---|
| Product: | [Applications] plasma-systemmonitor | Reporter: | Felipe Kinoshita <kinofhek> |
| Component: | general | Assignee: | KSysGuard Developers <ksysguard-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ahiemstra, kde, nate, plasma-bugs |
| Priority: | NOR | Keywords: | usability |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-systemmonitor/commit/2c36107c8a6d1747d809e08df3bdcdf6a5691729 | Version Fixed In: | 5.21.3 |
| Attachments: | observed result | ||
Are we overriding the size here? The window seems to have a sensible enough default size of its own. No and it worked fine in the past https://invent.kde.org/plasma/plasma-systemmonitor/-/blob/master/src/main.qml#L208 A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-systemmonitor/-/merge_requests/99 Git commit 20426cca3fa124f30ae44ac6866dc687d5d73e71 by David Redondo. Committed on 04/03/2021 at 12:19. Pushed by davidre into branch 'master'. Fix initial size of page download dialog After reading the Qt Dialog code, I believe that by setting visible: true we were hitting setVisible to early when we did not have a contenItem and the dialog stays small even if we later set the contenItem. FIXED-IN:5.21.3 M +0 -4 src/main.qml https://invent.kde.org/plasma/plasma-systemmonitor/commit/20426cca3fa124f30ae44ac6866dc687d5d73e71 Git commit 2c36107c8a6d1747d809e08df3bdcdf6a5691729 by David Redondo. Committed on 04/03/2021 at 12:22. Pushed by davidre into branch 'Plasma/5.21'. Fix initial size of page download dialog After reading the Qt Dialog code, I believe that by setting visible: true we were hitting setVisible to early when we did not have a contenItem and the dialog stays small even if we later set the contenItem. FIXED-IN:5.21.3 (cherry picked from commit 20426cca3fa124f30ae44ac6866dc687d5d73e71) M +0 -4 src/main.qml https://invent.kde.org/plasma/plasma-systemmonitor/commit/2c36107c8a6d1747d809e08df3bdcdf6a5691729 |
Created attachment 136242 [details] observed result STEPS TO REPRODUCE 1. open the System Monitor > Menu > 'Get New Pages...' popup OBSERVED RESULT Popup is too narrow by default EXPECTED RESULT Popup shouldn't be too narrow SOFTWARE/OS VERSIONS Linux/KDE Plasma: openSUSE Tumbleweed (available in About System) KDE Plasma Version: 5.21.0 KDE Frameworks Version: 5.79.0 Qt Version: 5.15.2