Bug 433693

Summary: minor issue, omitting argument to -application causes incorrect error message
Product: [Frameworks and Libraries] Snoretoast Reporter: Sean McLemon <sean.mclemon>
Component: generalAssignee: Hannah von Reth <vonreth>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: 0.5.99   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Patch to correct this issue.

Description Sean McLemon 2021-02-27 11:37:23 UTC
Created attachment 136217 [details]
Patch to correct this issue.

SUMMARY

When you invoke snoretoast with "-application" but without any arguments the error message incorrectly refers to it as "-pipeName" and "-applicatzion"

STEPS TO REPRODUCE
1. invoke snoretoast with the -application switch but do not specify an application

OBSERVED RESULT
Error displayed calls the switch "-pipeName" and "-applicatzion": 

PS> snoretoast -application
Missing argument to -pipeName.
Supply argument as -applicatzion "C:\foo.exe"

EXPECTED RESULT

PS> snoretoast -application
Missing argument to -application.
Supply argument as -application "C:\foo.exe"

SOFTWARE/OS VERSIONS
Windows: all
macOS: n/a
Linux/KDE Plasma: n/a
(available in About System)
KDE Plasma Version: n/a
KDE Frameworks Version: n/a
Qt Version: n/a

ADDITIONAL INFORMATION

The fix is really simple, the problematic lines can be seen at https://invent.kde.org/libraries/snoretoast/-/blob/cbd1fa1b2eab79baf2d69c3285bc3ee019f9c833/src/main.cpp#L200-202 but I've attached a patch to correct it anyway.
Comment 1 Hannah von Reth 2021-03-01 10:33:43 UTC
Fixed in https://invent.kde.org/libraries/snoretoast/-/commit/31947076311ab13efb0758288cc20dfbfbf2c93d thx for the patch.