| Summary: | FreeBSD support, part 4 | ||
|---|---|---|---|
| Product: | [Developer tools] valgrind | Reporter: | Paul Floyd <pjfloyd> |
| Component: | drd | Assignee: | Bart Van Assche <bart.vanassche+kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | emaste, mark |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | FreeBSD | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: |
DRD code changes
DRD code changes |
||
Created attachment 141835 [details]
DRD code changes
I am glad the dlclose(dlopen) trickery is contained to #if defined(VGO_freebsd). It looks scary. The rest seems fine (and it compiles as is on fedora x86_64). I do wonder if the LIBC_FUNC define cannot be done as a PTH_FUNCS define variant. The dlclose(dlopen()) fix took a lot of effort to hunt down (and a bit form the FreeBSD toolchain folks). Code committed as commit 7074904a377a52c76cbc8feaf618fa31b8a663b7 |
Created attachment 136076 [details] DRD code changes A fairly small patch. The semaphore sem functions functions are in libc rather than in libthr, so I used a different macro for the. Most of the other changes are just adding "define d(VGO_freebsd)" There's also a workaround related loading shared libs and the fact that libc contains stubs whilst the real implementations are in libthr