| Summary: | System Settings crashed after trying to clear history from the privacy tab in activities. | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | jas3212000 |
| Component: | kcm_activities | Assignee: | Ivan Čukić <ivan.cukic> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | kde, lv215bd5, matt.fagnani, nate, nxiss7, plasma-bugs, rdieter, samiksome92 |
| Priority: | VHI | Keywords: | drkonqi, regression |
| Version: | 5.21.0 | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-desktop/commit/6273f0ba5926d775a8db057e7ea1e0d2c8f17f06 | Version Fixed In: | 5.21.2 |
| Sentry Crash Report: | |||
| Attachments: |
bug happening
New crash information added by DrKonqi |
||
|
Description
jas3212000
2021-02-18 21:37:36 UTC
Created attachment 135910 [details]
bug happening
Same happens to me: Operating System: KDE neon 5.21 KDE Plasma Version: 5.21.0 KDE Frameworks Version: 5.79.0 Qt Version: 5.15.2 I attached a video. *** Bug 433261 has been marked as a duplicate of this bug. *** Apparently we're using DBus wrong: #7 0x00007fb86ed392c0 in _dbus_warn_check_failed (format=0x7fb86ed46c50 "arguments to %s() were incorrect, assertion \"%s\" failed in file %s line %d.\nThis is normally a bug in some application using the D-Bus library.\n") at dbus-internals.c:281 #8 0x00007fb86ed298f2 in dbus_message_new_method_call (destination=0x55b699ba32e8 "org.kde.ActivityManager", path=0x55b693c069f8 "/ActivityManager/Resources / Scoring", iface=iface@entry=0x7fb86400d008 "org.freedesktop.DBus.Introspectable", method=method@entry=0x55b693cdc538 "Introspect") at dbus-message.c:1366 *** Bug 433192 has been marked as a duplicate of this bug. *** /ActivityManager/Resources / Scoring" And there we can see exaclty what we're doing wrong. Will fix. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/360 Created attachment 135951 [details]
New crash information added by DrKonqi
systemsettings5 (5.21.0) using Qt 5.15.2
- What I was doing when the application crashed:
Trying to clear history via Settings->Workspace Behaviour->Activities->Privacy->Clear History crashes System Settings every time.
-- Backtrace (Reduced):
#4 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
#5 0x00007fead1f23859 in __GI_abort () at abort.c:79
[...]
#7 0x00007fead001d570 in _dbus_warn_check_failed () from /lib/x86_64-linux-gnu/libdbus-1.so.3
#8 0x00007fead000cde2 in dbus_message_new_method_call () from /lib/x86_64-linux-gnu/libdbus-1.so.3
#9 0x00007fead1417047 in q_dbus_message_new_method_call (method=0x55d6283beaa8 "Introspect", interface=0x7feac800d868 "org.freedesktop.DBus.Introspectable", path=0x7feac800d2c8 "/ActivityManager/Resources / Scoring", bus_name=<optimized out>) at qdbus_symbols_p.h:381
Git commit 8e45efdc9dd410bdca4ddd795b5e403c14d5dc56 by David Edmundson. Committed on 24/02/2021 at 09:35. Pushed by davidedmundson into branch 'master'. [kcms/activities] Fixup DBus path usage In a code cleanup the path name got corrupted. The use of macros obfuscates what can be done with a simple string. This code takes it back to what's helpful. Whilst we're at it, ResourceScoring was using QDBusInterface and string based method names. This means syncrononous calls, and also can get easily broken in future porting, so this is switched to using the generated interface. M +8 -0 kcms/activities/CMakeLists.txt M +1 -1 kcms/activities/ExtraActivitiesInterface.cpp M +5 -3 kcms/activities/PrivacyTab.cpp M +5 -14 kcms/activities/common/dbus/common.h A +41 -0 kcms/activities/common/dbus/org.kde.ActivityManager.ResourceScoring.xml M +1 -1 kcms/activities/imports/dialog.cpp https://invent.kde.org/plasma/plasma-desktop/commit/8e45efdc9dd410bdca4ddd795b5e403c14d5dc56 Git commit 6273f0ba5926d775a8db057e7ea1e0d2c8f17f06 by David Edmundson. Committed on 24/02/2021 at 09:36. Pushed by davidedmundson into branch 'Plasma/5.21'. [kcms/activities] Fixup DBus path usage In a code cleanup the path name got corrupted. The use of macros obfuscates what can be done with a simple string. This code takes it back to what's helpful. Whilst we're at it, ResourceScoring was using QDBusInterface and string based method names. This means syncrononous calls, and also can get easily broken in future porting, so this is switched to using the generated interface. (cherry picked from commit 8e45efdc9dd410bdca4ddd795b5e403c14d5dc56) M +8 -0 kcms/activities/CMakeLists.txt M +1 -1 kcms/activities/ExtraActivitiesInterface.cpp M +5 -3 kcms/activities/PrivacyTab.cpp M +5 -14 kcms/activities/common/dbus/common.h A +41 -0 kcms/activities/common/dbus/org.kde.ActivityManager.ResourceScoring.xml M +1 -1 kcms/activities/imports/dialog.cpp https://invent.kde.org/plasma/plasma-desktop/commit/6273f0ba5926d775a8db057e7ea1e0d2c8f17f06 *** Bug 433721 has been marked as a duplicate of this bug. *** |