Bug 433173

I also noticed that KRunner does not close after the command has been executed.

Works for me FWIW.

(In reply to Nate Graham from comment #2)
> Works for me FWIW.

I just tried on my desktop and it has the same behaviour. I tried removing all KRunner-related config files I could find on my notebook, where I first noticed the issue, but it seems like it didn't make any difference: the issue is still there. This does not seem to be related to configuration issues, at least from my (admittedly superficial) investigation into the problem.

Same here with Manjaro and KDE Plasma 5.21.1

Operating System: Manjaro Linux
KDE Plasma Version: 5.21.1
KDE Frameworks Version: 5.79.0
Qt Version: 5.15.2

Same here with:

Operating System: Manjaro Linux
KDE Plasma Version: 5.21.2
KDE Frameworks Version: 5.79.0
Qt Version: 5.15.2

And I should add, that I can't search the history anymore.

Could you please share your ~/.config/krunnerrc and ~/.local/share/krunnerstaterc file? (Make sure it contains no sensitive information).

And is this still reproducible if you uncheck the "History: Activity Aware" checkbox in the KRunner settings?

Created attachment 136660 [details]
krunnerrc

Created attachment 136661 [details]
krunnerstaterc

Here are the files you requested! It seems to me like everything is fine there.

Created attachment 136677 [details]
The after deletion generated krunnerrc

Created attachment 136678 [details]
Original krunnerrc

Created attachment 136679 [details]
New krunnerstaterc generated after deleting the old one

I have uploaded two versions of krunnerrc. The one ending in .old is the original one. The one ending in .new is the one created after renaming the original one and saving changes to the settings. Just restarting krunner did not create a new krunnerrc. Krunnerstaterc is the file created after deleting the old one. Only the LaunchCounts entry differs from the old one, where it has a lot more entries.

History does not work with the new setting files neither.

BTW,I happened to open a very old, archived krunnerrc and there is a history entry under [General] which I can't find in the new one.

@Knut, thanks a lot for the files, they look good to me too. When I replaced my local config "original" files with yours and then restarted KRunner
everything works as expected.

May I ask if you have tried out deactivating the one setting I asked in https://bugs.kde.org/show_bug.cgi?id=433173#c7 and then checked if the history works after that? From what I can tell from the files you have entries in your history :)

Maybe do a `kquitapp5 krunner` to make sure the process is properly restarted?

@Alexander: As I am in the same situation like @Knut, I did what you had suggested :)

Deactivated setting, restarted krunner
=> same behavior

Reactivated setting, restarted krunner
=> same behavior

Not only the history is not recorded, also KRunner does not close after the command has been executed, like @Riccardo said before.

HTH

(In reply to Alexander Lohnau from comment #14)
> May I ask if you have tried out deactivating the one setting I asked in
> https://bugs.kde.org/show_bug.cgi?id=433173#c7 and then checked if the
> history works after that? From what I can tell from the files you have
> entries in your history :)
Yes, I switched it on and off various time and furthermore even erased the history.

>Not only the history is not recorded, also KRunner does not close after the command has been executed, like @Riccardo said before.

Could you please say which command? 

And is it that still the case if you kill krunner, start it from the command line and then re-run the command? Like:
>killall -9 krunner;krunner

Started krunner from konsole and got following output:
$ krunner
qt.svg: <input>:406:376: Could not add child element to parent element because the types are incorrect.
qt.svg: <input>:407:130: Could not add child element to parent element because the types are incorrect.
qt.svg: <input>:408:130: Could not add child element to parent element because the types are incorrect.
qt.svg: <input>:408:393: Could not add child element to parent element because the types are incorrect.
qt.svg: <input>:409:130: Could not add child element to parent element because the types are incorrect.
qt.svg: <input>:410:129: Could not add child element to parent element because the types are incorrect.
qt.svg: <input>:411:129: Could not add child element to parent element because the types are incorrect.
qt.svg: <input>:412:129: Could not add child element to parent element because the types are incorrect.
qt.svg: <input>:413:129: Could not add child element to parent element because the types are incorrect.
qt.svg: <input>:413:379: Could not add child element to parent element because the types are incorrect.
qt.svg: <input>:413:631: Could not add child element to parent element because the types are incorrect.
file:///usr/share/plasma/look-and-feel/org.kde.breath2.desktop/contents/runcommand/RunCommand.qml:39:5: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }

Searching and invoking a program (pavucontrol) first time:
kf.sonnet.core: Sonnet: Unable to load plugin "/usr/lib/qt/plugins/kf5/sonnet/sonnet_hspell.so" Error: "Cannot load library /usr/lib/qt/plugins/kf5/sonnet/sonnet_hspell.so: (libhspell.so.0: cannot open shared object file: No such file or directory)"
kf.sonnet.core: Sonnet: Unable to load plugin "/usr/lib/qt/plugins/kf5/sonnet/sonnet_voikko.so" Error: "Cannot load library /usr/lib/qt/plugins/kf5/sonnet/sonnet_voikko.so: (libvoikko.so.1: cannot open shared object file: No such file or directory)"
Connecting to deprecated signal QDBusConnectionInterface::serviceOwnerChanged(QString,QString,QString)file:///usr/share/plasma/look-and-feel/org.kde.breath2.desktop/contents/runcommand/RunCommand.qml:86: TypeError: Cannot read property 'length' of undefined
file:///usr/share/plasma/look-and-feel/org.kde.breath2.desktop/contents/runcommand/RunCommand.qml:86: TypeError: Cannot read property 'length' of undefined
file:///usr/share/plasma/look-and-feel/org.kde.breath2.desktop/contents/runcommand/RunCommand.qml:86: TypeError: Cannot read property 'length' of undefined
file:///usr/share/plasma/look-and-feel/org.kde.breath2.desktop/contents/runcommand/RunCommand.qml:86: TypeError: Cannot read property 'length' of undefined
file:///usr/share/plasma/look-and-feel/org.kde.breath2.desktop/contents/runcommand/RunCommand.qml:181: TypeError: Property 'addToHistory' of object View(0x7fff3f0acad0) is not a function

Searching and invoking a program (pavucontrol) later:
file:///usr/share/plasma/look-and-feel/org.kde.breath2.desktop/contents/runcommand/RunCommand.qml:86: TypeError: Cannot read property 'length' of undefined
file:///usr/share/plasma/look-and-feel/org.kde.breath2.desktop/contents/runcommand/RunCommand.qml:86: TypeError: Cannot read property 'length' of undefined
file:///usr/share/plasma/look-and-feel/org.kde.breath2.desktop/contents/runcommand/RunCommand.qml:86: TypeError: Cannot read property 'length' of undefined
file:///usr/share/plasma/look-and-feel/org.kde.breath2.desktop/contents/runcommand/RunCommand.qml:86: TypeError: Cannot read property 'length' of undefined
file:///usr/share/plasma/look-and-feel/org.kde.breath2.desktop/contents/runcommand/RunCommand.qml:181: TypeError: Property 'addToHistory' of object View(0x7fff3f0acad0) is not a function

For each keystroke there is a line with property 'length'. The one with 'addToHistory' only appears when program is actually invoked.


Pressing the history button first time:
file:///usr/share/plasma/look-and-feel/org.kde.breath2.desktop/contents/runcommand/RunCommand.qml:207: TypeError: Cannot call method 'slice' of undefined

Pressing the history button later:
file:///usr/share/plasma/look-and-feel/org.kde.breath2.desktop/contents/runcommand/RunCommand.qml:207: TypeError: Cannot read property 'slice' of undefined

Hope this will help.

There we have it!

Do you have a custom theme or sth. like that? In KRunner new API was added and a property was added in QML to expose this. But it seems like that is not found.

Could you please provide the contend of /usr/share/plasma/look-and-feel/org.kde.breath2.desktop/contents/runcommand/RunCommand.qml and /home/user/kde/usr/lib/x86_64-linux-gnu/qml/org/kde/milou/ResultsView.qml

Also the version info provided from
>apt show milou
would be useful.

(In reply to Alexander Lohnau from comment #19)
> Do you have a custom theme or sth. like that? In KRunner new API was added
> and a property was added in QML to expose this. But it seems like that is
> not found.
Not really. I use as global design Breath2 which is Manjaro standard theme. Application style is Breeze, Plasma style Breath2 Dark, window decoration Oxygen, icon pack Breeze Dark, mouse pointer Breeze. And the color scheme is a slightly changed Krita darker. I have changed one or two colors. 


> Could you please provide the contend of
> /usr/share/plasma/look-and-feel/org.kde.breath2.desktop/contents/runcommand/
> RunCommand.qml and
> /home/user/kde/usr/lib/x86_64-linux-gnu/qml/org/kde/milou/ResultsView.qml
Uploaded the files. Since I could not find the second one at the location you put here I uploaded /usr/lib/qt/qml/org/kde/milou/ResultsView.qml
 
> Also the version info provided from
> >apt show milou
> would be useful.
If you mean the version of the search application, it is 5.21.2-1. BTW, I use Manjaro an Arch based distro, that has no apt.

Created attachment 136814 [details]
ResultsView.qml

Created attachment 136815 [details]
RunCommand.qml

I seems like the Manjaro folks have their own RunCommand.qml file which uses stuff from the underlying View class which has been removed.

Honestly I was not aware of such usage, also this means that whatever improvements/bugfixes we do to this file will not come into play on manjaro by default.

I will look into if we can make the old QML file work with the new API.

Thank you for your awesome help while debugging this so far :-)

Created attachment 136816 [details]
RunCommand.qml

(In reply to Alexander Lohnau from comment #19)
> There we have it!
> 
> Do you have a custom theme or sth. like that? In KRunner new API was added
> and a property was added in QML to expose this. But it seems like that is
> not found.
> 
> Could you please provide the contend of
> /usr/share/plasma/look-and-feel/org.kde.breath2.desktop/contents/runcommand/
> RunCommand.qml and
> /home/user/kde/usr/lib/x86_64-linux-gnu/qml/org/kde/milou/ResultsView.qml
> 
> Also the version info provided from
> >apt show milou
> would be useful.

I am using a custom theme on KDE Neon and this is the output when opening KRunner from the terminal:
riccardo@Sleipnir ~ $ killall -9 krunner && krunner
qt.svg: <input>:377:374: Could not add child element to parent element because the types are incorrect.
qt.svg: <input>:378:126: Could not add child element to parent element because the types are incorrect.
qt.svg: <input>:379:126: Could not add child element to parent element because the types are incorrect.
qt.svg: <input>:379:385: Could not add child element to parent element because the types are incorrect.
qt.svg: <input>:380:125: Could not add child element to parent element because the types are incorrect.
qt.svg: <input>:381:124: Could not add child element to parent element because the types are incorrect.
qt.svg: <input>:382:125: Could not add child element to parent element because the types are incorrect.
qt.svg: <input>:383:125: Could not add child element to parent element because the types are incorrect.
qt.svg: <input>:384:125: Could not add child element to parent element because the types are incorrect.
qt.svg: <input>:384:371: Could not add child element to parent element because the types are incorrect.
qt.svg: <input>:384:619: Could not add child element to parent element because the types are incorrect.
file:///home/riccardo/.local/share/plasma/look-and-feel/Adagio/contents/runcommand/RunCommand.qml:39:5: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
file:///home/riccardo/.local/share/plasma/look-and-feel/Adagio/contents/runcommand/RunCommand.qml:228: TypeError: Cannot call method 'slice' of undefined

So it looks like the last two lines are where the problem is. I uploaded the file in question.
Switching to another look & feel theme restores functionality (I chose Breeze Twilight, but I imagine any default theme would work just fine).
While Knut is on Manjaro, I am on Neon.

Glad that I could help.

Well, I do not know much about Plasma themes, but on my installation not only Breath2, the Manjaro theme, but also Breeze comes with its own RunCommand.qml. And these are the only two that exist on my system.

$ locate RunCommand.qml
/usr/share/plasma/look-and-feel/org.kde.breath2.desktop/contents/runcommand/RunCommand.qml
/usr/share/plasma/look-and-feel/org.kde.breeze.desktop/contents/runcommand/RunCommand.qml

I came up with some compatibility logic, thanks to Harald Sitter for helping me with the QML bits.

Will make two MRs later today.

A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/723

Switched, as Ricardo suggested, the theme and history is back :-)

Unfortunately an LibreOffice document that I usually edit is not there anymore. Moreover, I can't open it through krunner anymore unless I enter the full path to the document. Should I file a new bug for this?

Yeah, you can check if the document is present in the normal application launcher and file a bug with that information. That seems to be the "Desktop Search" runner, not sure how that is related.

(In reply to Alexander Lohnau from comment #29)
> That seems to be the "Desktop Search" runner, not sure how that is related.
Filed a new bug (https://bugs.kde.org/show_bug.cgi?id=434589), since it even happens using baloosearch on command line.

(In reply to Knut Hildebrandt from comment #28)
> Unfortunately an LibreOffice document that I usually edit is not there
> anymore. Moreover, I can't open it through krunner anymore unless I enter
> the full path to the document. Should I file a new bug for this?

Just to let know, this seems to be solved with last nights update to:
KDE Plasma Version: 5.21.3
KDE Frameworks Version: 5.80.0

Now all files/documents appear in the correct category.

Git commit bdc1a08c001c8cb83a2f5e863325260bb832c61c by Alexander Lohnau.
Committed on 23/03/2021 at 08:02.
Pushed by alex into branch 'master'.

krunner: Restore history related property and methods for compatibility with third party themes

Test Plan:
Use install old RunCommand.qml files provided by bug reporters and
verify that adding/viewing/completing and deleting from history works.

https://bugs.kde.org/attachment.cgi?id=136815
https://bugs.kde.org/attachment.cgi?id=136816

M  +1    -0    krunner/CMakeLists.txt
M  +13   -0    krunner/view.cpp
M  +18   -0    krunner/view.h

https://invent.kde.org/plasma/plasma-workspace/commit/bdc1a08c001c8cb83a2f5e863325260bb832c61c

Git commit 6961c82ac847e623d8926dae3cec492c13a6aafe by Alexander Lohnau.
Committed on 18/03/2021 at 11:27.
Pushed by alex into branch 'master'.

Set RunnerManager runnerWindow variable if it is available
Needed for compatibility logic in https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/723

M  +5    -0    lib/qml/ResultsView.qml

https://invent.kde.org/plasma/milou/commit/6961c82ac847e623d8926dae3cec492c13a6aafe

Git commit 113480f605b29e3becf1278e94ccfc19014e3804 by Alexander Lohnau.
Committed on 23/03/2021 at 16:23.
Pushed by alex into branch 'Plasma/5.21'.

Set RunnerManager runnerWindow variable if it is available
Needed for compatibility logic in https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/723

M  +5    -0    lib/qml/ResultsView.qml

https://invent.kde.org/plasma/milou/commit/113480f605b29e3becf1278e94ccfc19014e3804

Git commit dc57d322e585d977ec6b193bd6399f2d060690b9 by Alexander Lohnau.
Committed on 23/03/2021 at 16:24.
Pushed by alex into branch 'Plasma/5.21'.

krunner: Restore history related property and methods for compatibility with third party themes

Test Plan:
Use install old RunCommand.qml files provided by bug reporters and
verify that adding/viewing/completing and deleting from history works.

https://bugs.kde.org/attachment.cgi?id=136815
https://bugs.kde.org/attachment.cgi?id=136816

M  +1    -0    krunner/CMakeLists.txt
M  +13   -0    krunner/view.cpp
M  +18   -0    krunner/view.h

https://invent.kde.org/plasma/plasma-workspace/commit/dc57d322e585d977ec6b193bd6399f2d060690b9

(In reply to Riccardo Robecchi from comment #24)
> Created attachment 136816 [details]
> RunCommand.qml
> 
> (In reply to Alexander Lohnau from comment #19)
> > There we have it!
> > 
> > Do you have a custom theme or sth. like that? In KRunner new API was added
> > and a property was added in QML to expose this. But it seems like that is
> > not found.
> > 
> > Could you please provide the contend of
> > /usr/share/plasma/look-and-feel/org.kde.breath2.desktop/contents/runcommand/
> > RunCommand.qml and
> > /home/user/kde/usr/lib/x86_64-linux-gnu/qml/org/kde/milou/ResultsView.qml
> > 
> > Also the version info provided from
> > >apt show milou
> > would be useful.
> 
> I am using a custom theme on KDE Neon and this is the output when opening
> KRunner from the terminal:
> riccardo@Sleipnir ~ $ killall -9 krunner && krunner
> qt.svg: <input>:377:374: Could not add child element to parent element
> because the types are incorrect.
> qt.svg: <input>:378:126: Could not add child element to parent element
> because the types are incorrect.
> qt.svg: <input>:379:126: Could not add child element to parent element
> because the types are incorrect.
> qt.svg: <input>:379:385: Could not add child element to parent element
> because the types are incorrect.
> qt.svg: <input>:380:125: Could not add child element to parent element
> because the types are incorrect.
> qt.svg: <input>:381:124: Could not add child element to parent element
> because the types are incorrect.
> qt.svg: <input>:382:125: Could not add child element to parent element
> because the types are incorrect.
> qt.svg: <input>:383:125: Could not add child element to parent element
> because the types are incorrect.
> qt.svg: <input>:384:125: Could not add child element to parent element
> because the types are incorrect.
> qt.svg: <input>:384:371: Could not add child element to parent element
> because the types are incorrect.
> qt.svg: <input>:384:619: Could not add child element to parent element
> because the types are incorrect.
> file:///home/riccardo/.local/share/plasma/look-and-feel/Adagio/contents/
> runcommand/RunCommand.qml:39:5: QML Connections: Implicitly defined onFoo
> properties in Connections are deprecated. Use this syntax instead: function
> onFoo(<arguments>) { ... }
> file:///home/riccardo/.local/share/plasma/look-and-feel/Adagio/contents/
> runcommand/RunCommand.qml:228: TypeError: Cannot call method 'slice' of
> undefined
> 
> So it looks like the last two lines are where the problem is. I uploaded the
> file in question.
> Switching to another look & feel theme restores functionality (I chose
> Breeze Twilight, but I imagine any default theme would work just fine).
> While Knut is on Manjaro, I am on Neon.

I upgraded toady a few packages on Ubuntu hirsuite and the issue about krunner + `qt.svg: <input>:409:130: Could not add child element to parent element because the types are incorrect.` appeared. 

➜  ~ cat /var/log/dpkg.log | grep "\ install\ "
....
2021-06-12 11:38:51 install libcurl3-gnutls:i386 <none> 7.74.0-1ubuntu2
2021-06-12 11:39:15 install libtbb2:i386 <none> 2020.3-1
2021-06-12 18:15:27 install dyalog-unicode-180:amd64 <none> 18.0.39712
2021-06-12 18:29:34 install qtbase5-dev:amd64 <none> 5.15.2+dfsg-5
2021-06-12 18:29:44 install libqt5gui5:amd64 5.14.2+dfsg-6 5.15.2+dfsg-5
2021-06-12 18:29:44 install libqt5opengl5:amd64 <none> 5.15.2+dfsg-5
2021-06-12 18:29:45 install libqt5opengl5-dev:amd64 <none> 5.15.2+dfsg-5
2021-06-12 18:29:45 install virtualbox-qt:amd64 6.1.16-dfsg-6~ubuntu1.20.10.1 6.1.18-dfsg-5

I observed it another machine too, but not on this one. It seems that some of the packages I installed today introduce the issue. 

Riccardo, did you manage to workaround it?

Here everything is fine. I recently upgraded to 21.04.1 and running Manjaro which comes with it's own theme.

(In reply to Kakadu.hafanana from comment #36)
> (In reply to Riccardo Robecchi from comment #24)
> > Created attachment 136816 [details]
> > RunCommand.qml
> > 
> > (In reply to Alexander Lohnau from comment #19)
> > > There we have it!
> > > 
> > > Do you have a custom theme or sth. like that? In KRunner new API was added
> > > and a property was added in QML to expose this. But it seems like that is
> > > not found.
> > > 
> > > Could you please provide the contend of
> > > /usr/share/plasma/look-and-feel/org.kde.breath2.desktop/contents/runcommand/
> > > RunCommand.qml and
> > > /home/user/kde/usr/lib/x86_64-linux-gnu/qml/org/kde/milou/ResultsView.qml
> > > 
> > > Also the version info provided from
> > > >apt show milou
> > > would be useful.
> > 
> > I am using a custom theme on KDE Neon and this is the output when opening
> > KRunner from the terminal:
> > riccardo@Sleipnir ~ $ killall -9 krunner && krunner
> > qt.svg: <input>:377:374: Could not add child element to parent element
> > because the types are incorrect.
> > qt.svg: <input>:378:126: Could not add child element to parent element
> > because the types are incorrect.
> > qt.svg: <input>:379:126: Could not add child element to parent element
> > because the types are incorrect.
> > qt.svg: <input>:379:385: Could not add child element to parent element
> > because the types are incorrect.
> > qt.svg: <input>:380:125: Could not add child element to parent element
> > because the types are incorrect.
> > qt.svg: <input>:381:124: Could not add child element to parent element
> > because the types are incorrect.
> > qt.svg: <input>:382:125: Could not add child element to parent element
> > because the types are incorrect.
> > qt.svg: <input>:383:125: Could not add child element to parent element
> > because the types are incorrect.
> > qt.svg: <input>:384:125: Could not add child element to parent element
> > because the types are incorrect.
> > qt.svg: <input>:384:371: Could not add child element to parent element
> > because the types are incorrect.
> > qt.svg: <input>:384:619: Could not add child element to parent element
> > because the types are incorrect.
> > file:///home/riccardo/.local/share/plasma/look-and-feel/Adagio/contents/
> > runcommand/RunCommand.qml:39:5: QML Connections: Implicitly defined onFoo
> > properties in Connections are deprecated. Use this syntax instead: function
> > onFoo(<arguments>) { ... }
> > file:///home/riccardo/.local/share/plasma/look-and-feel/Adagio/contents/
> > runcommand/RunCommand.qml:228: TypeError: Cannot call method 'slice' of
> > undefined
> > 
> > So it looks like the last two lines are where the problem is. I uploaded the
> > file in question.
> > Switching to another look & feel theme restores functionality (I chose
> > Breeze Twilight, but I imagine any default theme would work just fine).
> > While Knut is on Manjaro, I am on Neon.
> 
> I upgraded toady a few packages on Ubuntu hirsuite and the issue about
> krunner + `qt.svg: <input>:409:130: Could not add child element to parent
> element because the types are incorrect.` appeared. 
> 
> ➜  ~ cat /var/log/dpkg.log | grep "\ install\ "
> ....
> 2021-06-12 11:38:51 install libcurl3-gnutls:i386 <none> 7.74.0-1ubuntu2
> 2021-06-12 11:39:15 install libtbb2:i386 <none> 2020.3-1
> 2021-06-12 18:15:27 install dyalog-unicode-180:amd64 <none> 18.0.39712
> 2021-06-12 18:29:34 install qtbase5-dev:amd64 <none> 5.15.2+dfsg-5
> 2021-06-12 18:29:44 install libqt5gui5:amd64 5.14.2+dfsg-6 5.15.2+dfsg-5
> 2021-06-12 18:29:44 install libqt5opengl5:amd64 <none> 5.15.2+dfsg-5
> 2021-06-12 18:29:45 install libqt5opengl5-dev:amd64 <none> 5.15.2+dfsg-5
> 2021-06-12 18:29:45 install virtualbox-qt:amd64
> 6.1.16-dfsg-6~ubuntu1.20.10.1 6.1.18-dfsg-5
> 
> I observed it another machine too, but not on this one. It seems that some
> of the packages I installed today introduce the issue. 
> 
> Riccardo, did you manage to workaround it?

Yes, I switched to another theme. I haven't tried going back to the previous one, actually, I will give it a try and let you know if it's fixed. In the meantime, I suggest that you switch to another theme and then try switching back to the one you are using now, on another computer of mine that worked.

(In reply to Riccardo Robecchi from comment #38)

> 
> Yes, I switched to another theme. I haven't tried going back to the previous
> one, actually, I will give it a try and let you know if it's fixed. In the
> meantime, I suggest that you switch to another theme and then try switching
> back to the one you are using now, on another computer of mine that worked.

I tried to do this but it doesn't help

I found a solution for my issue there: 
https://bugs.launchpad.net/ubuntu/+source/qtbase-opensource-src-gles/+bug/1920130