Summary: | Baloo looses filename after rename | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-baloo | Reporter: | GreggB <sequalsoft> |
Component: | Engine | Assignee: | Stefan Brüns <stefan.bruens> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kde, nate, pmargeti34, tagwerk19 |
Priority: | NOR | ||
Version: | 5.78.0 | ||
Target Milestone: | --- | ||
Platform: | Manjaro | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/frameworks/baloo/commit/f6a7845b8f3cd3188053ba58f9fe7053558aec86 | Version Fixed In: | 5.81 |
Sentry Crash Report: | |||
Attachments: | console log of test |
Description
GreggB
2021-02-17 20:55:29 UTC
See the same behaviour. Can add that before the file is moved, balooshow gives: balooshow -x zwzwzw.txt 4535846241893377 64513 1056084 zwzwzw.txt [/home/test/Documents/zwzwzw.txt] Mtime: 1613600991 2021-02-17T23:29:51 Ctime: 1613600991 2021-02-17T23:29:51 Internal Info Terms: Mapplication Mx Mzerosize File Name Terms: Ftxt Fzwzwzw XAttr Terms: whereas after: balooshow -x zwzwz.txt 4535846241893377 64513 1056084 zwzwz.txt [/home/test/Documents/zwzwz.txt] Mtime: 1613600991 2021-02-17T23:29:51 Ctime: 1613600991 2021-02-17T23:29:51 Internal Info Terms: Mapplication Mx Mzerosize File Name Terms: XAttr Terms: That is, without the "File Name Terms". It seems not to matter if the file is empty or a text file. Baloo does pick up the details if the file is touched touch zwzwz.txt balooshow -x zwzwz.txt 4535846241893377 64513 1056084 zwzwz.txt [/home/test/Documents/zwzwz.txt] Mtime: 1613601583 2021-02-17T23:39:43 Ctime: 1613601583 2021-02-17T23:39:43 Internal Info Terms: Mapplication Mx Mzerosize File Name Terms: Ftxt Fzwzwz XAttr Terms: SYSTEM INFORMATION Neon Testing Plasma : 5.21.0 Frameworks : 5.79.0 Qt : 5.15.2 Looked at some older systems... Fedora 32 (baloo 5.73) I did not see baloo "losing" the File Name Terms on a rename; if I mv'd a file balooshow would show the new File Name Terms "immediately" (or most likely faster than it would have taken baloo_file_extractor to read and change the details) So the "empty" File Name Terms issue has arrived since then... I can, with substantial contortions, generate multiple entries with the same filename (Baloo 5.80.0) Check what directories baloo are indexing. Need a directory, "Test", that you can initially index, then disable indexing and finally index again. Maybe not a realistic scenario but at least it's something to test. In "Test", create or download a test file, call it file1.txt, copy it to file2.txt, file3.txt, file4.txt, file5.txt .... Check that baloo has indexed it, look with balooshow -x file1.txt balooshow -x file2.txt etc... etc and also baloosearch txt Drop "Test" from the indexed directories, do a "balooctl check" (but not a "balooctl purge"). Move a file or two: mv file4.txt file3.txt Baloosearch won't see any of the changes baloosearch txt /home/test/file4.txt /home/test/file3.txt /home/test/file1.txt /home/test/file2.txt /home/test/file5.txt Reenable indexing of "Test" and run "balooctl check" again baloosearch txt now shows: /home/test/file3.txt /home/test/file3.txt /home/test/file1.txt /home/test/file2.txt /home/test/file5.txt SOFTWARE/OS VERSIONS Neon Testing Baloo : 5.80.0 Plasma : 5.21.2 Frameworks : 5.80.0 Qt: 5.15.2 Oh dear... The above was pasted into the wrong report Makes more sense appended to Bug 429006 This is a duplicate bug. I wrote a fix in https://bugs.kde.org/show_bug.cgi?id=392793. *** This bug has been marked as a duplicate of bug 392793 *** Git commit f6a7845b8f3cd3188053ba58f9fe7053558aec86 by Stefan Brüns. Committed on 27/03/2021 at 12:37. Pushed by bruns into branch 'master'. [MetadataMover] Update filename terms when moving/renaming file After the removal of BasicIndexingJob::index() (bd1041ea2826e295 "Make renames a DB only operation") the filename terms where left empty. M +0 -3 autotests/unit/file/metadatamovertest.cpp M +6 -0 src/file/metadatamover.cpp https://invent.kde.org/frameworks/baloo/commit/f6a7845b8f3cd3188053ba58f9fe7053558aec86 Git commit 24da759545088060b863fef13496a5b22a5534d6 by Stefan Brüns. Committed on 27/03/2021 at 12:37. Pushed by bruns into branch 'master'. [MetadataMover] Extend renaming test cases Verify document terms are unchanged, and filename terms are properly set. M +68 -18 autotests/unit/file/metadatamovertest.cpp https://invent.kde.org/frameworks/baloo/commit/24da759545088060b863fef13496a5b22a5534d6 Nice! Does this mean Bug 392793 is also fixed, or is that a separate issue? Checking on Neon Unstable, Baloo 5.81.0 Test as per Comment 1 now works for me. Thanks! *** Bug 392793 has been marked as a duplicate of this bug. *** |