| Summary: | Header for QWidgets KCMs not aligned with sidebar header | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | David C <biltamirzo> |
| Component: | sidebarview | Assignee: | Marco Martin <notmart> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kde, kde, med.medin.2014, nate, nicolas.fella, notmart, plasma-bugs |
| Priority: | NOR | Keywords: | regression |
| Version: | 5.21.2 | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/systemsettings/48fecba07b5ec361a5c2be8d8892adcb93901e0e | Version Fixed In: | 5.22 |
| Sentry Crash Report: | |||
| Attachments: |
QWidgets KCM renders header differently from systemsettings
header problem System Settings header alignment problem |
||
Confirmed for QWidgets KCMs. I'll see if I can fix it. The issue here appears to be somewhere in the QML header injected in kcmutils:src/kcmoduleqml.cpp. I tried making the calculation the same as the one in System Settings' sidebar headers but that didn't work. :( Could you help, Marco? Git commit a31fa7a45b3010683bf8cb31c138d3e5ef14a0e1 by Ismael Asensio. Committed on 20/02/2021 at 07:41. Pushed by iasensio into branch 'master'. [sidebarmode] Fix header height for QWidget KCMs Take the height value from the sidebar header and set it to the custom QWidget header, so both headers look aligned. There was a helpful method already set-up for this, but not used before. FIXED-IN: 5.21.1 M +3 -0 sidebar/SidebarMode.cpp M +2 -1 sidebar/package/contents/ui/main.qml https://invent.kde.org/plasma/systemsettings/commit/a31fa7a45b3010683bf8cb31c138d3e5ef14a0e1 Git commit 48fecba07b5ec361a5c2be8d8892adcb93901e0e by Ismael Asensio. Committed on 20/02/2021 at 09:55. Pushed by iasensio into branch 'Plasma/5.21'. [sidebarmode] Fix header height for QWidget KCMs Take the height value from the sidebar header and set it to the custom QWidget header, so both headers look aligned. There was a helpful method already set-up for this, but not used before. FIXED-IN: 5.21.1 Cherry-picked from: a31fa7a45b3010683bf8cb31c138d3e5ef14a0e1 M +3 -0 sidebar/SidebarMode.cpp M +2 -1 sidebar/package/contents/ui/main.qml https://invent.kde.org/plasma/systemsettings/commit/48fecba07b5ec361a5c2be8d8892adcb93901e0e Fixed for Breeze with those commits. Other styles may require other fixes, which will be dome separately. This seems to be back again, or maybe it was never truly fixed in the first place. :( Alignment seems to be perfect for me when using 11pt Noto Sans, but with the default 10pt, they are mis-aligned. *** Bug 433825 has been marked as a duplicate of this bug. *** Raising priority as this is simultaneously really small and insignificant but also incredibly stupid looking and impossible to miss once you notice it. what are dpi and scale factor here can't reproduce neither with 10 nor 11 pt with noto 200% scale Cannot reproduce with trying all sorts of settings including a clean VM. I didn't check the maths behind both sizes, but if this is hittable except in extreme situations it's definitely not VHI at that point. Please can you also confirm it's still valid. (In reply to David Edmundson from comment #11) > Cannot reproduce with trying all sorts of settings including a clean VM. > > I didn't check the maths behind both sizes, but if this is hittable except > in extreme situations it's definitely not VHI at that point. > > Please can you also confirm it's still valid. I confirm the problem is still present but not in all places, the mysterious thing is that the same header appears incorrectly vertically aligned but after some navigation it appears correctly, and the cause is when I jump from a page with 3 columns to another with 2 columns. The same happens with Info center interface. See attached video for more info. Created attachment 137337 [details]
header problem
With current git master, I cna no longer reproduce the issue with Noto Sans 10, which I was able to reproduce before. Perhaps Ismael's patches fixed it. Medin, any chance you can try with git master/unstable packages? (In reply to Nate Graham from comment #14) > With current git master, I cna no longer reproduce the issue with Noto Sans > 10, which I was able to reproduce before. Perhaps Ismael's patches fixed it. > > Medin, any chance you can try with git master/unstable packages? With 5.21.4 the problem is still present. I can't install git version (it wants to pull all others git plasma packages). I can confirm this is fixed in current master The problem is still present on 5.22.3 Cannot reproduce with 10pt or 11pt Noto Sans with 200% scaling and the font DPI unchanged from its default value. Please mention which font, scaling, and DPI settings you're using. (In reply to Nate Graham from comment #18) > Cannot reproduce with 10pt or 11pt Noto Sans with 200% scaling and the font > DPI unchanged from its default value. > > Please mention which font, scaling, and DPI settings you're using. I use Noto Sans font and size 9pt, scaling 100% and dpi 96, see attached video for more info. NB : The same happens with size of 10pt. Created attachment 140266 [details]
System Settings header alignment problem
Thank you for the video. I still cannot reproduce the issue with your exact settings shown in the video and those exact KCMs (except for the >anjaro-specific ones, because I'm not using Manjaro). I must therefore assume that either this issue has already been fixed in the git master version of Kirigami or System Settings, or there is a Manjaro-specific problem. Dunno if there's anything more I can do here, sorry. Weird, I had two accounts created from 5.20 and both suffered from this problem, but now after creating new one it seems the problem is fixed, I think some config files are not applied to old accounts after upgrading to 5.22. In fact this trick solved many problems for me in the past (especially with baloo) but the cost to reconfigure all plasma desktop, widgets and apps is really fastidious. |
Created attachment 135733 [details] QWidgets KCM renders header differently from systemsettings The header or title area for QWidgets KCMs are not flush with the systemsettings header. The difference is just a few pixels but is noticeable. I'm using Breeze and Noto Sans 10, but the same bug was reproducible for users of Kvantum themes and other application styles. STEPS TO REPRODUCE 1. Be on Plasma 5.21.0 and Frameworks 5.79.0 2. Open systemsettings 3. View a module like Energy Saving or KDE Connect See attachment for the graphical error caused by this bug. SOFTWARE/OS VERSIONS KDE Neon User KDE Plasma Version: 5.21.0 KDE Frameworks Version: 5.79.0 Qt Version: 5.15.2