Bug 433002

Summary:	"Software Sources" ToolButton lacks an icon, making it look like an un-clickable text label
Product:	[Applications] Discover	Reporter:	Dan Dascalescu <ddascalescu+kde>
Component:	discover	Assignee:	Dan Leinir Turthra Jensen <leinir>
Status:	RESOLVED FIXED
Severity:	normal	CC:	aleixpol, nate
Priority:	NOR	Keywords:	usability
Version:	5.18.5
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Screencast 5.24

Description Dan Dascalescu 2021-02-16 10:57:22 UTC

Created attachment 135715 [details]
Screencast

I was trying to remove a repo. The instructions at https://help.ubuntu.com/community/Repositories/Kubuntu are outdated, as there are no trash can icons. It took me quite a while to figure out that "Software Sources" was a button and not a label.

I use the Fusion app style, and the Kubuntu theme.

Comment 1 Nate Graham 2021-02-16 18:52:58 UTC

Not having an icon is a big part of the problem here. The lack of one may be our bug.

However it's also supposed to have an outline that appears on hover when you move the cursor over it. I didn't see that in your screen recording, but it could be a low FPS issue with the video file. If you don't see it either, that's a bug with the Fusion style.

In the past, these buttons were implemented as PushButtons to ensure clickability even when there was no icon, but it looks like they got changed to ToolButtons in the port to Kirigami.ActionToolbar, which implements its buttons always using the ToolButton style.

Comment 2 Dan Dascalescu 2021-02-16 22:31:46 UTC

Nope, don't see any outline on hover either. Thanks for confirming!

Comment 3 Aleix Pol 2021-02-19 15:45:22 UTC

I cannot reproduce.

Can you try running Discover with QT_QUICK_CONTROLS_STYLE=Material set?

Comment 4 Aleix Pol 2021-02-19 15:53:01 UTC

https://bugs.kde.org/show_bug.cgi?id=433256 this one could be related.

Comment 5 Aleix Pol 2022-01-20 13:19:31 UTC

Created attachment 145663 [details]
5.24

The icon is there now, I'm not sure which change fixed it.