Bug 432972

Summary:	Selection performance regression
Product:	[Applications] konsole	Reporter:	Martin Sandsmark <martin.sandsmark>
Component:	general	Assignee:	Konsole Developer <konsole-devel>
Status:	ASSIGNED ---
Severity:	normal	CC:	nate, tcanabrava
Priority:	NOR
Version:	master
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Martin Sandsmark 2021-02-15 14:48:13 UTC

Not sure when this changed, but felt that dragging a selection felt a bit laggy with the latest master.

Checked out an old arbitrary revision, and current master feels like a 10x performance degradation (or at least one order of a magnitude), very visible when e. g. starting a selection and dragging upwards into the backlog.

Probably bisectable, so I'll try to find some time to do it unless someone knows what is going on.

Comment 1 tcanabrava 2021-02-15 14:50:01 UTC

two things on my mind

1 - the new visual selection behavior *could* do this
2 - the reflow code could potentially have done this too.

Comment 2 Martin Sandsmark 2021-02-15 15:04:07 UTC

Seems like there were some minor slowdowns from other stuff (probably the stuff you mention), but the thing that made it unusable, at least when scrolling, is 6667d96ed9d6c95eab4ed13449d4b134005ffb4b (was a quick bisect)

Comment 3 Martin Sandsmark 2021-02-15 15:06:08 UTC

The commit message for that seems bogus as well, 6667d96ed9d6c95eab4ed13449d4b134005ffb4b^ works just fine in normal vim (don't have neovim, though, but then it sounds like a neovim bug).

Comment 4 Bug Janitor Service 2021-06-07 15:28:43 UTC

A possibly relevant merge request was started @ https://invent.kde.org/utilities/konsole/-/merge_requests/404