| Summary: | vg_regtest: test-specific environment variables not reset between tests | ||
|---|---|---|---|
| Product: | [Developer tools] valgrind | Reporter: | Aaron Merey <amerey> |
| Component: | general | Assignee: | Julian Seward <jseward> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | mark |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | All | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: | envvar_fix.diff | ||
Thanks for finding this. Your fix looks correct to me. Pushed as: commit 208f2d96069574e7a75cb3f8e53adb216e4795b9 Author: Mark Wielaard <mark@klomp.org> Date: Thu Feb 11 18:29:52 2021 +0100 vg_regtest: test-specific environment variables not reset between tests Test-specific environment variables set in .vgtest files are not reset between tests. This can result in tests running with environment variables intended for a previously run test. This can be easily fixed by clearing the @env and @envB arrays in tests/vg_regtest:read_vgtest_file() Original patch by Aaron Merey <amerey@redhat.com> https://bugs.kde.org/show_bug.cgi?id=432672 |
Created attachment 135526 [details] envvar_fix.diff Test-specific environment variables set in .vgtest files are not reset between tests. This can result in tests running with environment variables intended for a previously run test. This can be easily fixed by clearing the @env and @envB arrays in tests/vg_regtest:read_vgtest_file() (see attachment).