Bug 432664

Summary: Spamming contiguous selections causes lengthy or indefinite lockups
Product: [Applications] krita Reporter: tomtomtomreportingin
Component: Tools/SelectionAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: griffinvalley
Priority: NOR    
Version First Reported In: git master (please specify the git hash!)   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description tomtomtomreportingin 2021-02-08 21:12:36 UTC 
SUMMARY
Spamming continguous selections in Krita stable (currently 4.4.2 as of writing) especially with larger canvases causes longer lockups depending on how much it's spammed. In git master's case, tapping a contiguous selection just twice appears to cause an indefinite, uncancellable operation. Swap memory noted in the status bar memory indicator also appears to go up continuously while the selections are initialized.

STEPS TO REPRODUCE
1. Select a large canvas size like A5 600 DPI
2. Select the contiguous selection tool
3. Tap several times on the canvas

OBSERVED RESULT
Krita locks up for a fairly long time, or in git master, indefinitely.

EXPECTED RESULT
Non-lengthy lockups.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Debian sid
(available in About System)
KDE Plasma Version: 5.20.5
KDE Frameworks Version: 5.78.0
Qt Version: 5.12.9 (Appimage)
Comment 1 wolthera 2021-09-08 09:23:48 UTC 
Can you still reproduce this? I cannot, and tiar did multithread the contiguous selection tool...
Comment 2 tomtomtomreportingin 2021-09-08 15:04:03 UTC 
Not really, this could probably be considered resolved.