Bug 432650

Summary: macOS: digikam system menu not localizable
Product: [Applications] digikam Reporter: Hackintosh HD <hackintoshhd>
Component: Usability-i18nAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: minor CC: caulier.gilles, metzpinguin
Priority: NOR    
Version: 7.2.0   
Target Milestone: ---   
Platform: macOS (DMG)   
OS: macOS   
Latest Commit: Version Fixed In: 7.3.0
Sentry Crash Report:
Attachments: Screenshot of non-localizable macOS Finder menu

Description Hackintosh HD 2021-02-08 15:48:25 UTC
Created attachment 135510 [details]
Screenshot of non-localizable macOS Finder menu

SUMMARY

[Disclaimer: Please forgive me if I should have overlooked something. I've read https://l10n.kde.org/docs/translation-howto/, but I'm not part of the localization team and thus not yet familiar with details of digikam's localization.]

As of today's digikam 7.2.0-rc, the digikam macOS Finder menu is apparently still not localizable. All content remains in English (tested with German, see attached screenshot) which would be okay if the strings simply hadn't been translated yet. But they apparently do not appear at all in https://websvn.kde.org/*checkout*/trunk/l10n-kf5/de/messages/digikam/digikam.po?revision=1592707 (? - to my understanding the relevant resource for German localization).


STEPS TO REPRODUCE
1. Launch digikam under macOS
2. Check the digikam Finder menu with an active localization

SOFTWARE/OS VERSIONS
macOS: 10.14.6 Security Update 2021-001
Comment 1 Hackintosh HD 2021-02-08 15:52:27 UTC
... in case somebody would like to add the strings if that becomes possible:

About digikam - Über digikam
Preferences… - Einstellungen … (with a space)
Services - Dienste
Hide digikam - digikam ausblenden
Hide Others - Andere ausblenden
Show All - Alle einblenden
Quit digikam - digikam beenden
Comment 2 Maik Qualmann 2021-02-08 16:37:59 UTC
This menu probably belongs to the KXmlGui component of the KF5 framework. Their translation is probably missing in the MacOS bundle, this menu is not available under other operating systems.

Maik
Comment 3 caulier.gilles 2021-02-08 17:35:40 UTC
No, i don't think it's relevant of KXMLGUI. in fact this menu is specifiq to Apple macOS and managed by operating system. I think that actions in this menu are hosted by macOS with current system locale.

Gilles Caulier
Comment 4 Maik Qualmann 2021-02-08 17:54:04 UTC
But then Qt:

https://doc.qt.io/qt-5/macos-issues.html#menu-bar

Maik
Comment 5 Hackintosh HD 2021-02-08 17:55:28 UTC
(In reply to caulier.gilles from comment #3)

My system locale however is AFAIK set to German:

~ $ locale
LANG="de_DE.UTF-8"
LC_COLLATE="de_DE.UTF-8"
LC_CTYPE="de_DE.UTF-8"
LC_MESSAGES="de_DE.UTF-8"
LC_MONETARY="de_DE.UTF-8"
LC_NUMERIC="de_DE.UTF-8"
LC_TIME="de_DE.UTF-8"
LC_ALL=
~ $
Comment 7 caulier.gilles 2021-02-09 07:18:39 UTC
Thanks Maik, for the inks, i don't know the technic to wrap i18n for apple application menu...

But, i take a look to other KDE application as Kate and Krita available for macOS, and i don't see any plist file to wrap i18n for this menu...

Non KDE Application macOS bundle are different and probably built with xcode IDE directly, as FireFox and VLC for ex. The file contents about i18n is different.

Gilles
Comment 8 caulier.gilles 2021-02-09 07:19:49 UTC
To HickitoshHD : Can you try to see if Kate or Krita installed on your Mac has also the same i18n menu problem ?

GilleS Caulier
Comment 9 Hackintosh HD 2021-02-09 09:44:24 UTC
(In reply to caulier.gilles from comment #8)
> To HickitoshHD : Can you try to see if Kate or Krita installed on your Mac
> has also the same i18n menu problem ?
> 
> GilleS Caulier

No problem, installed both and tested:

Krita 4.4.2: Same problem, Krita macOS Finder menu is in English while the other menu items seem localized. Same problem by the way also with OpenTodoList, https://github.com/mhoeher/opentodolist, which also may be QT-based (it hasn't got a Finder menu apart from the macOS system menu, which remains in English while the GUI is localized).

Kate 20.12.2: Application apparently isn't localized at all (language switch mechanism is obviously the same as in digikam, but there is no other choice than U.S. English). So unfortunately Kate is not really helpul here.
Comment 10 Hackintosh HD 2021-02-09 09:57:26 UTC
If there are other QT-based, localized applications with a macOS build that I could test, feel free to let me know,
Comment 11 Hackintosh HD 2021-02-09 12:40:20 UTC
I've also opened a bug report for Krita, as it is showing the same problem: https://bugs.kde.org/show_bug.cgi?id=432685.
Comment 12 caulier.gilles 2021-02-09 13:28:23 UTC
Clementine Audio player has also a macOS version. It fully based on Qt.

https://www.clementine-player.org/

Gilles Caulier
Comment 13 caulier.gilles 2021-02-09 13:30:23 UTC
KmyMoney 

https://kmymoney.org/

...has also a macOS version:

https://binary-factory.kde.org/view/MacOS/job/KMyMoney_Release_macos/lastStableBuild/

Gilles Caulier
Comment 14 caulier.gilles 2021-02-09 13:32:31 UTC
Labplot:

https://labplot.kde.org/

has also a macOS version :

https://binary-factory.kde.org/view/MacOS/job/Labplot_Release_macos/

Gilles Caulier
Comment 15 caulier.gilles 2021-02-09 13:33:37 UTC
Marble globe viewer has also a macOS version :

https://marble.kde.org/install.php?

Gilles Caulier
Comment 16 Hackintosh HD 2021-02-09 13:55:35 UTC
(In reply to caulier.gilles from comment #12)
> Clementine Audio player has also a macOS version. It fully based on Qt.

Thank you, Gilles! - Clementine 1.3.1 is unfortunately suffering from a startup crash on Mojave, reported in https://github.com/clementine-player/Clementine/issues/6606, and the 1.4.0-rcs are Catalina+-only, so I unfortunately can't test it.

(In reply to caulier.gilles from comment #13)
Unfortunately no luck with KMyMoney, either, it crashes on launch while being unable to load a library ("@rpath/QtTextToSpeech.framework/Versions/5/QtTextToSpeech"). According to https://bugs.kde.org/show_bug.cgi?id=428511 of October 2020, it is not localized on macOS.

I'll check the other apps later today.
Comment 17 Hackintosh HD 2021-02-09 19:51:22 UTC
I've just gone through https://en.wikipedia.org/wiki/Category:Software_that_uses_Qt and have now found an application that, at the same time, …

1. … is built on Qt,
2. … is free open source software,
3. … has been decently localized into languages other than U.S. English and
4. … has correctly implemented the localization for its macOS Finder menu item:

It's KeePassXC, https://keepassxc.org/. Source at https://github.com/keepassxreboot/keepassxc.
Comment 18 Hackintosh HD 2021-02-09 19:57:35 UTC
(In reply to Hackintosh HD from comment #17)

… and a Qt-based application with at least a _partly_ localized macOS Finder menu item:

MuseScore, https://musescore.org/. Source available from https://github.com/musescore/MuseScore.
Comment 19 caulier.gilles 2021-06-13 14:38:18 UTC
Solution is very simple to do with the bundle. See my comments :

https://bugs.kde.org/show_bug.cgi?id=432685#c3
https://bugs.kde.org/show_bug.cgi?id=432685#c4

Gilles Caulier
Comment 20 caulier.gilles 2021-06-13 14:55:06 UTC
Git commit 755bd1bdafbac3223cc420a67e145af51878d8cd by Gilles Caulier.
Committed on 13/06/2021 at 14:53.
Pushed by cgilles into branch 'master'.

Create empty .lproj directories in the MacOS bundle to enable localized menu entries in application

M  +9    -0    project/bundles/macports/04-build-installer.sh

https://invent.kde.org/graphics/digikam/commit/755bd1bdafbac3223cc420a67e145af51878d8cd
Comment 21 caulier.gilles 2021-06-15 15:57:34 UTC
digiKam 7.3.0 pre-release MacOS package build from today now include the system menu local files as explained in comment #19.

Gilles Caulier