Summary: | Marble uses ws.geonames.org, which is gone, should use api.geonames.org | ||
---|---|---|---|
Product: | [Applications] marble | Reporter: | Kevin Kofler <kevin.kofler> |
Component: | general | Assignee: | marble-bugs |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Fedora RPMs | ||
OS: | All | ||
URL: | https://www.geonames.org/export/ws-overview.html | ||
Latest Commit: | https://invent.kde.org/education/marble/commit/86d22b6f9735673cb87fbfc6e246c23718463cba | Version Fixed In: | 20.12.3 |
Attachments: |
marble-19.12.2-kde#432598.patch
marble-20.12.2-kde#432598.patch |
Description
Kevin Kofler
2021-02-07 04:58:17 UTC
Created attachment 135880 [details]
marble-19.12.2-kde#432598.patch
The attached patch (against the old version of Marble I am still running, but it should apply to the current master) fixes the issue for me.
Are you OK with me committing (and pushing) this patch?
(It is really as straightforward as replacing ws.geonames.org with api.geonames.org everywhere, no other changes needed.) Actually, examples/qml/data-layers/EarthquakesModel.qml was already fixed (so that part of the patch is obsolete), but the .cpp files were not. Created attachment 135881 [details]
marble-20.12.2-kde#432598.patch
This version of the patch should apply cleanly to master and 20.12.
Git commit 4fbec8ea4827744f1b74ed709e6b5cce27d4eff8 by Kevin Kofler. Committed on 27/02/2021 at 00:21. Pushed by kkofler into branch 'master'. Fix GeoNames web service URL, is now api.geonames.org (#432598) Fix geonamesUrl in src/plugins/render/*/*.cpp from ws.geonames.org (which no longer resolves) to api.geonames.org. M +1 -1 src/plugins/render/earthquake/EarthquakeModel.cpp M +1 -1 src/plugins/render/postalcode/PostalCodeModel.cpp M +2 -2 src/plugins/render/weather/GeoNamesWeatherService.cpp M +1 -1 src/plugins/render/wikipedia/WikipediaModel.cpp https://invent.kde.org/education/marble/commit/4fbec8ea4827744f1b74ed709e6b5cce27d4eff8 Git commit 86d22b6f9735673cb87fbfc6e246c23718463cba by Kevin Kofler. Committed on 27/02/2021 at 00:23. Pushed by kkofler into branch 'release/20.12'. Fix GeoNames web service URL, is now api.geonames.org (#432598) Fix geonamesUrl in src/plugins/render/*/*.cpp from ws.geonames.org (which no longer resolves) to api.geonames.org. M +1 -1 src/plugins/render/earthquake/EarthquakeModel.cpp M +1 -1 src/plugins/render/postalcode/PostalCodeModel.cpp M +2 -2 src/plugins/render/weather/GeoNamesWeatherService.cpp M +1 -1 src/plugins/render/wikipedia/WikipediaModel.cpp https://invent.kde.org/education/marble/commit/86d22b6f9735673cb87fbfc6e246c23718463cba Should be in time for 20.12.3. |