Bug 432477

Summary:	[git version] Jaggy icons when hovering over them (or not)
Product:	[Unmaintained] lattedock	Reporter:	David Rubio <david.alejandro.rubio>
Component:	plasmoid	Assignee:	Michail Vourlakos <mvourlakos>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	git (master)
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/plasma/latte-dock/commit/08118d531c27588716d28f835cf7891782f8a439	Version Fixed/Implemented In:
Sentry Crash Report:

Description David Rubio 2021-02-03 19:05:20 UTC

SUMMARY
Icons on the tasks applet look really jaggy if you hover over it, and sometimes without hovering. Sometimes just doing latte-dock --replace will fix the icons appearing jagged when not hovering over them, but hovering over them again will make them jaggy.

STEPS TO REPRODUCE
1. Dock with absolute size 48px, padding shouldn't matter, but I use 15%

OBSERVED RESULT
Before hovering over them: https://i.imgur.com/GpvpAAC.png
After hovering over them: https://i.imgur.com/8R15adr.png

Sometimes it looks like on the 2nd pic without hovering. Then you can just --replace and it might fix itself.

EXPECTED RESULT
Sharp icons.

SOFTWARE/OS VERSIONS
Linux: 5.10.12
KDE Plasma Version: 5.20.80
KDE Frameworks Version: 5.78
Qt Version: 5.15.2

ADDITIONAL INFORMATION
Last working commit in latte: d46864e0ade1f0edee7a6bc4b9f6a219baea79aa
According to https://bugs.kde.org/show_bug.cgi?id=432444#c5, it might be a PlasmaCore.IconItems issue. If so please move it to the appropiate area.

Comment 1 David Rubio 2021-02-03 19:06:18 UTC

Icon being hovered: https://i.imgur.com/mstlJef.png

Comment 2 David Rubio 2021-02-03 19:21:53 UTC

With "icon zoom" on hover, it seems to pretty much go away, but the animation is super jaggy.

Comment 3 Michail Vourlakos 2021-02-03 20:24:55 UTC

You can try the latest commit, it is trying to workaround and make things a bit more affordable. It is trying to be crispy for normal size and smooth in-between

Comment 4 David Rubio 2021-02-03 21:17:37 UTC

(In reply to Michail Vourlakos from comment #3)
> You can try the latest commit, it is trying to workaround and make things a
> bit more affordable. It is trying to be crispy for normal size and smooth
> in-between

At 9547509ba94e2315ba05f52a10ce42d86c7a9210: https://imgur.com/vulGQ2J.png

Comment 5 Michail Vourlakos 2021-02-03 22:02:10 UTC

Git commit 08118d531c27588716d28f835cf7891782f8a439 by Michail Vourlakos.
Committed on 03/02/2021 at 21:59.
Pushed by mvourlakos into branch 'master'.

move on to Kirigami.Icons for Tasks

--fix any crispy and blurry issues by moving
to Kirigami.Icon which maintainable and much
better for Latte requirements. For example
no roundToIconSize option is needed at all.
As it appears Kirigami.Icon is using only
the smooth parameter in order to define
its coloring.

M  +1    -1    CMakeLists.txt
M  +24   -24   README.md
M  +10   -9    plasmoid/package/contents/ui/task/TaskIcon.qml

https://invent.kde.org/plasma/latte-dock/commit/08118d531c27588716d28f835cf7891782f8a439

Comment 6 Michail Vourlakos 2021-02-03 22:03:29 UTC

Definitely a PlasmaCore.IconItem issue... I moved the Tasks codepage to Kirigami.Icon(s) and everything is painted correctly in my system.

Comment 7 David Rubio 2021-02-03 22:16:02 UTC

(In reply to Michail Vourlakos from comment #6)
> Definitely a PlasmaCore.IconItem issue... I moved the Tasks codepage to
> Kirigami.Icon(s) and everything is painted correctly in my system.

Yup, it's fine now :)

On 08118d531c27588716d28f835cf7891782f8a439: https://i.imgur.com/hnHASpt.png (which is good!)

I guess you could file a bug about PlasmaCore.IconItem. I wouldn't know how to word it.