Bug 432328

Summary:	macOS preview does not work because of broken packaging
Product:	[Applications] krita	Reporter:	amyspark <amy>
Component:	General	Assignee:	amyspark <amy>
Status:	RESOLVED FIXED
Severity:	normal	CC:	halla
Priority:	NOR	Keywords:	regression
Version:	4.4.2
Target Milestone:	---
Platform:	macOS (DMG)
OS:	macOS
Latest Commit:	https://invent.kde.org/graphics/krita/commit/c22b6d6c77aabd7d604b6485e91b7ff82621a4ad	Version Fixed In:
Sentry Crash Report:
Attachments:	qlmanage -p test.kra qlmanage -t test.kra

Description amyspark 2021-01-31 01:28:05 UTC

Created attachment 135317 [details]
qlmanage -p test.kra

SUMMARY

The packaging process for Krita 4.4.2 failed silently, yielding a QuickLook Generator bundle that cannot run on macOS. This has broken thumbnails and Quick Look previews.

STEPS TO REPRODUCE
1. Install Krita.
2. Run on Terminal `qlmanage -p <a KRA file>`.

OBSERVED RESULT
The QuickLook Generator executable crashes silently with the attached log.

EXPECTED RESULT
There should appear a QuickLook preview of the KRA document.

SOFTWARE/OS VERSIONS
Windows: 
macOS: Mojave 10.14.5
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION

First reported on the K-A forum: <https://krita-artists.org/t/kra-files-preview-in-osx/17860> .

Comment 1 amyspark 2021-01-31 01:28:47 UTC

Created attachment 135318 [details]
qlmanage -t test.kra

Attached the result of trying to generate a thumbnail with qlmanage.

Comment 2 Bug Janitor Service 2021-02-01 15:48:53 UTC

A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/682

Comment 3 amyspark 2021-02-01 16:10:16 UTC

Git commit 15a4f8987755a3abea0b748c008b378b4c8fb66e by L. E. Segovia.
Committed on 01/02/2021 at 16:10.
Pushed by lsegovia into branch 'master'.

macOS: Finder plugins must use the loader_path of Krita.app

Xcode is picking up Quazip's requirement of our own bundled zlib.
Because the resulting plugins are not marked as executable, they are not
fixed by osxdeploy.sh. Moreover, the executables lack a rpath at all.

This commit marks the plugins' executables as +x and specifies a rpath
pointing to Krita's Frameworks folder. I also left an alternative option
inside osxdeploy.sh, if it is required in the future.

M  +2    -2    krita/integration/integration.xcodeproj/project.pbxproj
M  +6    -1    packaging/macos/osxdeploy.sh

https://invent.kde.org/graphics/krita/commit/15a4f8987755a3abea0b748c008b378b4c8fb66e

Comment 4 amyspark 2021-02-01 16:13:05 UTC

Git commit c22b6d6c77aabd7d604b6485e91b7ff82621a4ad by L. E. Segovia.
Committed on 01/02/2021 at 16:12.
Pushed by lsegovia into branch 'krita/4.3'.

macOS: Finder plugins must use the loader_path of Krita.app

Xcode is picking up Quazip's requirement of our own bundled zlib.
Because the resulting plugins are not marked as executable, they are not
fixed by osxdeploy.sh. Moreover, the executables lack a rpath at all.

This commit marks the plugins' executables as +x and specifies a rpath
pointing to Krita's Frameworks folder. I also left an alternative option
inside osxdeploy.sh, if it is required in the future.
(cherry picked from commit 15a4f8987755a3abea0b748c008b378b4c8fb66e)

M  +2    -2    krita/integration/integration.xcodeproj/project.pbxproj
M  +6    -1    packaging/macos/osxdeploy.sh

https://invent.kde.org/graphics/krita/commit/c22b6d6c77aabd7d604b6485e91b7ff82621a4ad