Bug 431961

Summary: Cannot remove custom wallpapers from "Desktop Settings"
Product: [Plasma] plasmashell Reporter: Andrew Brouwers <abrouwers>
Component: Image WallpaperAssignee: Marco Martin <notmart>
Status: RESOLVED FIXED    
Severity: normal CC: cyril.rossi, nate, nicolas.fella, plasma-bugs
Priority: VHI Keywords: regression
Version: 5.20.90   
Target Milestone: 1.0   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In: 5.21
Attachments: Setup

Description Andrew Brouwers 2021-01-22 22:58:49 UTC
Created attachment 135074 [details]
Setup

SUMMARY

After updating to 5.21-beta, I removed my settings and started with a fresh plasma environment.  I added a few custom wallpapers, but ended up sticking with stock.  Trying to use the trash icon (and, the "open folder" button) isn't doing anything - the wallpapers remain, and dolphin isn't spawned.

STEPS TO REPRODUCE
1. Switch to Desktop layout
2. Add custom wallpaper
3. Attempt to delete with built-on buttons
Comment 1 Nicolas Fella 2021-01-23 00:41:35 UTC
Can confirm that this is a regression from 5.20

likely relevant plasmashell output:

file:///home/nico/kde/usr/share/plasma/wallpapers/org.kde.image/contents/ui/WallpaperDelegate.qml:47: ReferenceError: imageModel is not defined
file:///home/nico/kde/usr/share/plasma/wallpapers/org.kde.image/contents/ui/WallpaperDelegate.qml:47: ReferenceError: imageModel is not defined
file:///home/nico/kde/usr/share/plasma/wallpapers/org.kde.image/contents/ui/WallpaperDelegate.qml:60: ReferenceError: imageModel is not defined
Comment 2 Nicolas Fella 2021-01-23 01:00:29 UTC
Bisected to https://invent.kde.org/plasma/plasma-workspace/-/commit/c02b4329d048fb6ee3599f28169c8f7e1d963a15

@Cyril can you please take a look?
Comment 3 Cyril Rossi 2021-01-25 13:32:09 UTC
(In reply to Nicolas Fella from comment #2)
> Bisected to
> https://invent.kde.org/plasma/plasma-workspace/-/commit/
> c02b4329d048fb6ee3599f28169c8f7e1d963a15
> 
> @Cyril can you please take a look?

Yes, I will take a look.
Comment 4 Bug Janitor Service 2021-01-28 15:24:17 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/605
Comment 5 Nate Graham 2021-01-28 17:48:48 UTC
Git commit 7d94c13e65871bf6ae56e15420c7521a123b6afa by Nate Graham, on behalf of Cyril Rossi.
Committed on 28/01/2021 at 17:48.
Pushed by ngraham into branch 'master'.

Wallpaper config: fix property imageModel that was missing in delegate

Regression was introduced within ScreenLocker highlight settings MR.
Used for both desktop and lock screen wallpaper configuration.

M  +6    -5    wallpapers/image/imagepackage/contents/ui/config.qml

https://invent.kde.org/plasma/plasma-workspace/commit/7d94c13e65871bf6ae56e15420c7521a123b6afa
Comment 6 Nate Graham 2021-01-28 17:49:57 UTC
Git commit fc86d38348ca3686d377a439c8b107ccd13b344d by Nate Graham, on behalf of Cyril Rossi.
Committed on 28/01/2021 at 17:49.
Pushed by ngraham into branch 'Plasma/5.21'.

Wallpaper config: fix property imageModel that was missing in delegate

Regression was introduced within ScreenLocker highlight settings MR.
Used for both desktop and lock screen wallpaper configuration.


(cherry picked from commit 7d94c13e65871bf6ae56e15420c7521a123b6afa)

M  +6    -5    wallpapers/image/imagepackage/contents/ui/config.qml

https://invent.kde.org/plasma/plasma-workspace/commit/fc86d38348ca3686d377a439c8b107ccd13b344d