| Summary: | Custom smudge brush that worked in a previous version of Krita no longer works | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | tomtomtomreportingin |
| Component: | Brush engines | Assignee: | Dmitry Kazakov <dimula73> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | dimula73, halla, tamtamy.tymona |
| Priority: | NOR | Keywords: | regression, release_blocker |
| Version First Reported In: | 4.4.2 | ||
| Target Milestone: | --- | ||
| Platform: | Appimage | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/commit/53d4e1121e2d90aa48de01a2f0539ddd132d80b4 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
tomtomtomreportingin
2021-01-22 15:50:46 UTC
Confirming. I've also added "release_blocker" since it sounds serious (but hopefully easy to fix, if there are no engine issues, just initialization). Well, it looks like the brush has been generated at the short period of time when the format of the lightness brush algorithm was not finished enough (even though we released that). Now the file has incorrect settings inside. Just changing the brush tip to some other one in the new version of Krita and setting it back fixes the issue. I will try to add some workaround that. A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/692 Hi, tomtomtom! Could you please test the packages linked in this MR? https://invent.kde.org/graphics/krita/-/merge_requests/692 It should fix the bug, and I hope it doesn't cause any more regressions... The buggy brush seems to work now, and I did a quick stroke with each and every brush I have installed, and they all seem to work fine. Git commit 2f2f5722cbcd4323bb5f6ee77bc3945fc7b59274 by Dmitry Kazakov. Committed on 05/02/2021 at 17:39. Pushed by dkazakov into branch 'master'. Fix opening brushes created during incomplete lightness feature implementation We had a period of time, when the presence or absence of **color** in the brush (not transparency) was used to decide whether to use useColorAsAlpha. Basically, absence of color in the brush would switch mask mode even when useColorAsAlpha was false. In the new versions of Krita 'useColorAsAlpha' tag is completely removed, and 'brushApplication' tag is used instead, which does allow such ambiguity. M +12 -2 libs/brush/KisColorfulBrush.cpp M +5 -1 libs/brush/KisColorfulBrush.h M +9 -2 libs/brush/kis_brushes_pipe.h M +6 -3 libs/brush/kis_gbr_brush.cpp M +2 -1 libs/brush/kis_imagepipe_brush.cpp M +6 -2 libs/brush/kis_png_brush.cpp M +2 -2 libs/brush/kis_predefined_brush_factory.cpp M +4 -4 libs/brush/tests/kis_imagepipe_brush_test.cpp M +2 -2 plugins/impex/brush/kis_brush_import.cpp M +1 -1 plugins/paintops/libpaintop/kis_brush_chooser.cpp https://invent.kde.org/graphics/krita/commit/2f2f5722cbcd4323bb5f6ee77bc3945fc7b59274 Git commit 53d4e1121e2d90aa48de01a2f0539ddd132d80b4 by Dmitry Kazakov. Committed on 09/02/2021 at 12:04. Pushed by dkazakov into branch 'krita/4.3'. Fix opening brushes created during incomplete lightness feature implementation We had a period of time, when the presence or absence of **color** in the brush (not transparency) was used to decide whether to use useColorAsAlpha. Basically, absence of color in the brush would switch mask mode even when useColorAsAlpha was false. In the new versions of Krita 'useColorAsAlpha' tag is completely removed, and 'brushApplication' tag is used instead, which does allow such ambiguity. # Conflicts: # libs/brush/kis_brushes_pipe.h # libs/brush/kis_imagepipe_brush.cpp M +12 -2 libs/brush/KisColorfulBrush.cpp M +5 -1 libs/brush/KisColorfulBrush.h M +8 -2 libs/brush/kis_brushes_pipe.h M +6 -3 libs/brush/kis_gbr_brush.cpp M +2 -1 libs/brush/kis_imagepipe_brush.cpp M +6 -2 libs/brush/kis_png_brush.cpp M +2 -2 libs/brush/kis_predefined_brush_factory.cpp M +4 -4 libs/brush/tests/kis_imagepipe_brush_test.cpp M +2 -2 plugins/impex/brush/kis_brush_import.cpp M +1 -1 plugins/paintops/libpaintop/kis_brush_chooser.cpp https://invent.kde.org/graphics/krita/commit/53d4e1121e2d90aa48de01a2f0539ddd132d80b4 |