Bug 431837

Summary: Wallpaper removal deletes wallpapers from source location
Product: [Plasma] plasmashell Reporter: David <solbeziel>
Component: Image & Slideshow wallpaper pluginsAssignee: Marco Martin <notmart>
Status: RESOLVED FIXED    
Severity: critical CC: nate, plasma-bugs-null, solbeziel
Priority: NOR    
Version First Reported In: 5.19.5   
Target Milestone: 1.0   
Platform: Debian testing   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description David 2021-01-20 05:04:03 UTC
SUMMARY


STEPS TO REPRODUCE
1. Right-click on desktop and select "Configure Desktop" (or whatever translated equivalent)

2. Select "+ Add Image..."

3. Locate your favourite desktop wallpaper, which has followed you from computer to computer for 15 years, but for some stupid reason isn't backed up anywhere.

4. Press the trashcan icon to remove the wallpaper again from the list.


OBSERVED RESULT

The wallpaper is permanently deleted from the source location; not even moved to the trash.


EXPECTED RESULT

The action of "+ Add Image..." should have been reversed, removing the wallpaper from the list but leaving the source file intact.


SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Debian Testing (Bullseye/Sid)
KDE Plasma Version: 5.19.5
KDE Frameworks Version:  5.74.0
Qt Version: 5.15.1


ADDITIONAL INFORMATION

The action of "Remove Wallpaper" is counter-intuitive and conflicts with the action of "Add Image":
    * "Add Image" takes an image from a source location and incorporates it into the list of registered wallpapers. 
    * "Remove Image" deletes an image from the source location where the image was found.

These two actions should be exact opposites: If adding an image registers an image from a source location, then removing the image should unregister that same image. It is beyond the mandate of the wallpaper manager to be a file manager also.
Comment 1 Nate Graham 2021-08-30 17:14:25 UTC
Yikes, that sounds traumatic. Sorry to hear that. Raising severity to "critical", as if this is true, unexpectedly deleting user data with no confirmation meets the definition of a critical issue.

However I cannot reproduce the issue in Plasma 5.22. I just tried this on several images that I added to the wallpaper view and there were only removed from the view, not the filesystem. Can you try again with Plasma 5.22?
Comment 2 David 2021-09-02 16:49:48 UTC
(In reply to Nate Graham from comment #1)

> Can you try again with Plasma 5.22?

Hi Nate

Currently running:
 Plasma      5.20.5
 Frameworks  5.78.0
 Qt          5.12.2
 Debian GNU/Linux 11

The desktop wallpaper manager behaviour is completely different now. It seems to be sensitive to whether an image file still exists and remove it automatically when it is no longer available. More to the point, when manually removing a wallpaper files are not deleted.

In short, no; this seems to have been fixed sometime between 5.19.5 and 5.20.5.
Comment 3 Nate Graham 2021-09-02 16:50:57 UTC
Yay!