Bug 431691

Summary: Sticky notes unexpectedly deleted upon theme change
Product: [Applications] systemsettings Reporter: nbgyan <nanabaahgyan>
Component: kcm_lookandfeelAssignee: Plasma Bugs List <plasma-bugs-null>
Status: RESOLVED FIXED    
Severity: major CC: nate
Priority: NOR Keywords: usability
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Neon   
OS: Linux   
Latest Commit: https://invent.kde.org/plasma/plasma-workspace/commit/22e02fbbab3584932199adde24121ccceb66187b Version Fixed/Implemented In: 5.22
Sentry Crash Report:

Description nbgyan 2021-01-16 14:37:40 UTC 
SUMMARY
Selecting 'Use desktop layout from theme' from Global theme change wipes other configuration files including those of some widgets installed.


STEPS TO REPRODUCE
1. Go to Global Theme to change theme
2. Select Use desktop layout from theme

OBSERVED RESULT
Other desktop configurations settings are lost. For instance, in my case, after the theme change, my Sticky Notes widget had gone together with the notes I had on it. Notes were not restored after adding the widget back.

EXPECTED RESULT
I think the warning note that appears on top on the checkbox when selected is not severe enough and should be properly worded. It's not only 'desktop layout' that is changed. Users should be prompted that certain configuration files could be lost as well, as the action, more or less, resets the desktop.

SOFTWARE/OS VERSIONS
Operating System: KDE neon 5.20
KDE Plasma Version: 5.20.5
KDE Frameworks Version: 5.78.0
Qt Version: 5.15.2
Kernel Version: 5.4.0-62-generic
OS Type: 64-bit
Processors: 8 × Intel® Core™ i7-8565U CPU @ 1.80GHz
Memory: 15.3 GiB of RAM
Graphics Processor: Mesa Intel® UHD Graphics 620
Comment 1 Nate Graham 2021-01-26 06:07:11 UTC 
Yeah this is pretty bad. I can at least adjust the warning message. Long term, we want to overhaul how this works.
Comment 2 Bug Janitor Service 2021-01-26 19:32:29 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/598
Comment 3 Nate Graham 2021-01-27 21:23:41 UTC 
Git commit 22e02fbbab3584932199adde24121ccceb66187b by Nate Graham.
Committed on 27/01/2021 at 21:22.
Pushed by ngraham into branch 'master'.

[kcms/lookandfeel] Make scary warning more explicit

The warning that appears when you check the "Use desktop layout from
theme" checkbox is scary, but not actually scary enough. It doesn't make
clear what exactly will be reset. As a result, the user may
underestimate its destructiveness and mistakenly destroy personal
data--for example, text in a sticky note applet.

Accordingly, let's make the text more explicit so people realize it's
scary.

In the long term, I would like for applying a Global Theme to display a
sheet that tells you what it will do, providing the opportunity to tell
it not to do any of those things that you don't want it to do.

But until we have something like that, let's just make this warning
message more explicit:
FIXED-IN: 5.22

M  +1    -1    kcms/lookandfeel/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/commit/22e02fbbab3584932199adde24121ccceb66187b