| Summary: | The Knetattach dialog is no longer launched from the Dolphin (a required item is missing) | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | Nova <coder.nova99> |
| Component: | general | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | 4wy78uwh, hatem.badawi, kfm-devel, KVAnton.WEB, nate, zawertun |
| Priority: | NOR | ||
| Version: | 20.12.1 | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/system/dolphin/commit/33270dd4423eea329b8f20db17f8d70ab7b108da | Version Fixed In: | 21.04 |
| Sentry Crash Report: | |||
| Attachments: |
Dolphin - no add network share button
b1cadeba939155282a9fadf7d7b025d6529c489e.patch |
||
|
Description
Nova
2021-01-15 07:48:46 UTC
there was always a special item, but it disappeared https://docs.kde.org/trunk5/en/kde-workspace/knetattach/screenshot1.png This is an intentional change; we removed the "Add network folder" item from the view, and put it Dolphin's toolbar when visiting the "Network" location. Unfortunately, the change to remove it was made in Frameworks 5.78, while the change to put it in the toolbar was made in Dolphin 21.04, and these two products have different release schedules. As a result, the item is now missing for everyone, and will be until Dolphin 21.04 is released in a few months. I'm sorry for this regression. We were hoping nobody would notice, but I suppose you did. :) It's time-limited, thankfully. (In reply to Nate Graham from comment #2) > This is an intentional change; we removed the "Add network folder" item from > the view, and put it Dolphin's toolbar when visiting the "Network" location. > > Unfortunately, the change to remove it was made in Frameworks 5.78, while > the change to put it in the toolbar was made in Dolphin 21.04, and these two > products have different release schedules. As a result, the item is now > missing for everyone, and will be until Dolphin 21.04 is released in a few > months. > > I'm sorry for this regression. We were hoping nobody would notice, but I > suppose you did. :) It's time-limited, thankfully. RIP, thanks for the info! I'll go ahead and downgrade Dolphin and wait until an update rolls out for both packages :D You're welcome. You would actually want to downgrade KIO (to 5.77), or *upgrade* Dolphin (to 21.04). However note that downgrading KIO will also re-expose you to Bug 430374 which is pretty nasty. Kubuntu will ship Frameworks 5.78 (or later), but not the 21.04 versions of the applications, so people will certainly notice for the next ten months. Urth that sucks. I'll send a message to the distro mailing list telling them what they can cherry-pick to improve this situation. I have Dolphin 20.12.1 and KF5-5.78.0. Still I can't find this button on the toolbar. What's wrong? You need Dolphin 21.04 which has not been released yet. So you would need to built it from source or get your distro to patch it in for you. I'm sending distros an email about this right now. Created attachment 134893 [details]
Dolphin - no add network share button
Ah, got it. Sorry. Created attachment 134895 [details] b1cadeba939155282a9fadf7d7b025d6529c489e.patch Added patch from commit b1cadeba939155282a9fadf7d7b025d6529c489e (https://invent.kde.org/system/dolphin/-/commit/b1cadeba939155282a9fadf7d7b025d6529c489e) slightly modified so it can be applied to the version 20.12.x. Somehow works. Thanks to everyone! You can now run knetattach from krunner or konsole. It is useful as a solution to the problem here and now Re-opening, we can't wait for 21.04 and will backport the feature to 20.12.2 *** Bug 431807 has been marked as a duplicate of this bug. *** (In reply to Nate Graham from comment #13) > Re-opening, we can't wait for 21.04 and will backport the feature to 20.12.2 good decision 👍 Git commit 33270dd4423eea329b8f20db17f8d70ab7b108da by Norbert Preining. Committed on 18/01/2021 at 22:48. Pushed by ngraham into branch 'release/20.12'. Show button to open knetattach inline with URL nav on remove:// view This is a backport of b1cadeba939155282a9fadf7d7b025d6529c489e From b1cadeba939155282a9fadf7d7b025d6529c489e Mon Sep 17 00:00:00 2001 From: Nate Graham <nate@kde.org> Date: Tue, 15 Dec 2020 23:03:00 -0700 Subject: [PATCH] Show button to open knetattach inline with URL nav on Remote:// view In conjunction with https://invent.kde.org/frameworks/kio/-/merge_requests/260, the net result is to hide the knetattach launcher in the view, and show it inline with Dolphin's URL navigator toolbar when viewing the remote:// view, just like how we add an "Empty Trash" button when viewing trash://. The backport ensures that even with frameworks << 5.78 only one network button is shown. M +61 -0 src/dolphinnavigatorswidgetaction.cpp M +19 -1 src/dolphinnavigatorswidgetaction.h https://invent.kde.org/system/dolphin/commit/33270dd4423eea329b8f20db17f8d70ab7b108da |
