| Summary: | Ctrl-clicking on filenames with line numbers on the end from `grep` output has broken recently | ||
|---|---|---|---|
| Product: | [Applications] konsole | Reporter: | Nate Graham <nate> |
| Component: | general | Assignee: | Konsole Developer <konsole-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | a.samirh78, cbc.alves |
| Priority: | NOR | Keywords: | regression |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=431496 | ||
| Latest Commit: | https://invent.kde.org/utilities/konsole/commit/a5f298063a5a2be60a15916979ff07529b61a841 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | Error message | ||
Related to this one? https://bugs.kde.org/show_bug.cgi?id=431496 Could be, yes. That's why I CCd Ahmad. :) I think I see what the issue is (in the lovely world of mimetypes :)). Thanks Ahmad! A possibly relevant merge request was started @ https://invent.kde.org/utilities/konsole/-/merge_requests/327 Git commit a5f298063a5a2be60a15916979ff07529b61a841 by Kurt Hindenburg, on behalf of Ahmad Samir. Committed on 20/01/2021 at 15:36. Pushed by hindenburg into branch 'master'. FileFilterHotSpot: check the mime type of the file after cleaning the path QMimeDataBase will return "application/octet-stream" as the mime type of something like "path/to/some/textfile.txt:123:123:", because we are using methods from it that check only the file extension. That meant some valid text files with line/column suffixes couldn't be opened. Instead move the mime type check _after_ the file path has been cleaned. Also account for mime types that aren't recognized, e.g. a text file with no extension. M +13 -7 src/filterHotSpots/FileFilterHotspot.cpp https://invent.kde.org/utilities/konsole/commit/a5f298063a5a2be60a15916979ff07529b61a841 |
Created attachment 134858 [details] Error message Everything KDE from git master. This was a recently introduced feature that was totally awesome, but it broke sometime in the last few days. When I ctrl+click on "src/qml/MediaPlayListView.qml:143:", it no longer opens my chosen text editor with that file on line 143; instead, it display an error dialog saying "The file or folder /home/nate/kde/src/elisa/src/qml/MediaPlayListView.qml:143 does not exist.