Summary: | Crash in kglobalaccel setting | ||
---|---|---|---|
Product: | [Applications] systemsettings | Reporter: | David Edmundson <kde> |
Component: | kcm_keys | Assignee: | Michael Jansen <kde> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kde, nate, plasma-bugs |
Priority: | NOR | Keywords: | regression |
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/plasma-desktop/commit/ea08472b0fc87001ef700e5743342390103dff53 | Version Fixed In: | 5.21 |
Sentry Crash Report: |
Description
David Edmundson
2021-01-12 15:36:04 UTC
I think guarding should be ok but seems underlying there is something weird happening. The user picks an application from the dialog, which should have a valid desktopfile, which means we should have at least on valid action in there (launching the applciation) A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/307 Git commit ea08472b0fc87001ef700e5743342390103dff53 by David Redondo. Committed on 18/01/2021 at 14:48. Pushed by davidre into branch 'master'. Guard against an empty response when adding Applications One would expect to always have at least one action here, namely the launch action corresponding to the Exec entry. But we have a crash where it looks like that we got an empty list, guarding against that does no harm. M +5 -1 kcms/keys/globalaccelmodel.cpp https://invent.kde.org/plasma/plasma-desktop/commit/ea08472b0fc87001ef700e5743342390103dff53 |