Bug 431493

Summary:	Okular search bar no longer closed when pressing Esc
Product:	[Applications] okular	Reporter:	Rajeesh K V <rajeeshknambiar>
Component:	general	Assignee:	Okular developers <okular-devel>
Status:	RESOLVED FIXED
Severity:	normal	CC:	dev+kde, nate, ombrophile, onkekabonke, yasharya2901
Priority:	NOR
Version:	20.12.0
Target Milestone:	---
Platform:	Fedora RPMs
OS:	Linux
Latest Commit:	https://invent.kde.org/frameworks/kcompletion/commit/7acda936f06193e9fc85ae5cf9ccc8d65971f657	Version Fixed In:	5.79
Sentry Crash Report:

Description Rajeesh K V 2021-01-12 12:49:36 UTC

SUMMARY
Since Okular 20.12.0 (first noticed in 20.12.1, but downgraded to 20.12.0 to verify), pressing 'Esc' key when cursor is focussed on the 'search' bar/widget does not close the search bar. Hitting 'Esc' used to close search bar in 20.08.y. Not sure if it could be due to frameworks update around the same time (5.77.0 → 5.78.0).

STEPS TO REPRODUCE
1. Open a PDF, press 'Ctr+f' to search, brining up the search bar at bottom
2. Enter some text
3. Press 'Esc'

OBSERVED RESULT
Search bar at the bottom is still visible

EXPECTED RESULT
Search bar is closed


SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Fedora 33, Plasma 5.20.5
(available in About System)
KDE Plasma Version: 5.20.5
KDE Frameworks Version: 5.78.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION
Let me know if anything could be tried to debug the issue or provide helpful details.

Comment 1 Bug Janitor Service 2021-01-12 22:44:37 UTC

A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kcompletion/-/merge_requests/11

Comment 2 Albert Astals Cid 2021-01-12 22:57:14 UTC

Git commit 7acda936f06193e9fc85ae5cf9ccc8d65971f657 by Albert Astals Cid.
Committed on 12/01/2021 at 22:43.
Pushed by aacid into branch 'master'.

Fix regression caused due to porting from operator+ to operator|

M  +1    -1    src/klineedit.cpp

https://invent.kde.org/frameworks/kcompletion/commit/7acda936f06193e9fc85ae5cf9ccc8d65971f657

Comment 3 Nicolas Fella 2021-01-17 23:27:05 UTC

*** Bug 431762 has been marked as a duplicate of this bug. ***

Comment 4 Albert Astals Cid 2021-01-24 18:15:58 UTC

*** Bug 432025 has been marked as a duplicate of this bug. ***

Comment 5 Albert Astals Cid 2021-01-25 21:58:54 UTC

*** Bug 432109 has been marked as a duplicate of this bug. ***

Comment 6 Yuri Chornoivan 2021-01-28 08:14:48 UTC

*** Bug 432229 has been marked as a duplicate of this bug. ***