| Summary: | Desktop widgets change place at system startup when Plasma's resolution differs from SDDM's resolution | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | terkald <adressepoub.rl> |
| Component: | Containment | Assignee: | Marco Martin <notmart> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | adressepoub.rl, katyaberezyaka, nate, plasma-bugs, zackloods0 |
| Priority: | NOR | ||
| Version: | 5.20.5 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| See Also: |
https://bugs.kde.org/show_bug.cgi?id=360478 https://bugs.kde.org/show_bug.cgi?id=431359 |
||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/commit/c7fe9fc0d271a145c9025994673599fb51872446 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
terkald
2021-01-11 11:46:14 UTC
As a data point, does it start working if you use the native resolution of the screen, causing SDDM and Plasma to use the same resolution? I just tested just now with five tries. By putting the desktop at the same resolution as sddm, no plasmoid changes place. Thanks. We do support changing the resolution to differ from that of SDDM, so that configuration ought to work properly. Might be fixed automatically if we fix Bug 360478, but I'm not positive about that. (In reply to Nate Graham from comment #3) > Thanks. > > We do support changing the resolution to differ from that of SDDM, so that > configuration ought to work properly. > > Might be fixed automatically if we fix Bug 360478, but I'm not positive > about that. No, i can confirm that this bug still. I am using Arch Linux and with SDDM + Plasma same resolution, widgets still move (and the icons) after reboot, and not save the resize, widgets returns original size and messy icons :( I don't know what can be but is very annoying It's not exactly the same as Bug 360478, sut I strongly suspect that once the requested feature in Bug 360478 is implemented, it will fix this. (In reply to Nate Graham from comment #5) > It's not exactly the same as Bug 360478, sut I strongly suspect that once > the requested feature in Bug 360478 is implemented, it will fix this. Thank you Nathan :) I hope this fix soon,it is very annoying that something so basic gives these problems. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2535 Git commit 39dd7bc3b75df58eb2d569df4f89cbe65f1113b6 by Marco Martin. Committed on 25/01/2023 at 16:07. Pushed by mart into branch 'master'. fix problems in plasmoid layout restore The layout manager has a functionality that when the layout is resized, it tries to move all plasmoids to keep roughtly the same proportional distance they had before the resize happened, to make screen resolution change the least "suprising" possible. We actually need this in only one case: The screen resoltion changed and there is not a saved plasmoid layout for this resolution. What was actually happening was that this heuristic was executed *only* when the layout was resized due to panels being added/resized (and not when it should have been). When a panel gets added/resized we want the plasmoids layoput to change *as little as possible* again, to not make surprises. As a side effect , it casued a pretty serious bug: plasmoids near to the vertical center of the screen migrated upwards of few pixels at every plasma restart, because ever time it starts without a panel which appears only later, causing that heuristic to execute and break havoc. Now the heuristic is executed only when the screen resolution changes, which will cause a "config key change" event. Execute this also when the containment migrates to a new screen, and as soon this heuristic got executed, save the layout on the new key. Related: bug 442919, bug 437538, bug 453141 M +7 -2 components/containmentlayoutmanager/abstractlayoutmanager.h M +14 -4 components/containmentlayoutmanager/appletslayout.cpp M +9 -2 components/containmentlayoutmanager/gridlayoutmanager.cpp M +1 -1 components/containmentlayoutmanager/gridlayoutmanager.h https://invent.kde.org/plasma/plasma-workspace/commit/39dd7bc3b75df58eb2d569df4f89cbe65f1113b6 Git commit c7fe9fc0d271a145c9025994673599fb51872446 by Marco Martin. Committed on 25/01/2023 at 16:23. Pushed by mart into branch 'Plasma/5.27'. fix problems in plasmoid layout restore The layout manager has a functionality that when the layout is resized, it tries to move all plasmoids to keep roughtly the same proportional distance they had before the resize happened, to make screen resolution change the least "suprising" possible. We actually need this in only one case: The screen resoltion changed and there is not a saved plasmoid layout for this resolution. What was actually happening was that this heuristic was executed *only* when the layout was resized due to panels being added/resized (and not when it should have been). When a panel gets added/resized we want the plasmoids layoput to change *as little as possible* again, to not make surprises. As a side effect , it casued a pretty serious bug: plasmoids near to the vertical center of the screen migrated upwards of few pixels at every plasma restart, because ever time it starts without a panel which appears only later, causing that heuristic to execute and break havoc. Now the heuristic is executed only when the screen resolution changes, which will cause a "config key change" event. Execute this also when the containment migrates to a new screen, and as soon this heuristic got executed, save the layout on the new key. Related: bug 442919, bug 437538, bug 453141 M +7 -2 components/containmentlayoutmanager/abstractlayoutmanager.h M +14 -4 components/containmentlayoutmanager/appletslayout.cpp M +9 -2 components/containmentlayoutmanager/gridlayoutmanager.cpp M +1 -1 components/containmentlayoutmanager/gridlayoutmanager.h https://invent.kde.org/plasma/plasma-workspace/commit/c7fe9fc0d271a145c9025994673599fb51872446 |