| Summary: | Merging to hidden layer discards hidden layer | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Dodger <el.dodgero> |
| Component: | Layer Stack | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | CONFIRMED --- | ||
| Severity: | normal | CC: | halla, info, kynlo.art, tamtamy.tymona, vitamorus.art, zcxvcb2 |
| Priority: | NOR | ||
| Version First Reported In: | 5.2.6 | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Unspecified | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Dodger
2021-01-11 11:27:14 UTC
Hi Dodger, I can reproduce here and I understand it can be problematic to loose the content of the hidden (Layer 1).
> EXPECTED RESULT
> 3: User is prohibited from merging down (option is greyed out) when the layer below
At a first glance: Yes. This is a similar solution than what is happening to a merge with a "Locked:Yes" layer underneath. That sounds like a safe solution, leading users to ask themselves why nothing is done and merged. It might attracts their attention to the situation of the layer stack to notice a hidden layer is involved in the process.
But also let's wait for other feedback, especially about how other software handle this as convention and workflow might also already exists about that.
Given layers 1, 2, 3 with 3 being topmost, and 2 invisble, and the active layer is 3: * Corel Painter, Photoshop and GIMP merge 3 onto 1, skipping 2, which is on top of the merged layer * Autodesk Sketch warns the user that the invisible layer's content will be gone, then merges 3 with 2, effectively just removing 2 * MyPaint merges 3 onto 2, making 2 visible * Clip Studio disables the Merge with layer below action if the 2 is invisible. * The latest version of photoshop behaves like Krita: it deletes the hidden layer without warninng. * PS 2021 doesn't seem to do anything if 2 is hidden. I think if the current behaviour is confusing, the best course of action would be just do nothing in case the layers selected have one visible layer and one or more invisible ones. I think it wouldn't be that much of a problem for old users since they can just remove it, and could prevent mistakes. Personally I find the current Krita's behaviour logical, consistent and expected, but I *think* I wouldn't mind too much if it was changed to doing nothing. Sometimes preventing mistakes is better than sticking to the rules to the letter. But I think that might need a discussion on KA. This particular issues loves to get me. It feels inconsistent to allow a user to merge a visible layer and an invisible layer. Considering the following behavior - try to apply a filter (Blur) to an invisible layer, I get error: "Cannot apply filter to locked layer" - try to draw on the invisible layer, I get error: "Layer is invisible" - try to merge 2 invisible layers, nothing changes I'd like to also add another perspective. When we merge an invisible layer, it isn't empty, it's hidden. Shouldn't a merge maintain that information that's within the layer (ignoring the layer property)? And here we are two years later, and I just lost another 2 hours of work to this. Perhaps I should just use PS. Re-confirming for 5.2.6. Personally I think I would prefer it if, when trying to merge layers and at least one of them are hidden, there would be a dialog prompting the user what to do (discard hidden layers, unhide and merge, or skip hidden layers). Second best option IMO would be to treat hidden layers as locked by default and leave them untouched in the layer stack. Started discussion + poll on KA: https://krita-artists.org/t/poll-what-should-happen-when-merging-hidden-layers/109426 Still the same thing under 5.2.11. Merging with invisible layer does NOTHING other than deleting it. Why wouldn't one just delete it than??? People got their work wiped out for years, in exchange of what? A quicker way to delete a lot of layers? I'd like to hear opposing argument, because I'm reaaaally struggling to come up with one. |