| Summary: | Elisa intermittently crashed in KFileMetaData::Property::Property() when fetching lyrics tag | ||
|---|---|---|---|
| Product: | [Applications] Elisa | Reporter: | Be <be.0> |
| Component: | general | Assignee: | Matthieu Gallien <matthieu_gallien> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nate, stefan.bruens |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=458607 | ||
| Latest Commit: | https://invent.kde.org/multimedia/elisa/commit/e2845b589170de36851ff37d36d76697adde7440 | Version Fixed In: | 20.12.2 |
| Attachments: | backtrace of the crash | ||
Crash is somewhere in KFileMetadata while trying to fetch lyrics; moving. Do you have Baloo indexing turned off? Is there any pattern? Does it always crash on one file or a set of files? Do all of the files that is crashes while trying to load have lyrics tags? Or do none of them? Or is it random? In Elisa's preferences "Music indexing" defaulted to "Scan the filesystem directly". I tried switching that to "Use fast native indexer" but the crash still occurs. There is no pattern other than it happens at the end of tracks. It does not happen consistently with any particular files. AFAIK none of my files have lyrics tags. I just checked some files in Picard and did not see any lyrics tags. Thanks. @ngraham: The crash is in elisa, when iterating a QMap coming from KFM. Please provide any proof the QMap is incorrect. This has to be investigated in elisa first. (In reply to Stefan Brüns from comment #4) > @ngraham: The crash is in elisa, when iterating a QMap coming from KFM. > Please provide any proof the QMap is incorrect. This has to be investigated > in elisa first. I wanted to have a look as soon as I can to the different crashes including this one. I have just noticed that the flatpak build seems mostly unaffected while a local build is crashing on me at each track changes. So this is a stupid concurrent access on one attributes of an object all within elisa's code. A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/215 Git commit e2845b589170de36851ff37d36d76697adde7440 by Matthieu Gallien. Committed on 22/01/2021 at 22:51. Pushed by mgallien into branch 'release/20.12'. avoid concurrent access when fetching lyrics M +4 -2 src/models/trackmetadatamodel.cpp M +3 -0 src/models/trackmetadatamodel.h https://invent.kde.org/multimedia/elisa/commit/e2845b589170de36851ff37d36d76697adde7440 |
Created attachment 134728 [details] backtrace of the crash SUMMARY This crash occurs sometimes at the end of a track before starting to play the next one. See attached backtrace. SOFTWARE/OS VERSIONS Elisa: master branch, commit 422afda69bad7160f86c3d0607ab4487ccd94ce6 Linux: Fedora 33 KDE Frameworks Version: 5.78 Qt Version: 5.15.2