| Summary: | There is no button to add Tag to picture | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | MarcP <iwannaberich> |
| Component: | Usability-Ergonomy | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | iwannaberich, metzpinguin |
| Priority: | NOR | ||
| Version: | 7.2.0 | ||
| Target Milestone: | --- | ||
| Platform: | Flatpak | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 7.2.0 | |
| Sentry Crash Report: | |||
The behavior has always been this way up to now. What if I don't want to confirm yet. I am looking for a long name and then want it to be created in a different path and I would like to add "newTag/searchedName" to the entry. The Enter key is a typical method for accepting texts. Maik You have time to do that before hitting the Apply button. Ok, I just downloaded Digikam 7.1, and indeed the behavior was different. Something definitely changed from Digikam 7.1 to 7.2. Once you clicked on Create or selected an existing tag, the tag was assigned, and waited for you to apply the changes. Right now, you have to click on create, hit enter, and the click Apply (three confirmations instead of two) The tag creation process is actually incorrect for digiKam-7.2.0-RC, I'll take a look at it. Maik Thanks Maik. The cause seems to be this commit: https://invent.kde.org/graphics/digikam/-/commit/12d0495e79c3de56b6f33ab0cd5f0087cf54f2af The signal/slot connection to the completer is sometimes lost. Maik Git commit 49273f20f0505834377680f3c565f66a88d3d9d6 by Maik Qualmann. Committed on 09/01/2021 at 16:40. Pushed by mqualmann into branch 'master'. we ignore clazy and use the connection to completer recommended in the Qt-Doc M +4 -4 core/libs/tags/widgets/addtagslineedit.cpp https://invent.kde.org/graphics/digikam/commit/49273f20f0505834377680f3c565f66a88d3d9d6 Ok, clicking in the completer popup works again. A button next to the edit field only makes it narrower. And I think we have a bug report from you that the edit field is too narrow. ((:-)) I close the bug, the Enter key works fine and no problems have been reported so far. Maik That's perfect, thank you! |
SUMMARY When writing a tag in the Captions/Tag panel, there is no button to confirm and add that keyword. The user must press the Enter button, but it might not be intuitive for everyone. Also, it feels a bit redundant, since the user has already selected the desired tag, and has yet to click on Apply. I suggest adding a small button next to the "Enter tag here." text field, or simply directly adding the tag once the user has clicked on the desired tag in the autosuggest dropdown list (wasn't that the default behavior until recently?). STEPS TO REPRODUCE 1. Select a picture 2. Go to the Tag tab in the Captions panel. 3. Write a new or existing tag on the text field on top ("Enter tag here.") 4. Click on the suggestion (either create the new tag, or select and existing one) OBSERVED RESULT The text just entered stays there, in that textbox. User needs to press Enter to add that tag, and then click Apply. EXPECTED RESULT The tag should already be assigned and appear in the tag tree in that panel, waiting for changes to be applied. Or rather add a button to confirm. SOFTWARE/OS VERSIONS Digikam 7.2.0 from Flatpak Build date: Jan 9 2021 (target: Debug) Rev.: c3077451a517fb160e0e25a9991a279948610500