Summary: | For files that don't fit in the trash, the user isn't provided with the option to delete immediately | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-kio | Reporter: | darktori |
Component: | Trash | Assignee: | Nate Graham <nate> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | a.samirh78, bodertz, bugtracking, darktori, eduardosareias, kdelibs-bugs, kfm-devel, nate |
Priority: | NOR | Keywords: | usability |
Version: | 5.77.0 | ||
Target Milestone: | --- | ||
Platform: | Neon | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/frameworks/kio/commit/3f922b72e5202b882c85a390926c905f8008ca60 | Version Fixed In: | 5.100 |
Description
darktori
2021-01-09 11:41:45 UTC
I am tossing the usability flag on this, marking it wishlist and stealing the assignee from a somewhat related issue (425997), hopefully they do not mind. I think this could be solved by simply having dolphin prompt and say "this file is too large for the trash would you like to permanently delete it instead?" with a secondary "Are you sure? This action can not be undone" just to prevent people from accidentally auto-piloting the first yes. Please only assign bugs to yourself instead of random developers. The code in Plasma (written in QML) is completely unrelated to the code in Dolphin. > EXPECTED RESULT
> Instead of a non-actionable error, there could be a prompt about deleting the
> file instead. Ideally Dolphin wouldn't even give the option to move to trash if
> the file is to large.
I think that's what it's supposed to do. If it's not doing that, there's a bug.
Wouldn't showing two entries in Dolphin's context menu, one to move to trash and another to delete permanently fix this issue? apparently "the press Shift while the menu is open to show "Delete"" isn't readily obvious to new users. Having both visible isn't really good enough because the user can't predict when a file will be too big to trash. We should present the user with options at the moment when that condition happens IMO. *** Bug 453838 has been marked as a duplicate of this bug. *** On Steam Deck (no keyboard, handheld mode) I just stumbled uppon this. This feature would be a blessing here, and we could really use it, especially because we are constantly dealing with huge game installers or folders. I know we can go into Dolphin settings and enable the "Delete" option, but a new user would absolutely never know that could be done. Even I didnĀ“t remember this and got stuck there 5 minutes trying to figure out what to do. I was thinking about removing it using the terminal (would be fun without a keyboard I guess) when I remembered that option. There should absolutely be a "Delete Permanentely" button in the "File too large for trash" error message that Dolphin shows. This really is a case of "failed, you are on your own, good luck". This seems like a simple thing to do, just add a button in the message (and that button could trigger the exact same "confirm" modal popup that using the shift-delete triggers). Yeah, I agree. I'll look into it. A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kio/-/merge_requests/1003 Git commit 3f922b72e5202b882c85a390926c905f8008ca60 by Ahmad Samir. Committed on 19/10/2022 at 04:29. Pushed by ahmadsamir into branch 'master'. AskUserActionInterface: add DeleteInsteadOfTrash deletion type Typical use-case: - the user tries to Trash some file, which fails due to size constraints - we ask the user again about deleting the files instead of Trashing them FIXED-IN: 5.100 M +7 -0 src/core/askuseractioninterface.h M +8 -1 src/core/global.h M +3 -0 src/core/job_error.cpp M +2 -2 src/ioslaves/trash/trashimpl.cpp M +22 -2 src/widgets/deleteortrashjob.cpp M +23 -1 src/widgets/widgetsaskuseractionhandler.cpp https://invent.kde.org/frameworks/kio/commit/3f922b72e5202b882c85a390926c905f8008ca60 |