Bug 431290

Summary: Network security type erroneously reported as "unknown"
Product: [Frameworks and Libraries] frameworks-networkmanager-qt Reporter: Ezike Ebuka <yerimyah1>
Component: generalAssignee: Jan Grulich <jgrulich>
Status: RESOLVED UPSTREAM    
Severity: normal CC: arojas, justin.zobel, lamarque, lukas.tinkl, nate
Priority: HI Keywords: regression
Version First Reported In: 5.78.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
URL: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/631
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Here it is
Security type

Description Ezike Ebuka 2021-01-08 07:27:23 UTC
SUMMARY
the option is no longer there to share wifi with qr codes 


STEPS TO REPRODUCE
1. Go to the system-tray, 
2. click on the network connection button 
3. right click on a connected WIFI network 

OBSERVED RESULT
there are only two options, disconnect and configure

EXPECTED RESULT
there should be a show qr code button there 


SOFTWARE/OS VERSIONS
Linux/KDE Plasma
KDE Plasma Version: 5.20.4 
KDE Frameworks Version: 5.77 
Qt Version: 5.15.2 

ADDITIONAL INFORMATION
I believe fucntionality was was maybe when refactoring or porting as the UI file for it is still on gitlab [here](https://invent.kde.org/plasma/plasma-nm/-/tree/master/applet/contents/ui) under showQR.qml 

[here](https://phabricator.kde.org/D22457) is also a previous phabricator task
Comment 1 Justin Zobel 2021-01-14 23:59:40 UTC
Confirmed on 5.20.4
Comment 2 Nate Graham 2021-01-15 01:53:26 UTC
Created attachment 134875 [details]
Here it is

That's weird, I see it just fine on git master. Can wither of you confirm with git master/unstable packages?
Comment 3 Nate Graham 2021-01-15 01:54:14 UTC
Another option: do you not have the prison framework? That's what provides QR code functionality. What distro are you using?
Comment 4 Justin Zobel 2021-01-15 06:34:08 UTC
I've tried it from kdesrc-build using:

source $pathtoprefix/build/plasma-workspace/prefix.sh
$pathtoprefix/usr/bin/plasmashell --replace &

But when it reloads I still can't see the QR Code in the right-click menu.
Comment 5 Nate Graham 2021-01-15 14:58:49 UTC
I see it in mine when built from source, which means there's some difference between my setup and yours. If you build from source can you please check the cmake output for plasma-nm and make sure that all optional dependencies are installed?
Comment 6 Antonio Rojas 2021-01-15 19:43:38 UTC
Created attachment 134912 [details]
Security type

The actual issue is this
Comment 7 Ezike Ebuka 2021-01-15 19:46:34 UTC
(In reply to Nate Graham from comment #3)
> Another option: do you not have the prison framework? That's what provides
> QR code functionality. What distro are you using?

I am using manjaro .

Which prison frame work ?
Comment 8 Nate Graham 2021-01-15 19:51:03 UTC
Thanks Antonio. Have you gotten other reports of this?
Comment 9 Antonio Rojas 2021-01-15 19:58:13 UTC
(In reply to Nate Graham from comment #8)
> Thanks Antonio. Have you gotten other reports of this?

The problem is not that the QR is not shown when the security type is unknown, that is intentional:

https://invent.kde.org/plasma/plasma-nm/-/blob/v5.20.5/applet/contents/ui/ConnectionItem.qml#L74
https://invent.kde.org/plasma/plasma-nm/-/blob/v5.20.5/applet/contents/ui/ConnectionItem.qml#L39

The problem is the security type being reported as unknown instead of the real one (WPA2-PSK in my case). This regressed in NM 1.24, bisecting now
Comment 10 Nate Graham 2021-01-15 20:05:25 UTC
Reminds me of Bug 422740.
Comment 11 Antonio Rojas 2021-01-15 20:19:47 UTC
(In reply to Nate Graham from comment #10)
> Reminds me of Bug 422740.

Yes, but that one affected all networks so it was more visible. This one only affects the currently connected one. And it's wrong in networkmanager-qt already (AccessPoint::Capabilities)
Comment 12 Antonio Rojas 2021-01-15 23:01:31 UTC
Bisected to https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/b83f07916a540d482dfabbb13744083b0b6ab8b0

"qdbus --system org.freedesktop.NetworkManager /org/freedesktop/NetworkManager/AccessPoint/xx org.freedesktop.NetworkManager.AccessPoint.Flags" used to return 3 before that commit, and returns 0 afterwards. This doesn't match the docs at https://developer.gnome.org/NetworkManager/stable/gdbus-org.freedesktop.NetworkManager.AccessPoint.html, so it seems to be a NM bug
Comment 13 Nate Graham 2021-01-16 15:36:33 UTC
Thanks! Marking as an upstream issue.