| Summary: | Improve the effect when adding/removing floating dock's gap | ||
|---|---|---|---|
| Product: | [Unmaintained] lattedock | Reporter: | trmdi |
| Component: | application | Assignee: | Michail Vourlakos <mvourlakos> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version First Reported In: | git (master) | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/latte-dock/commit/9d3ebca4af6ea4dd5712b743114f442aaea37030 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
trmdi
2021-01-07 09:33:29 UTC
Screencast: 1, with latte: https://streamable.com/m8vk7q 2, without latte: https://streamable.com/wbufun A question, when latte is removing the gap, its animation speed does not follow Plasma's setting? (In reply to trmdi from comment #2) > A question, when latte is removing the gap, its animation speed does not > follow Plasma's setting? It does not. I had enough of the nonsense of plasma animations speed bar. It is the reason Latte v0.9.x has broken animation speeds during different plasma versions. Latte is providing its own animation speed for all of its animations. Show me please a slow maximized animation with plasma panel in Always Visible mode. Is it drawn correctly then? (In reply to Michail Vourlakos from comment #4) > Show me please a slow maximized animation with plasma panel in Always > Visible mode. Is it drawn correctly then? https://streamable.com/er9j8y Git commit 9d3ebca4af6ea4dd5712b743114f442aaea37030 by Michail Vourlakos. Committed on 07/01/2021 at 13:02. Pushed by mvourlakos into branch 'master'. provide stable struts thickness --when a floating view is hiding its screen gap there is no reason for struts to be added during that phase. Published struts could be the final expected window position in that case. M +23 -10 app/view/visibilitymanager.cpp M +10 -0 app/view/visibilitymanager.h M +17 -0 containment/package/contents/ui/VisibilityManager.qml https://invent.kde.org/plasma/latte-dock/commit/9d3ebca4af6ea4dd5712b743114f442aaea37030 (In reply to Michail Vourlakos from comment #6) > Git commit 9d3ebca4af6ea4dd5712b743114f442aaea37030 by Michail Vourlakos. > Committed on 07/01/2021 at 13:02. > Pushed by mvourlakos into branch 'master'. > > provide stable struts thickness > > --when a floating view is hiding its screen gap > there is no reason for struts to be added > during that phase. Published struts could be > the final expected window position in that case. > > M +23 -10 app/view/visibilitymanager.cpp > M +10 -0 app/view/visibilitymanager.h > M +17 -0 containment/package/contents/ui/VisibilityManager.qml > > https://invent.kde.org/plasma/latte-dock/commit/ > 9d3ebca4af6ea4dd5712b743114f442aaea37030 https://streamable.com/0fqyur wow, perfect now. Thank you very much. <3 One more question, why don't I see any difference when changing Latte's Animation speed? (In reply to trmdi from comment #8) > One more question, why don't I see any difference when changing Latte's > Animation speed? Video of x1 vs x3 speed, no difference: https://streamable.com/ji7bw3 (In reply to trmdi from comment #9) > (In reply to trmdi from comment #8) > > One more question, why don't I see any difference when changing Latte's > > Animation speed? > > Video of x1 vs x3 speed, no difference: https://streamable.com/ji7bw3 I have just reenabled that behavior in master. I remember that it was creating an issue but I can not remember what exactly. I leave it as the slide in-out is influenced by animations speed and if I found the problem I will comment it in the code then. |