Summary: | The Palette docker tooltip has inadequate behaviour with particular swatch names | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | Ahab Greybeard <ahab.greybeard> |
Component: | Dockers | Assignee: | Halla Rempt <halla> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | halla |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Mint (Debian based) | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/graphics/krita/commit/011cf6195b82d6e198742c2122578a79dbc57eea | Version Fixed In: | |
Attachments: | Demo palette for this bug |
Description
Ahab Greybeard
2021-01-06 11:44:24 UTC
The Wishlist bug associated with this palette docker UI/UX bug is: https://bugs.kde.org/show_bug.cgi?id=431221 Since tooltips are handled by the toolkit, not by Krita, I suspect that there's a check somewhere in Qt for the string, and if the string is the same, the tooltip isn't moved. Git commit 2c90be8d2ad8dbb345c0ed5d6afb196d69182cbb by Halla Rempt. Committed on 06/01/2021 at 12:59. Pushed by rempt into branch 'master'. Add channel values to the palette swatch tooltip With this change, I cannot reproduce the tooltips not moving their position. Related: bug 431221 M +1 -1 libs/widgets/KisPaletteModel.cpp https://invent.kde.org/graphics/krita/commit/2c90be8d2ad8dbb345c0ed5d6afb196d69182cbb Git commit b017ca6dc02007e8ef50f9ea9782d5f90a28e13b by Halla Rempt. Committed on 06/01/2021 at 13:01. Pushed by rempt into branch 'krita/4.3'. Add channel values to the palette swatch tooltip With this change, I cannot reproduce the tooltips not moving their position. Related: bug 431221 (cherry picked from commit 2c90be8d2ad8dbb345c0ed5d6afb196d69182cbb) M +1 -1 libs/widgets/KisPaletteModel.cpp https://invent.kde.org/graphics/krita/commit/b017ca6dc02007e8ef50f9ea9782d5f90a28e13b Hm, now that I am thinking of it, it might be that it works for me because I'm using Qt 5.15, not the 5.12 we use for appimages. Let's check tomorrow's nightly. Testing with the Jan 06 4.4.3 alpha (git b017ca6) appimage, Qt version 5.12.9: The bug report is resolved. The palette does store the Alpha value and displays with the correct appearance for a low alpha colour but when selected for use, the palette alpha does not overide the Opacity set on the Toolbar slider. I don't know if that's to be expected or is a separate issue. Ah, no, we have never used the alpha of the palette colors. Actually, I never realized that palettes had the alpha defined. Maybe we should... Wishlist bug reported: https://bugs.kde.org/show_bug.cgi?id=431260 Git commit 011cf6195b82d6e198742c2122578a79dbc57eea by Halla Rempt. Committed on 06/01/2021 at 13:01. Pushed by rempt into branch 'krita/4.4.2'. Add channel values to the palette swatch tooltip With this change, I cannot reproduce the tooltips not moving their position. Related: bug 431221 (cherry picked from commit 2c90be8d2ad8dbb345c0ed5d6afb196d69182cbb) M +1 -1 libs/widgets/KisPaletteModel.cpp https://invent.kde.org/graphics/krita/commit/011cf6195b82d6e198742c2122578a79dbc57eea |