Bug 431219

Summary: Overriding settings (icons, plasma theme, wallpaper, etc) set by a global theme causes those changes to be discarded after reboot
Product: [Plasma] plasmashell Reporter: fernandoenzo
Component: generalAssignee: David Edmundson <kde>
Status: RESOLVED FIXED    
Severity: normal CC: ego.cordatus, fsa, giuseppebelluzzi95, kainz.a, nate, ngompa13, plasma-bugs, rdieter, runawaytrike, zawertun
Priority: HI    
Version: 5.23.3   
Target Milestone: 1.0   
Platform: Neon   
OS: Linux   
Latest Commit: Version Fixed In: 5.24
Sentry Crash Report:
Attachments: KDE Neon.webm
Fedora 35 KDE Spin.webm
KDE Neon.webm

Description fernandoenzo 2021-01-06 11:43:48 UTC
Icon preferences are not saved

If we change the global theme (for example to Orchis), obviously the icons of the whole system change.

If we try to reverse the icon change by manually selecting the Breeze icons, upon restarting the session this change will disappear and we will see the Orchis icons again.

On the other hand, if we change the icons to Breeze Dark, when restarting the session, the changes remain fixed. Then it is a bug in the Breeze icon theme that does NOT affect Breeeze Dark.

I have managed to reproduce the bug on both Neon and Debian Bullseye. Even on Neon Live booting from an USB.

Steps to reproduce it:

1. Go to system preferences → Global theme → Get new global themes → Download Orchis (it also happens with other themes, such as Xmas or Spectrum)

2. Select the Orchis theme and apply the changes.

3. Select the Breeze icon set.

4. Close and reopen the session. The icon set reverts to Orchis instead of Breeze.

5. Select the Breeze Dark icon set.

6. Close and reopen the session. The icons set is now Breeze Dark and not Orchis. (So this is Ok, it's the desirable behavior)

What's wrong with the Breeze Light icons?
Comment 1 Nate Graham 2021-01-12 01:09:40 UTC
*** Bug 431383 has been marked as a duplicate of this bug. ***
Comment 2 Nate Graham 2021-01-12 01:09:56 UTC
*** Bug 426870 has been marked as a duplicate of this bug. ***
Comment 3 FSA 2021-07-31 19:55:21 UTC
Confirm. Reboot or "Settings" (https://www.youtube.com/watch?v=jTcej08CgDg)
Comment 4 FSA 2021-11-17 09:00:19 UTC
Up to 5.23.2. Confirm. :-(
Comment 5 Yaroslav Sidlovsky 2021-11-25 08:43:19 UTC
Just reproduced that bug with plasma version 5.23.3 & default light and dark themes.
Comment 6 Yaroslav Sidlovsky 2021-11-25 08:57:13 UTC
Quick way to reproduce:
1. Open "System Settings", choose "Dark Theme", click "Apply", close "System Settings";
2. Open "System Settings" again, change theme to "Light Theme", click "Apply", close "System Settings";
3. Open "System Settings" once again -> plasma theme will be changed to dark (but it was set to light).

David, could you reproduce that?

Also I see that after changing plasma theme that way config `~/.config/plasmarc` is not changed at all,
i.e. selected theme is not written into it (line `name=breeze-dark` or similar can't be found).
But after step 3 - line `name=breeze-dark` appears.
So config only changes 1 time at last step.
Comment 7 FSA 2021-11-25 13:45:45 UTC
Breeze theme bug in Fedora 34/35.
Temporary solution, ~/.config/plasmarc:
[Theme]
name=Breeze
Comment 8 Yaroslav Sidlovsky 2021-11-25 15:04:50 UTC
It's Fedora specific bug.

Caused by this patch:
https://src.fedoraproject.org/rpms/plasma-workspace/blob/rawhide/f/plasma-workspace.spec#_449
https://src.fedoraproject.org/rpms/plasma-workspace/blob/rawhide/f/plasma-workspace-5.3.0-set-fedora-default-look-and-feel.patch

I've just tried to rebuild package without it and bug was gone.
Comment 9 Nate Graham 2021-11-25 15:43:02 UTC
No wonder I can't reproduce it, despite using Fedora 34--I build Plasma from source myself, so I don't have that patch. Can you please report this at https://bugzilla.redhat.com/? Thanks!
Comment 10 fernandoenzo 2021-11-25 17:25:35 UTC
This is not specific to Fedora. I am the original reporter of this bug, and when I wrote this, nearly one year ago, I was using the latest version of KDE Neon. It looks like it's still present and haven't been fixed yet.
Comment 11 Yaroslav Sidlovsky 2021-11-25 18:10:29 UTC
Sorry, I think we are talking about different bugs.
Comment 12 Yaroslav Sidlovsky 2021-11-25 18:13:08 UTC
fernandoenzo@gmail.com, could you reproduce sequence that I've described?
Comment 13 Yaroslav Sidlovsky 2021-11-25 19:39:06 UTC
Created attachment 143943 [details]
KDE Neon.webm
Comment 14 Yaroslav Sidlovsky 2021-11-25 19:39:19 UTC
Created attachment 143944 [details]
Fedora 35 KDE Spin.webm
Comment 15 Yaroslav Sidlovsky 2021-11-25 19:39:56 UTC
Double checked this bug on neon-user-20211116-1405.iso & F35-KDE-x86_64-LIVE-20211115.iso.
I've using instructions from the comment 6 to reproduce it (https://bugs.kde.org/show_bug.cgi?id=431219#c6).
Here is results:

1. KDE Neon (plasma-5.23.3, kf5-5.88.0, Qt-5.15.3) - no bug ovserved, see attached video "KDE Neon.webm".

2. Fedora 35, KDE Spin updated to latest version (plasma-5.23.3, kf5-5.88.0, Qt-5.15.2) - bug could be reproduced, see attached video "Fedora 35 KDE Spin.webm".

I'll report it to RedHat bugzilla.
Comment 16 Yaroslav Sidlovsky 2021-11-25 19:47:12 UTC
Created attachment 143945 [details]
KDE Neon.webm
Comment 17 fernandoenzo 2021-11-26 20:48:12 UTC
Hi,

I tried to reproduce my own steps in neon-testing-20211116-1815 and it looks like the bug is finally gone. Icons preferences are now properly saved.
I tried to reproduce the steps from comment 6 and I didn't have any problems as well.

So I'd say it's all good.
Comment 18 FSA 2021-11-30 06:04:14 UTC
The problem is solved by removing patches from Fedora.
https://bugzilla.redhat.com/show_bug.cgi?id=2026789
Comment 19 Rex Dieter 2022-01-19 21:40:25 UTC
This bug can be reproduced if one changes (patches) what the default look-and-feel is.  I'll leave it to upstream to decide whether that's valid use-case to support (re-opening).

Definitely not fixed (but can be closed as NOTABUG or INTENTIONAL, if this use-case won't or cannot be supported)
Comment 20 Nate Graham 2022-01-19 21:45:24 UTC
The way that specifying default global themes changed in Plasma 5.24 to something much more robust; now you can just add the new systemwide default to /etc/xdg/<wherever> as expected. Rex, I think the Fedora patch in question applies to the older, hackier code in Plasma 5.23 and earlier, right?

If so, I'm not sure there's anything we can do here since that code has already been improved in 5.24 to make this issue not happen anymore, and there are no more Plasma 5.23 releases planned.
Comment 21 Nate Graham 2022-01-28 21:04:58 UTC
Yeah, I think that has to be the resolution, sorry: Already fixed in 5.24, can't fix in 5.23.