Bug 431216

Summary:	[REGRESSION][BISECTED] Text is barely visible due to white becoming gray
Product:	[Applications] konsole	Reporter:	Konstantin Kharlamov <Hi-Angel>
Component:	font	Assignee:	Konsole Bugs <konsole-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	cbc.alves
Priority:	NOR
Version First Reported In:	20.12.0
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Konstantin Kharlamov 2021-01-06 10:30:50 UTC

SUMMARY

After update "20.08.3 → 20.12.0" all colors become darker. It would not be bad per se, except that white text become gray. It is best seen with a screenshot: https://i.imgur.com/ggsWDnn.png on the left is 20.08.3 and on the right is 20.12.0. The one on the right is unreadable.

STEPS TO REPRODUCE
1. Open konsole 
2. Look at diff through diffr utility.

OBSERVED RESULT

White text is all gray and is barely visible

EXPECTED RESULT

White text is white

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 5.20.4
KDE Frameworks Version: 5.77.0
Qt Version: 5.15.2

Comment 1 Konstantin Kharlamov 2021-01-06 10:55:13 UTC

Successfully bisected to commit:

    82806a2c129f8fa4b21be25b4108eecd8d460625 is the first bad commit
    commit 82806a2c129f8fa4b21be25b4108eecd8d460625
    Author: Carlos Alves <cbc.alves@gmail.com>
    Date:   Fri Nov 27 08:50:43 2020 -0300

        Fix bold character color paint

        Konsole was painting 'bold' character as 'faint bold' character.

        BUG: 405345
        FIXED-IN: 20.12
        (cherry picked from commit 270d6ea3247bb41a51535129e4b1c8eef51cf316)

     src/Screen.cpp | 8 +-------
     1 file changed, 1 insertion(+), 7 deletions(-)

I confirm that reverting the commit fixes the issue.

CCing the author.

Comment 2 Carlos Alves 2021-01-06 21:13:46 UTC

It was reverted:
https://invent.kde.org/utilities/konsole/-/commit/2d58ed02813f409ab0d140fcf4452643ea73ff2d

And pushed the revert to released branch:
https://invent.kde.org/utilities/konsole/-/commit/08aa65e32427f8dc49fbfd6b1d8997431b72dab2

A few weeks ago.

Comment 3 Konstantin Kharlamov 2021-01-06 21:17:21 UTC

(In reply to Carlos Alves from comment #2)
> It was reverted:
> https://invent.kde.org/utilities/konsole/-/commit/
> 2d58ed02813f409ab0d140fcf4452643ea73ff2d
> 
> And pushed the revert to released branch:
> https://invent.kde.org/utilities/konsole/-/commit/
> 08aa65e32427f8dc49fbfd6b1d8997431b72dab2
> 
> A few weeks ago.

Thank you! I see, closing then as fixed