Bug 431212

Summary: Flickering when floating dock is adding/removing screen gap for maximized windows
Product: [Unmaintained] lattedock Reporter: trmdi
Component: applicationAssignee: Michail Vourlakos <mvourlakos>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: git (master)   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Screencast
My layout
Screencast 2

Description trmdi 2021-01-06 09:15:58 UTC
SUMMARY
The situation has been improved with recent commits but the issue still exists, not completely resolved.

STEPS TO REPRODUCE
1. set Latte to have gap and remove gap for maximized windows
2. open a window
3. Do one of these
3.1 maximize and unmaximize it many times
3.2 maximize, then minimize and restore it many times


OBSERVED RESULT
the view flickers

EXPECTED RESULT
the gap is added/removed smoothly
Comment 1 trmdi 2021-01-06 09:19:17 UTC
Sometimes the effect runs smoothly, but sometimes it does not.
Comment 2 Michail Vourlakos 2021-01-06 09:28:58 UTC
show me a screenshot please and upload it in google drive or dropbox with a shared link in order to watch it.
Comment 3 trmdi 2021-01-06 14:24:42 UTC
Created attachment 134614 [details]
Screencast

Attached a video.
Comment 4 Michail Vourlakos 2021-01-06 16:52:33 UTC
1. please send me also your layout file
2. How did you achieve that look with your systray?
Comment 5 trmdi 2021-01-06 17:13:09 UTC
Created attachment 134619 [details]
My layout

2. That is from the Deepin-light theme, you can download it from KDE Store.
Comment 6 trmdi 2021-01-06 17:15:12 UTC
(In reply to trmdi from comment #5)
> 2. That is from the Deepin-light theme, you can download it from KDE Store.

https://store.kde.org/p/1413900/
Comment 7 Michail Vourlakos 2021-01-06 21:02:11 UTC
fixed with latest commits
Comment 8 trmdi 2021-01-07 02:51:42 UTC
Very smooth now. Thank you. <3
Comment 9 trmdi 2021-01-07 03:35:50 UTC
Created attachment 134630 [details]
Screencast 2

While it's fine for minimize/restore windows, there is still a bit tearing when you maximize windows. See my Screencast 2.
Comment 10 Michail Vourlakos 2021-01-07 06:59:19 UTC
Sorry I can not do any better without breaking other stuff. Length animation must be instantly applied.

Feel free to provide fixes.
Comment 11 trmdi 2021-01-07 07:30:07 UTC
I reopen this to track it because it has not been fully resolved.
Comment 12 Michail Vourlakos 2021-01-07 08:20:52 UTC
BTW if you set Maximum Length 100% with no roundness at all, is the flickering you are mentioning reproduced?
Comment 13 trmdi 2021-01-07 08:52:14 UTC
Yes, it still exists.

I found this a bit interesting. If you make the dock bigger, the gap higher, and go to SystemSettings > Workspace behavior > General behavior set the Animation speed to the slowest. Then observe 2 actions, maximize and unmaximize windows if:
- latte is running
- without latte
You will see latte somehow breaks Kwin maximizing effect.
Comment 14 Michail Vourlakos 2021-01-07 09:12:47 UTC
(In reply to trmdi from comment #13)
> Yes, it still exists.
> 
> I found this a bit interesting. If you make the dock bigger, the gap higher,
> and go to SystemSettings > Workspace behavior > General behavior set the
> Animation speed to the slowest. Then observe 2 actions, maximize and
> unmaximize windows if:
> - latte is running
> - without latte
> You will see latte somehow breaks Kwin maximizing effect.

Then it is something totally different that does not occur in my system.

For the maximizing issue I dont have any breakage in my system, you can open a different bug report. I have an idea though, struts are updated during the hiding gap animation.
Comment 15 trmdi 2021-01-07 09:37:30 UTC
(In reply to Michail Vourlakos from comment #14)
> (In reply to trmdi from comment #13)
> > Yes, it still exists.
> > 
> > I found this a bit interesting. If you make the dock bigger, the gap higher,
> > and go to SystemSettings > Workspace behavior > General behavior set the
> > Animation speed to the slowest. Then observe 2 actions, maximize and
> > unmaximize windows if:
> > - latte is running
> > - without latte
> > You will see latte somehow breaks Kwin maximizing effect.
> 
> Then it is something totally different that does not occur in my system.
> 
> For the maximizing issue I dont have any breakage in my system, you can open
> a different bug report. I have an idea though, struts are updated during the
> hiding gap animation.

Done: https://bugs.kde.org/show_bug.cgi?id=431255
Comment 16 Michail Vourlakos 2021-01-08 18:28:02 UTC
@trmdi is this still present in your system ?
Comment 17 trmdi 2021-01-09 02:07:31 UTC
It's very smooth now. :)