Bug 431211

Summary: window rules: cannot apply changes in value fields until the focus is set to another field manually
Product: [Applications] systemsettings Reporter: Till Schäfer <till2.schaefer>
Component: kcm_kwinrulesAssignee: KWin default assignee <kwin-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: isma.af, nate, plasma-bugs-null
Priority: NOR    
Version First Reported In: 5.20.4   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://invent.kde.org/plasma/kwin/commit/3b87c6ea2dd854b4f5ce0f7f7af66d0184e9104f Version Fixed/Implemented In: 5.22
Sentry Crash Report:

Description Till Schäfer 2021-01-06 09:15:45 UTC 
When editing a text or number value in a window rule in systemsettings, the apply button is greyed out until the fokus is set to another field

Steps to Reproduce: 
1. edit window rule
2. edit description

Result: 
Apply button greyed out

Expected Result: 
I can apply the change. 

Operating System: Gentoo Linux
KDE Plasma Version: 5.20.4
KDE Frameworks Version: 5.77.0
Qt Version: 5.15.2
Kernel Version: 5.9.14-gentoo
OS Type: 64-bit
Processors: 8 × Intel® Core™ i7-3770 CPU @ 3.40GHz
Memory: 30.9 GiB of RAM
Graphics Processor: Mesa DRI Intel® HD Graphics 4000
Comment 1 Bug Janitor Service 2021-02-06 18:24:22 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/664
Comment 2 Ismael Asensio 2021-02-13 22:58:16 UTC 
Git commit 3b87c6ea2dd854b4f5ce0f7f7af66d0184e9104f by Ismael Asensio.
Committed on 13/02/2021 at 22:57.
Pushed by iasensio into branch 'master'.

kcm/kwinrules: Update values on text edit

Previously the text values were updated to the model after
`onEditingFinished()`, that is after losing focus, to prevent
erroneus updates.

This was making also the `needsSaving` signal fire only after
a focus change, which is not consistent with the behavior of
other KCMs.

Use `onTextEdit()` instead, so the model is updated as the user
types.

M  +10   -5    src/kcmkwin/kwinrules/package/contents/ui/ValueEditor.qml

https://invent.kde.org/plasma/kwin/commit/3b87c6ea2dd854b4f5ce0f7f7af66d0184e9104f