Bug 431167

Summary:	Holidays for Mauritius in 2021
Product:	[Frameworks and Libraries] frameworks-kholidays	Reporter:	Nadim Attari <nadim.attari>
Component:	general	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	winter
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	git diff

Description Nadim Attari 2021-01-05 05:15:08 UTC

Created attachment 134558 [details]
git diff

diff --git a/holidays/plan2/holiday_mu_en b/holidays/plan2/holiday_mu_en
index 38e8441..4268a66 100644
--- a/holidays/plan2/holiday_mu_en
+++ b/holidays/plan2/holiday_mu_en
@@ -5,9 +5,9 @@
 ::
 :: Author:   Nadim Attari <nadim.attari@gmail.com>
 ::
-:: Updated:  2018-12-24
+:: Updated:  2021-01-05
 ::
-:: Source:   Public holidays have been taken from http://pmo.govmu.org/English/Documents/Communiqu%C3%A9%20and%20Reports/Public%20Holidays%20-%202019.pdf
+:: Source:   Public holidays have been taken from https://pmo.govmu.org/Communique/Public%20holidays%20-%202021.pdf
 ::           Note: Only the fixed holidays are available. Some celebrations depend on
 ::           special events, eg: The exact date of Eid-ul-Fitr is subject to
 ::           confirmation as its celebration depends on the visibility of the moon
@@ -22,18 +22,18 @@ description "National holiday file for Mauritius"
 :: Public Holidays
 "New Year"                          public on january 01
 "New Year"                          public on january 02
-"Thaipoosam Cavadee"                public religious on january 21
+"Thaipoosam Cavadee"                public religious on january 28
 "Abolition Of Slavery"              public on february 01
-"Chinese Spring Festival"           public religious on february 05
-"Maha Shivaratree"                  public religious on march 04
+"Chinese Spring Festival"           public religious on february 12
+"Maha Shivaratree"                  public religious on march 11
 "Independence And Republic Day"     public on march 12
-"Ugaadi"                            public religious on april 06
+"Ugaadi"                            public religious on april 13
 "Labour Day"                        public on may 01
-"Eid-ul-Fitr"		                public religious on june 05
-"Ganesh Chaturthi"                  public religious on september 03
-"Divali"				            public religious on october 27
+"Eid-ul-Fitr"                       public religious on may 14
+"Ganesh Chaturthi"                  public religious on september 11
 "All Saints Day"                    public religious on november 01
 "Arrival Of Indentured Labourers"   public on november 02
+"Divali"                            public religious on november 04
 "Christmas"                         public on december 25
 
 :: Religious
@@ -50,8 +50,8 @@ description "National holiday file for Mauritius"
 "Urs Khwaja Ghareeb Nawaaz"                 religious on hijri rajab 6
 "Me'raaj-un-Nabi"                           religious on hijri rajab 27
 "Shab-e-Baraa'at"                           religious on hijri shaban 15
-"Eid-ul-Fitr"		                        religious on hijri shawwal 1
-"Eid-ul-Adha"		                        religious on hijri thualhijjah 10
+"Eid-ul-Fitr"                               religious on hijri shawwal 1
+"Eid-ul-Adha"                               religious on hijri thualhijjah 10
 
 :: Financial

Comment 1 2wxsy58236r3 2021-01-05 07:46:55 UTC

Thanks for the update.

Here are two tips for you:

1. The best way to submit patches is via KDE's Gitlab. After creating an account at KDE Identity self service portal, [1] you can submit a merge request at kholidays' repo. [2]

2. For holidays that vary from year to year, please use one entry for every year. Otherwise, the same date will be used for every year, which will be inaccurate.

For example, the date of Chinese Spring Festival varies from year to year, so to make the holidays file accurate:

"Chinese Spring Festival"           public religious on 05 february 2019
"Chinese Spring Festival"           public religious on 25 january 2020
"Chinese Spring Festival"           public religious on 12 february 2021

[1] https://identity.kde.org/
[2] https://invent.kde.org/frameworks/kholidays

Comment 2 Bug Janitor Service 2021-01-05 09:16:53 UTC

A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kholidays/-/merge_requests/14

Comment 3 Allen Winter 2021-01-06 15:18:30 UTC

commit 9dc7fd7f713fa4463e920bd89bf8d5cfaa6c8781 (HEAD -> master, origin/master, origin/HEAD)
Author: Natsumi Higa <c822c4f23bca1ea6faac79e2@mail.xn--3ds443g>
Date:   Tue Jan 5 18:02:29 2021 +0900

    Update Mauritius holidays for 2021